* fix(rot-rut): surface drop-out reasons in payout request dialog and keep selectors usable (#1884)
Four silent drop paths made a paid RUT invoice invisible in the begaran
dialog (neither eligible nor blocked), and the empty list hid the year
picker so the dialog looked dead:
1. deduction lines without a header deduction_total: a second line-based
candidate query now finds them and they block as DEDUCTION_TOTAL_MISSING
(also at file generation: the 1513 receivable was never booked).
2. partially_paid with the customer share settled: remaining_amount = 0
(total - paid_amount - deduction_total, migration 20260817191708) now
counts as paid in evaluateInvoiceForFile; a genuine partial blocks as
NOT_PAID with the outstanding amount.
3. NO_DEDUCTION_OF_TYPE is no longer filtered out of blocked: the message
points at the other type, and the dialog's empty state adds a
switch-type hint.
4. invoices held by a generated/submitted begaran block as
ALREADY_REQUESTED naming the request; decided requests stay omitted
(finished business, visible in the history list).
The dialog keeps the year picker rendered when the list is empty (current
year as inert fallback) and opens the blocked list by default when nothing
is eligible.
Fixes#1884
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(rot-rut): skeptic hardening: decided requests vanish on both tabs, customer share derived from header fields (#1884)
Two skeptic refutations against the frozen PR head:
1. Regression: the wrong-type branch ran before the active-request lookup,
so invoices of the OTHER type whose begaran was already decided
resurfaced forever as NO_DEDUCTION_OF_TYPE in the opposite tab's blocked
list, and the empty-state hint pointed at a tab where they never appear.
The decided-request skip now runs first, on every tab.
2. Correctness: the paid gate and the NOT_PAID message trusted
remaining_amount, but payment-sync's storno path recomputes it WITHOUT
subtracting deduction_total, so the stored column can carry Skatteverkets
1513 share and the dialog could assert a wrong customer-outstanding
figure. The gate now derives the customer share as
total - paid_amount - deduction_total (the buildInvoiceWriteData /
migration 20260817191708 formula) from fields every settlement path
maintains.
Tests pin both: decided+wrong-type omitted from both lists, corrupted
remaining still classified and reported from the derived share.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs(rot-rut): align CANDIDATE_STATUSES comment with the derived-share gate (#1884)
The skeptic-hardening commit moved the paid gate off remaining_amount to
the derived customer share (total - paid_amount - deduction_total); the
comment still named remaining_amount as the signal.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(rot-rut): explicit decided-status set + correction-path wording (#1884)
Swedish accounting review findings on the candidate list:
1. The decided-begaran skip inferred 'decided' by exclusion (anything not
generated/submitted), so a future request status would make an invoice
vanish from both lists, exactly the silent drop the module forbids.
DECIDED_REQUEST_STATUSES now names paid/partially_paid; any other
status held by a request lands in blocked as ALREADY_REQUESTED with a
generic message. Test pins it.
2. The DEDUCTION_TOTAL_MISSING message said only 'ratta fakturan', which
could read as an invitation to edit a booked invoice directly. The
invoice edit route already refuses sent/paid/booked invoices, and the
message now names the sanctioned path: drafts edit directly, sent or
paid invoices are corrected via credit note + new invoice.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Mattsson
cbfb2201ff