Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
60 lines
2.3 KiB
TypeScript
60 lines
2.3 KiB
TypeScript
import { describe, it, expect, vi } from 'vitest'
|
|
import { checkInboxUploadRateLimit } from '../inbox'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
|
|
function makeSupabase(rpcResult: { data?: unknown; error?: unknown }) {
|
|
return {
|
|
rpc: vi.fn().mockResolvedValue(rpcResult),
|
|
} as unknown as SupabaseClient
|
|
}
|
|
|
|
describe('checkInboxUploadRateLimit', () => {
|
|
it('returns ok=true when the RPC says ok', async () => {
|
|
const supabase = makeSupabase({ data: { ok: true }, error: null })
|
|
const result = await checkInboxUploadRateLimit(supabase, 'company-1')
|
|
expect(result.ok).toBe(true)
|
|
expect(result.scope).toBeUndefined()
|
|
})
|
|
|
|
it('returns ok=false with minute scope and retry_after when minute window hit', async () => {
|
|
const supabase = makeSupabase({
|
|
data: { ok: false, scope: 'minute', retry_after_sec: 42 },
|
|
error: null,
|
|
})
|
|
const result = await checkInboxUploadRateLimit(supabase, 'company-1')
|
|
expect(result.ok).toBe(false)
|
|
expect(result.scope).toBe('minute')
|
|
expect(result.retryAfterSec).toBe(42)
|
|
})
|
|
|
|
it('returns ok=false with day scope when day window hit', async () => {
|
|
const supabase = makeSupabase({
|
|
data: { ok: false, scope: 'day', retry_after_sec: 3600 },
|
|
error: null,
|
|
})
|
|
const result = await checkInboxUploadRateLimit(supabase, 'company-1')
|
|
expect(result.ok).toBe(false)
|
|
expect(result.scope).toBe('day')
|
|
expect(result.retryAfterSec).toBe(3600)
|
|
})
|
|
|
|
it('fails open (ok=true) when the RPC errors: better to accept than 500 a real user', async () => {
|
|
const supabase = makeSupabase({ data: null, error: { message: 'boom' } })
|
|
// Silence the console.error the helper emits on infra error.
|
|
const spy = vi.spyOn(console, 'error').mockImplementation(() => {})
|
|
const result = await checkInboxUploadRateLimit(supabase, 'company-1')
|
|
expect(result.ok).toBe(true)
|
|
spy.mockRestore()
|
|
})
|
|
|
|
it('passes the configured minute and day caps to the RPC', async () => {
|
|
const supabase = makeSupabase({ data: { ok: true }, error: null })
|
|
await checkInboxUploadRateLimit(supabase, 'company-xyz')
|
|
expect(supabase.rpc).toHaveBeenCalledWith('check_and_increment_inbox_quota', {
|
|
p_company_id: 'company-xyz',
|
|
p_minute_max: 30,
|
|
p_day_max: 500,
|
|
})
|
|
})
|
|
})
|