Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
52 lines
1.9 KiB
TypeScript
52 lines
1.9 KiB
TypeScript
/**
|
|
* Swish number normalisation + validation.
|
|
*
|
|
* Two accepted shapes:
|
|
* - Swish Företag: `123XXXXXXX` (10 digits starting with `123`)
|
|
* - Swedish mobile: `07XXXXXXXX` (10 digits starting with `07`)
|
|
*
|
|
* Whitespace and hyphens are stripped before validation so users can paste
|
|
* formatted numbers (`123 456 78 90` or `070-123 45 67`) and have them
|
|
* canonicalised.
|
|
*/
|
|
|
|
import { roundOre } from '@/lib/money'
|
|
|
|
const SWISH_FORETAG = /^123\d{7}$/
|
|
const SWEDISH_MOBILE = /^07\d{8}$/
|
|
|
|
export function normaliseSwish(value: string | null | undefined): string {
|
|
if (!value) return ''
|
|
return value.replace(/[\s-]/g, '')
|
|
}
|
|
|
|
export function isValidSwish(normalised: string): boolean {
|
|
return normalised === '' || SWISH_FORETAG.test(normalised) || SWEDISH_MOBILE.test(normalised)
|
|
}
|
|
|
|
/**
|
|
* Build the Swish "Type C" QR payload: `C<payee>;<amount>;<message>;<editmask>`.
|
|
*
|
|
* editmask 0 locks payee, amount and message, so the Swish app opens prefilled
|
|
* and uneditable. This is the documented format the Swish app scans directly,
|
|
* so the QR can be generated entirely offline (no call to Swish's QR API).
|
|
* Works for both Swish-företag (123XXXXXXX) and mobile (07XXXXXXXX) payees.
|
|
*
|
|
* Returns null when the number is missing/invalid or the amount is not positive.
|
|
* Spec: Swish QR Code Design Specification (Getswish AB).
|
|
*/
|
|
export function buildSwishQrPayload(
|
|
swishNumber: string | null | undefined,
|
|
amount: number,
|
|
message: string,
|
|
): string | null {
|
|
const number = normaliseSwish(swishNumber)
|
|
if (!number || !isValidSwish(number)) return null
|
|
if (!(amount > 0)) return null
|
|
// Amount uses a dot decimal with at most two decimals. The message must not
|
|
// contain the ';' field delimiter; cap its length to keep the QR scannable.
|
|
const amt = roundOre(amount).toFixed(2)
|
|
const msg = (message ?? '').replace(/;/g, ' ').trim().slice(0, 50)
|
|
return `C${number};${amt};${msg};0`
|
|
}
|