Files
accounted/lib/pending-operations/errors.ts
T
Jakob Wennberg f266c386f3 chore: repo-wide bloat sweep, remove dead code and fold duplicate helpers (#2150)
* chore: repo-wide bloat sweep, remove dead code and fold duplicate helpers

Remove 33 dead files, ~270 unreferenced exports/types, 13 dead i18n
namespaces and 4 unused dependencies; fold byte-identical helper copies
into one canonical home each (lib/utils chunk/sleep/utcDateStamp,
lib/dates/iso, lib/invariants/uuid, lib/xml/escape, lib/reports/sru/format,
lib/pdf/number-text, lib/browser/panel-request, lib/api/v1/body +
v1ValidationError rolled out to ~55 v1 routes, booking-template schemas).

No behaviour change: v1 bodies and status codes, MCP tool schemas, DB
writes and money math are untouched. Naive ore rounding was deliberately
not swapped for roundOre; see DECISIONS.md 2026-09-02 for the full list
of things left alone on purpose.

tsc, lint, 19588 unit tests and check:guards green; antipattern baseline
ratcheted (naive-ore-round 622 -> 620, hand-rolled-invariant 115 -> 113).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(transactions): import RawTransaction from @/types after the ingest re-export removal

CI's type ratchet (check:types, full tsconfig) caught the one test file
that still imported the type through lib/transactions/ingest.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-02 11:51:16 +02:00

32 lines
1.3 KiB
TypeScript

/**
* Typed errors for the pending-operations commit path.
*
* PartialCommitError is thrown by multi-step executors when an irreversible
* side-effect (posted voucher, persisted credit note) already exists and a
* LATER step fails. The dispatcher (commitPendingOperationInner) detects it
* and lands the op in the terminal status 'failed_partial' instead of
* 'rejected', persisting the posted ids in result_data.posted_ids so an
* operator can locate the orphaned voucher/entity (issue #842).
*
* Do NOT throw this before the first irreversible step: a clean failure with
* nothing posted must keep today's 'rejected' semantics.
*/
export class PartialCommitError extends Error {
readonly name = 'PartialCommitError'
/**
* Ids of the entities that were irreversibly created before the failure,
* keyed by a stable snake_case label (e.g. reversal_journal_entry_id,
* payment_journal_entry_id, credit_note_id). Persisted verbatim into
* pending_operations.result_data.posted_ids.
*/
readonly postedIds: Record<string, string>
/** The underlying failure that interrupted the executor. */
readonly cause: unknown
constructor(message: string, postedIds: Record<string, string>, cause?: unknown) {
super(message)
this.postedIds = postedIds
this.cause = cause
}
}