* refactor(invoices): extract editor payload builders with parity tests
Extract the three near-identical inline payload builders in InvoiceEditor.tsx
(handleConfirm, saveDraftData, saveEdit) and the self-billed body mapper into
pure functions in lib/invoices/editor-payload.ts. Zero behavioral change: the
new lib module carries a 300-case parity suite asserting JSON byte equality
against verbatim copies of the legacy inline recipes across the full
mode x deduction x dimensions x ore-rounding matrix. This is the
byte-compatibility ratchet under the upcoming editor re-layout: the repo
renders no components in tests, so the wire bodies are what CI can pin.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(invoices): rebuild the invoice editor as the snabbflöde single column
Reshape InvoiceEditor to the approved prototype: one 640px column with
uppercase section labels and honest state marks (RequiredMark asterisks,
sage check on a picked customer, muted row counts), a dense in-table rows
surface with a unified last-row entry (autocomplete over the artikelregister,
italic ghost cells, Enter commits free text and lands in the price cell,
ArrowDown+Enter commits an article through the same applyArticle side
effects), hover-revealed 24px row controls with 40px coarse-pointer targets
and per-row aria-labels, a Förval chip line whose collapsed settings
re-surface as chips whenever a value deviates from its default (critical in
edit/copy so PATCH never round-trips invisible values), a single ochre
next-step line (aria-live polite) that doubles as the invalid-submit focus
router, and a sticky bottom action bar with the live total: position sticky
in both hosts, never fixed, since DialogContent's transform re-anchors fixed
children in bare mode.
Behavioral deltas, all pre-decided: the primary action is never disabled
pre-click for writable users (viewers keep the lock+tooltip treatment);
client-side validation failures route focus instead of toasting; genuine
field errors stay terracotta and field-adjacent while the two ochre
disclosures (taxed-where-performed, labor-only) demote to muted text;
committed free-text rows expose a quiet Spara-som-artikel link; the review
dialog lists the applied förval (currency, öre rounding, payment-link
state); a freshly committed row gets a brief background settle that
collapses under prefers-reduced-motion. ArticleCombobox gains the missing
combobox ARIA (listbox/option roles, aria-controls, aria-activedescendant
only after explicit arrowing). New pure module invoice-editor-flow.ts pins
the next-step priority order, the Förval chip derivation and the suggestion
filter with unit tests. All payload builders, submit targets and the VAT
baseline refs are untouched.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(invoices): editor review nits: orphaned keys, housing gate, listbox ARIA
Three review findings on the snabbflode editor:
- Delete 13 orphaned invoice_editor keys from both message files
(subtitle_*, add_row, remove_row, remove_row_aria, details_card_title,
save_as_draft_short, validation_toast_*, delivery_date_placeholder);
each verified unused on the branch, sv/en parity kept.
- Gate the housing next-step on a claimed deduction amount so it matches
the ROT/RUT claim card's mount condition: a ROT-flagged line with a
zero amount mounts no card, and the ochre link would try to focus an
unmounted field. Extracted as deriveRequiresHousing in the flow module
with a test proven to fail on the old gate.
- Move the entry-row popover hint out of the role=listbox element
(listbox children must be options) into a sibling inside the absolute
wrapper, referenced via aria-describedby on the combobox input.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* feat(invoices): drop the in-editor faktura/sjalvfaktura tabs
The Ny faktura split button already chooses the mode (?self=1); a second
switcher inside the editor was double steering. The mode is now fixed for
the editor's lifetime and the heading (Registrera sjalvfaktura) carries
the distinction. Orphaned tab keys removed from both message files.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(invoices): wrap sticky-bar actions so they fit small viewports
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(invoices): stop dialog grid item overflowing small viewports
min-w-0 on the editor root: DialogContent is display:grid, so the row
grid's min-w otherwise forces the column past narrow screens.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(invoices): lift assistant FAB above the standalone editor's action bar
The rebuilt editor introduces the first page-level sticky bottom bar; the
assistant FAB (fixed, z-30) covered its Spara/Granska buttons on the
/invoices/[id]/edit page. The editor now sets body[data-page-bottom-bar]
in non-bare mode and AgentTrigger lifts to bottom-20 when it is present.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Jakob Wennberg
2b5b813b7a