d0fbc2b616
* refactor(ui): app-wide UI/UX consistency pass
Net: +1,159 / −1,373 LOC across 77 files. No new features, no behavior
changes. Locks in a uniform design system across every dashboard surface.
What changed:
- **Foundation**: sidebar width 232→256px (md:w-64), spacing scale locked
(Tailwind 1/2/3/4/6/8/10/12; 2.5/5 forbidden), card padding p-6 default
(p-4 for compact metric cards), space-y-8 between page sections.
- **Tables unified**: all 33 thead blocks now share the Resultatrapport
pattern via shadcn Table primitive (text-[11px] font-medium uppercase
tracking-wider text-muted-foreground). Hand-rolled <table> instances
converted where they were data tables; form/edit grids kept distinct.
- **Status badges unified**: every status indicator routes through
shadcn <Badge variant>. Eliminated raw Tailwind colors
(bg-amber-100, bg-emerald-500/10, bg-blue-100, bg-purple-100, etc.)
in favor of the gnubok semantic palette (success=sage, warning=ochre,
destructive=terracotta).
- **Empty states unified**: list pages migrated from hand-rolled
"flex flex-col items-center py-12" divs to the EmptyState primitive.
- **Loading skeletons unified**: hand-rolled bg-muted rounded animate-pulse
divs replaced with shadcn <Skeleton> across 15 files.
- **Touch targets**: 6 back-buttons + edit-pencil + inbox delete bumped
from 24/32/36px to shadcn's 40px icon default. Added aria-labels on
9 icon-only navigation buttons.
- **Date formatting**: formatDate() for accounting data (ISO yyyy-MM-dd,
table-friendly) vs formatDateLong() for metadata (Swedish long form).
Raw {x.invoice_date} renderings routed through formatDate() in 18 sites.
- **Toast titles**: eliminated 33 generic "Fel" titles. Each toast title
now carries the action ("Kunde inte skapa lönekörning" etc.) with
description carrying the error detail.
- **Page-level cleanups**:
- Dashboard: dropped greeting hero + Snabbåtgärder/Att hantera nav
duplicates + Visa detaljer collapsible.
- Reports: 5-col mega-menu replaced with left-rail layout
(new ReportsNav component).
- Bookkeeping: fixed layout jump between Verifikationer/Ny verifikation
tabs (moved FiscalYearSelector inside journal tab).
- Bookkeeping: added voucher sort (A1 first / latest first) alongside
existing date sort. Required matching API param sort_by.
- KPI page: FiscalYearSelector instead of raw <select>; InfoTooltip
instead of inline info-button toggle; bigger numbers.
- Salary section: enum values translated to Swedish labels, mobile
table collapses to Anställd+Netto on <md, KPI typography aligned
with dashboard.
- Invoice forms: styled RequiredMark + aria-required, tabular-nums
on amount inputs.
- **CLAUDE.md**: new "Design System Tokens" subsection documents the
locked spacing scale, primitives table, typography rules, date helpers,
and forbidden patterns so future contributors don't drift.
Tests: 2,906 passing (unchanged). Lint: unchanged from main baseline.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address PR review feedback (Greptile + compliance bot)
- **formatDate / formatDateLong timezone fix**: switch from new Date() to
parseISO. Bare yyyy-MM-dd strings are now parsed as local midnight rather
than UTC midnight, eliminating the off-by-one display in west-of-UTC
timezones flagged by Greptile.
- **DashboardContentProps cleanup**: removed unused firstName and settings
fields from the interface, and the corresponding fetch (profiles table)
+ computation in app/(dashboard)/page.tsx. The greeting was dropped in
the dashboard cleanup; these props were dead weight.
- **Voucher sort behavior documented**: extended the comment in the journal
entries API route to explain why voucher sort intentionally uses strict
fiscal_period_id filtering (BFL 5 kap 6–7 §§ — voucher numbers are
series-scoped within a fiscal year). The row-count delta between date
sort and voucher sort is now a documented design choice.
- **delete_last_voucher migration + draft-delete test included**: the UI
already shipped the "Radera utkast" path in the previous commit; this
pulls in the backing RPC migration that allows draft deletes (with the
full safety logic — drafts skip series/period checks since they have
voucher_number=0, posted entries go through the existing unchanged
path). This was originally meant for a separate PR but the UI shipped
half the feature without it.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore(migration): rename to match applied version
The function delete_last_voucher is already applied to the production DB
under version 20260509103736 (verified via pg_get_functiondef — exact
byte-for-byte match to file content). The previous file timestamp
20260509120000 would cause a fresh `supabase db push` to attempt re-applying
under a different version row. Renaming the file aligns local tracking
with what the database actually has.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix: address compliance bot findings (payroll label + VAT visibility)
- sick_karens label: drop "(första sjukdagen)" qualifier. Per sjuklönelagen
6 §, karensavdrag is a single calculated amount (20% of one week's
sjuklön) deducted from the first sick day's pay — not bounded to the
first day. The qualifier could mislead users when the first sick day
and return-to-work span a weekend. Swedish-payroll bot recommendation.
- Omvänd skattskyldighet badge: variant outline → warning. The reverse-
charge indicator is compliance-critical (ML 16 kap) — missing it leads
to incorrect input VAT deduction. Outline was too subtle; warning's
ochre fill matches its semantic weight.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
169 lines
5.9 KiB
TypeScript
169 lines
5.9 KiB
TypeScript
'use client'
|
|
|
|
import { Badge } from '@/components/ui/badge'
|
|
import { AccountNumber } from '@/components/ui/account-number'
|
|
import { CheckCircle2, Paperclip } from 'lucide-react'
|
|
|
|
interface ReviewLine {
|
|
account_number: string
|
|
debit_amount: string
|
|
credit_amount: string
|
|
line_description: string
|
|
}
|
|
|
|
interface JournalEntryReviewContentProps {
|
|
periodName: string
|
|
entryDate: string
|
|
description: string
|
|
notes?: string
|
|
voucherSeries?: string
|
|
lines: ReviewLine[]
|
|
totalDebit: number
|
|
totalCredit: number
|
|
attachmentCount?: number
|
|
showBalanceBadge?: boolean
|
|
hideDate?: boolean
|
|
}
|
|
|
|
function formatAmount(amount: number): string {
|
|
return amount.toLocaleString('sv-SE', { minimumFractionDigits: 2, maximumFractionDigits: 2 })
|
|
}
|
|
|
|
export function JournalEntryReviewContent({
|
|
periodName,
|
|
entryDate,
|
|
description,
|
|
notes,
|
|
voucherSeries,
|
|
lines,
|
|
totalDebit,
|
|
totalCredit,
|
|
attachmentCount,
|
|
showBalanceBadge = true,
|
|
hideDate = false,
|
|
}: JournalEntryReviewContentProps) {
|
|
const activeLines = lines.filter(
|
|
(l) => l.account_number && (l.debit_amount || l.credit_amount)
|
|
)
|
|
|
|
return (
|
|
<div className="space-y-4">
|
|
{/* Header info */}
|
|
<div className="bg-muted rounded-lg p-4 space-y-2">
|
|
<div className={`grid gap-4 text-sm ${hideDate && !voucherSeries ? 'grid-cols-1' : hideDate || !voucherSeries ? 'grid-cols-2' : 'grid-cols-3'}`}>
|
|
<div>
|
|
<span className="text-muted-foreground">Räkenskapsår</span>
|
|
<p className="font-medium">{periodName}</p>
|
|
</div>
|
|
{!hideDate && (
|
|
<div>
|
|
<span className="text-muted-foreground">Datum</span>
|
|
<p className="font-medium">{entryDate}</p>
|
|
</div>
|
|
)}
|
|
{voucherSeries && (
|
|
<div>
|
|
<span className="text-muted-foreground">Serie</span>
|
|
<p className="font-medium font-mono">{voucherSeries}</p>
|
|
</div>
|
|
)}
|
|
</div>
|
|
<div className="text-sm">
|
|
<span className="text-muted-foreground">Beskrivning</span>
|
|
<p className="font-medium">{description}</p>
|
|
</div>
|
|
{notes && (
|
|
<div className="text-sm">
|
|
<span className="text-muted-foreground">Intern anteckning</span>
|
|
<p className="text-muted-foreground italic">{notes}</p>
|
|
</div>
|
|
)}
|
|
</div>
|
|
|
|
{/* Balance status */}
|
|
{(showBalanceBadge || (attachmentCount != null && attachmentCount > 0)) && (
|
|
<div className="flex items-center gap-2">
|
|
{showBalanceBadge && (
|
|
<Badge className="bg-success/10 text-success">
|
|
<CheckCircle2 className="h-3 w-3 mr-1" />
|
|
Debet = Kredit
|
|
</Badge>
|
|
)}
|
|
{attachmentCount != null && attachmentCount > 0 && (
|
|
<Badge variant="outline">
|
|
<Paperclip className="h-3 w-3 mr-1" />
|
|
{attachmentCount} {attachmentCount === 1 ? 'underlag' : 'underlag'}
|
|
</Badge>
|
|
)}
|
|
</div>
|
|
)}
|
|
|
|
{/* Debit/Credit — table on desktop, cards on mobile */}
|
|
<div className="hidden sm:block">
|
|
<table className="w-full text-sm">
|
|
<thead className="[&_th]:font-medium [&_th]:text-[11px] [&_th]:uppercase [&_th]:tracking-wider [&_th]:text-muted-foreground">
|
|
<tr className="border-b text-left">
|
|
<th className="py-2 w-24">Konto</th>
|
|
<th className="py-2">Beskrivning</th>
|
|
<th className="py-2 w-28 text-right">Debet</th>
|
|
<th className="py-2 w-28 text-right">Kredit</th>
|
|
</tr>
|
|
</thead>
|
|
<tbody>
|
|
{activeLines.map((line, index) => (
|
|
<tr key={index} className="border-b last:border-0">
|
|
<td className="py-2">
|
|
<AccountNumber number={line.account_number} />
|
|
</td>
|
|
<td className="py-2 text-muted-foreground">
|
|
{line.line_description || ''}
|
|
</td>
|
|
<td className="py-2 text-right">
|
|
{parseFloat(line.debit_amount) > 0
|
|
? formatAmount(parseFloat(line.debit_amount))
|
|
: ''}
|
|
</td>
|
|
<td className="py-2 text-right">
|
|
{parseFloat(line.credit_amount) > 0
|
|
? formatAmount(parseFloat(line.credit_amount))
|
|
: ''}
|
|
</td>
|
|
</tr>
|
|
))}
|
|
</tbody>
|
|
<tfoot>
|
|
<tr className="font-semibold border-t-2">
|
|
<td colSpan={2} className="py-2">Summa</td>
|
|
<td className="py-2 text-right text-success">{formatAmount(totalDebit)}</td>
|
|
<td className="py-2 text-right text-success">{formatAmount(totalCredit)}</td>
|
|
</tr>
|
|
</tfoot>
|
|
</table>
|
|
</div>
|
|
<div className="sm:hidden space-y-1.5">
|
|
{activeLines.map((line, index) => (
|
|
<div key={index} className="flex items-center justify-between py-2 border-b last:border-0 text-sm">
|
|
<div className="min-w-0">
|
|
<div className="flex items-center gap-1.5">
|
|
<AccountNumber number={line.account_number} />
|
|
{line.line_description && (
|
|
<span className="text-muted-foreground text-xs truncate">{line.line_description}</span>
|
|
)}
|
|
</div>
|
|
</div>
|
|
<span className="font-mono text-sm shrink-0 ml-2">
|
|
{parseFloat(line.debit_amount) > 0
|
|
? `D ${formatAmount(parseFloat(line.debit_amount))}`
|
|
: `K ${formatAmount(parseFloat(line.credit_amount))}`}
|
|
</span>
|
|
</div>
|
|
))}
|
|
<div className="flex justify-between pt-2 border-t-2 font-semibold text-sm">
|
|
<span>Summa</span>
|
|
<span className="text-success">D {formatAmount(totalDebit)} / K {formatAmount(totalCredit)}</span>
|
|
</div>
|
|
</div>
|
|
</div>
|
|
)
|
|
}
|