* feat(inbox): skip AI extraction for multi-page PDFs (#553) Bedrock churns for minutes on multi-page PDFs (sales reports, bank statements, contracts) and returns nothing useful. Above 3 pages we now skip extraction entirely and mark the row with extraction_skipped=true; the document still lands in the inbox and can be attached or converted manually. Same gate applies to the /items/:id/attach path. Client can also opt out via skip_extraction=true (skip_reason=client_opt_out). The InvoiceInboxWorkspace renders an "Inte AI-tolkad" badge for skipped rows, distinct from the "Felaktig" failure state (status='error'). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(ui): introduce DataList + DropdownMenu primitives, roll out across list pages DataList replaces the per-row Card pattern across Granskning, Transactions, Invoices, Supplier invoices, and Pending. One bordered container with hairline rows matches the flat-with-hairlines aesthetic in CLAUDE.md — no shadows, no state-tinted borders, secondary token for selected/hover. DropdownMenu fills the gap for row-level action menus on TransactionInboxCard, TransactionHistoryList, and the page-level action menus on /transactions and /pending. Replaces ad-hoc Popover + buttons constructions. Migrates list pages and the transaction inbox/history components onto the new primitives. No behavior change beyond the visual unification. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: add agent skills + gnubok domain skills, gitignore compliance reports .agents/skills/ + skills-lock.json + symlinks under .claude/skills/ check in the vercel-labs/agent-skills set pinned by the local skill manager (deploy-to-vercel, vercel-cli-with-tokens, react-best-practices, composition-patterns, react-native-skills, react-view-transitions, web-design-guidelines). Keeps the team on the same versions. .claude/skills/industry/ + .claude/skills/modifier/ are hand-authored vertical and entity-modifier skills for the specialized accountant agent — industries (konsult-it, e-handel, bygg-hantverk, reklambyra, saas-ai) and entity overlays (holding-ab, single-shareholder-ab-fmb, mixed- verksamhet). Project-owned content; lives in the repo by design. Also gitignores .compliance-reports/ — those are large generated SARIF/dossier artifacts from the compliance scanner. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(transactions): unify inbox/history chrome, drop swipe flow The transactions page mixed two-tier filtering, a swipe-view detour, and per-row Card chrome that didn't carry its weight. This pass collapses those into a single editorial-list surface and removes the unused swipe path entirely. User-visible changes: - Mode toggle (Att bokföra / Alla transaktioner) moved from a Tabs row under the header into a dropdown to the right of a unified search bar. Search now persists when switching modes. - Removed the swipe categorization view ("Gå igenom alla") and its trigger button. The 800-line SwipeCategorizationView component is deleted; suggestion-fetching shrinks to what the template picker still consumes. - Inbox rows now show one primary action: invoice/supplier-invoice match shortcut when auto-detected, else "Bokför". A new visible Link2 icon button opens the customer or supplier invoice picker manually (chosen by amount sign). Delete becomes a plain trash button — no overflow menu since it only ever held one item. - Bulk action bar swaps "Markera som privat" for "Ta bort" with a single combined confirmation. - Built SupplierInvoicePicker mirroring InvoicePicker so expense transactions can be matched to supplier invoices from the inbox. Wired through /api/transactions/{id}/match-supplier-invoice. - Template picker dialog renamed to "Bokför transaktion"; "Bokför manuellt…" and "Matcha med faktura…" promoted from muted ghost buttons at the bottom to outline buttons at the top, above the template list. - Breathing room: row padding py-3 → py-4, primary text text-sm → text-base, amount text-base, button heights h-8 → h-9, trailing gap-2 → gap-3 (in the DataList primitive itself, so every list benefits slightly). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: align package-lock.json with merged package.json The merge resolution took origin/main's package-lock.json (which dropped pdf-lib) but kept our package.json (which still requires pdf-lib for the invoice-inbox extension's PDFDocument import). `npm ci` rejected the mismatch. Regenerate the lock from the merged package.json so both files agree. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: regenerate package-lock.json with npm@10 for CI compat Local npm@11 produced a lock that npm@10 (CI) rejected with "Missing: @swc/helpers@0.5.21". Regenerated with npm@10 --package-lock-only so CI can install. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(transactions): supplier-invoice status-leak guard + drop dead prop Two follow-ups from the merge-risk audit: - SupplierInvoicePicker now mirrors InvoicePicker's status-leak guard: if a supplier invoice is still 'approved'/'overdue' but already has a payment voucher attached (journal_entry_id on supplier_invoice_payments), hide it. Closes a UX race window between payment and status flip. Partially-paid invoices still pass through. - Drop the unused onMarkPrivate prop on TransactionInboxCard and the matching handleMarkPrivate wrapper in the parent. Both became dead when the swipe-categorisation flow was removed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
78 lines
1.8 KiB
Markdown
78 lines
1.8 KiB
Markdown
---
|
|
title: Use Native Modals Over JS-Based Bottom Sheets
|
|
impact: HIGH
|
|
impactDescription: native performance, gestures, accessibility
|
|
tags: modals, bottom-sheet, native, react-navigation
|
|
---
|
|
|
|
## Use Native Modals Over JS-Based Bottom Sheets
|
|
|
|
Use native `<Modal>` with `presentationStyle="formSheet"` or React Navigation
|
|
v7's native form sheet instead of JS-based bottom sheet libraries. Native modals
|
|
have built-in gestures, accessibility, and better performance. Rely on native UI
|
|
for low-level primitives.
|
|
|
|
**Incorrect (JS-based bottom sheet):**
|
|
|
|
```tsx
|
|
import BottomSheet from 'custom-js-bottom-sheet'
|
|
|
|
function MyScreen() {
|
|
const sheetRef = useRef<BottomSheet>(null)
|
|
|
|
return (
|
|
<View style={{ flex: 1 }}>
|
|
<Button onPress={() => sheetRef.current?.expand()} title='Open' />
|
|
<BottomSheet ref={sheetRef} snapPoints={['50%', '90%']}>
|
|
<View>
|
|
<Text>Sheet content</Text>
|
|
</View>
|
|
</BottomSheet>
|
|
</View>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct (native Modal with formSheet):**
|
|
|
|
```tsx
|
|
import { Modal, View, Text, Button } from 'react-native'
|
|
|
|
function MyScreen() {
|
|
const [visible, setVisible] = useState(false)
|
|
|
|
return (
|
|
<View style={{ flex: 1 }}>
|
|
<Button onPress={() => setVisible(true)} title='Open' />
|
|
<Modal
|
|
visible={visible}
|
|
presentationStyle='formSheet'
|
|
animationType='slide'
|
|
onRequestClose={() => setVisible(false)}
|
|
>
|
|
<View>
|
|
<Text>Sheet content</Text>
|
|
</View>
|
|
</Modal>
|
|
</View>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct (React Navigation v7 native form sheet):**
|
|
|
|
```tsx
|
|
// In your navigator
|
|
<Stack.Screen
|
|
name='Details'
|
|
component={DetailsScreen}
|
|
options={{
|
|
presentation: 'formSheet',
|
|
sheetAllowedDetents: 'fitToContents',
|
|
}}
|
|
/>
|
|
```
|
|
|
|
Native modals provide swipe-to-dismiss, proper keyboard avoidance, and
|
|
accessibility out of the box.
|