* feat(inbox): skip AI extraction for multi-page PDFs (#553) Bedrock churns for minutes on multi-page PDFs (sales reports, bank statements, contracts) and returns nothing useful. Above 3 pages we now skip extraction entirely and mark the row with extraction_skipped=true; the document still lands in the inbox and can be attached or converted manually. Same gate applies to the /items/:id/attach path. Client can also opt out via skip_extraction=true (skip_reason=client_opt_out). The InvoiceInboxWorkspace renders an "Inte AI-tolkad" badge for skipped rows, distinct from the "Felaktig" failure state (status='error'). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(ui): introduce DataList + DropdownMenu primitives, roll out across list pages DataList replaces the per-row Card pattern across Granskning, Transactions, Invoices, Supplier invoices, and Pending. One bordered container with hairline rows matches the flat-with-hairlines aesthetic in CLAUDE.md — no shadows, no state-tinted borders, secondary token for selected/hover. DropdownMenu fills the gap for row-level action menus on TransactionInboxCard, TransactionHistoryList, and the page-level action menus on /transactions and /pending. Replaces ad-hoc Popover + buttons constructions. Migrates list pages and the transaction inbox/history components onto the new primitives. No behavior change beyond the visual unification. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: add agent skills + gnubok domain skills, gitignore compliance reports .agents/skills/ + skills-lock.json + symlinks under .claude/skills/ check in the vercel-labs/agent-skills set pinned by the local skill manager (deploy-to-vercel, vercel-cli-with-tokens, react-best-practices, composition-patterns, react-native-skills, react-view-transitions, web-design-guidelines). Keeps the team on the same versions. .claude/skills/industry/ + .claude/skills/modifier/ are hand-authored vertical and entity-modifier skills for the specialized accountant agent — industries (konsult-it, e-handel, bygg-hantverk, reklambyra, saas-ai) and entity overlays (holding-ab, single-shareholder-ab-fmb, mixed- verksamhet). Project-owned content; lives in the repo by design. Also gitignores .compliance-reports/ — those are large generated SARIF/dossier artifacts from the compliance scanner. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(transactions): unify inbox/history chrome, drop swipe flow The transactions page mixed two-tier filtering, a swipe-view detour, and per-row Card chrome that didn't carry its weight. This pass collapses those into a single editorial-list surface and removes the unused swipe path entirely. User-visible changes: - Mode toggle (Att bokföra / Alla transaktioner) moved from a Tabs row under the header into a dropdown to the right of a unified search bar. Search now persists when switching modes. - Removed the swipe categorization view ("Gå igenom alla") and its trigger button. The 800-line SwipeCategorizationView component is deleted; suggestion-fetching shrinks to what the template picker still consumes. - Inbox rows now show one primary action: invoice/supplier-invoice match shortcut when auto-detected, else "Bokför". A new visible Link2 icon button opens the customer or supplier invoice picker manually (chosen by amount sign). Delete becomes a plain trash button — no overflow menu since it only ever held one item. - Bulk action bar swaps "Markera som privat" for "Ta bort" with a single combined confirmation. - Built SupplierInvoicePicker mirroring InvoicePicker so expense transactions can be matched to supplier invoices from the inbox. Wired through /api/transactions/{id}/match-supplier-invoice. - Template picker dialog renamed to "Bokför transaktion"; "Bokför manuellt…" and "Matcha med faktura…" promoted from muted ghost buttons at the bottom to outline buttons at the top, above the template list. - Breathing room: row padding py-3 → py-4, primary text text-sm → text-base, amount text-base, button heights h-8 → h-9, trailing gap-2 → gap-3 (in the DataList primitive itself, so every list benefits slightly). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: align package-lock.json with merged package.json The merge resolution took origin/main's package-lock.json (which dropped pdf-lib) but kept our package.json (which still requires pdf-lib for the invoice-inbox extension's PDFDocument import). `npm ci` rejected the mismatch. Regenerate the lock from the merged package.json so both files agree. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: regenerate package-lock.json with npm@10 for CI compat Local npm@11 produced a lock that npm@10 (CI) rejected with "Missing: @swc/helpers@0.5.21". Regenerated with npm@10 --package-lock-only so CI can install. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(transactions): supplier-invoice status-leak guard + drop dead prop Two follow-ups from the merge-risk audit: - SupplierInvoicePicker now mirrors InvoicePicker's status-leak guard: if a supplier invoice is still 'approved'/'overdue' but already has a payment voucher attached (journal_entry_id on supplier_invoice_payments), hide it. Closes a UX race window between payment and status flip. Partially-paid invoices still pass through. - Drop the unused onMarkPrivate prop on TransactionInboxCard and the matching handleMarkPrivate wrapper in the parent. Both became dead when the swipe-categorisation flow was removed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
150 lines
4.3 KiB
Markdown
150 lines
4.3 KiB
Markdown
---
|
|
title: Hoist Static I/O to Module Level
|
|
impact: HIGH
|
|
impactDescription: avoids repeated file/network I/O per request
|
|
tags: server, io, performance, next.js, route-handlers, og-image
|
|
---
|
|
|
|
## Hoist Static I/O to Module Level
|
|
|
|
**Impact: HIGH (avoids repeated file/network I/O per request)**
|
|
|
|
When loading static assets (fonts, logos, images, config files) in route handlers or server functions, hoist the I/O operation to module level. Module-level code runs once when the module is first imported, not on every request. This eliminates redundant file system reads or network fetches that would otherwise run on every invocation.
|
|
|
|
**Incorrect (reads font file on every request):**
|
|
|
|
```typescript
|
|
// app/api/og/route.tsx
|
|
import { ImageResponse } from 'next/og'
|
|
|
|
export async function GET(request: Request) {
|
|
// Runs on EVERY request - expensive!
|
|
const fontData = await fetch(
|
|
new URL('./fonts/Inter.ttf', import.meta.url)
|
|
).then(res => res.arrayBuffer())
|
|
|
|
const logoData = await fetch(
|
|
new URL('./images/logo.png', import.meta.url)
|
|
).then(res => res.arrayBuffer())
|
|
|
|
return new ImageResponse(
|
|
<div style={{ fontFamily: 'Inter' }}>
|
|
<img src={logoData} />
|
|
Hello World
|
|
</div>,
|
|
{ fonts: [{ name: 'Inter', data: fontData }] }
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct (loads once at module initialization):**
|
|
|
|
```typescript
|
|
// app/api/og/route.tsx
|
|
import { ImageResponse } from 'next/og'
|
|
|
|
// Module-level: runs ONCE when module is first imported
|
|
const fontData = fetch(
|
|
new URL('./fonts/Inter.ttf', import.meta.url)
|
|
).then(res => res.arrayBuffer())
|
|
|
|
const logoData = fetch(
|
|
new URL('./images/logo.png', import.meta.url)
|
|
).then(res => res.arrayBuffer())
|
|
|
|
export async function GET(request: Request) {
|
|
// Await the already-started promises
|
|
const [font, logo] = await Promise.all([fontData, logoData])
|
|
|
|
return new ImageResponse(
|
|
<div style={{ fontFamily: 'Inter' }}>
|
|
<img src={logo} />
|
|
Hello World
|
|
</div>,
|
|
{ fonts: [{ name: 'Inter', data: font }] }
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct (synchronous fs at module level):**
|
|
|
|
```typescript
|
|
// app/api/og/route.tsx
|
|
import { ImageResponse } from 'next/og'
|
|
import { readFileSync } from 'fs'
|
|
import { join } from 'path'
|
|
|
|
// Synchronous read at module level - blocks only during module init
|
|
const fontData = readFileSync(
|
|
join(process.cwd(), 'public/fonts/Inter.ttf')
|
|
)
|
|
|
|
const logoData = readFileSync(
|
|
join(process.cwd(), 'public/images/logo.png')
|
|
)
|
|
|
|
export async function GET(request: Request) {
|
|
return new ImageResponse(
|
|
<div style={{ fontFamily: 'Inter' }}>
|
|
<img src={logoData} />
|
|
Hello World
|
|
</div>,
|
|
{ fonts: [{ name: 'Inter', data: fontData }] }
|
|
)
|
|
}
|
|
```
|
|
|
|
**Incorrect (reads config on every call):**
|
|
|
|
```typescript
|
|
import fs from 'node:fs/promises'
|
|
|
|
export async function processRequest(data: Data) {
|
|
const config = JSON.parse(
|
|
await fs.readFile('./config.json', 'utf-8')
|
|
)
|
|
const template = await fs.readFile('./template.html', 'utf-8')
|
|
|
|
return render(template, data, config)
|
|
}
|
|
```
|
|
|
|
**Correct (hoists config and template to module level):**
|
|
|
|
```typescript
|
|
import fs from 'node:fs/promises'
|
|
|
|
const configPromise = fs
|
|
.readFile('./config.json', 'utf-8')
|
|
.then(JSON.parse)
|
|
const templatePromise = fs.readFile('./template.html', 'utf-8')
|
|
|
|
export async function processRequest(data: Data) {
|
|
const [config, template] = await Promise.all([
|
|
configPromise,
|
|
templatePromise,
|
|
])
|
|
|
|
return render(template, data, config)
|
|
}
|
|
```
|
|
|
|
When to use this pattern:
|
|
|
|
- Loading fonts for OG image generation
|
|
- Loading static logos, icons, or watermarks
|
|
- Reading configuration files that don't change at runtime
|
|
- Loading email templates or other static templates
|
|
- Any static asset that's the same across all requests
|
|
|
|
When not to use this pattern:
|
|
|
|
- Assets that vary per request or user
|
|
- Files that may change during runtime (use caching with TTL instead)
|
|
- Large files that would consume too much memory if kept loaded
|
|
- Sensitive data that shouldn't persist in memory
|
|
|
|
With Vercel's [Fluid Compute](https://vercel.com/docs/fluid-compute), module-level caching is especially effective because multiple concurrent requests share the same function instance. The static assets stay loaded in memory across requests without cold start penalties.
|
|
|
|
In traditional serverless, each cold start re-executes module-level code, but subsequent warm invocations reuse the loaded assets until the instance is recycled.
|