* feat(inbox): skip AI extraction for multi-page PDFs (#553) Bedrock churns for minutes on multi-page PDFs (sales reports, bank statements, contracts) and returns nothing useful. Above 3 pages we now skip extraction entirely and mark the row with extraction_skipped=true; the document still lands in the inbox and can be attached or converted manually. Same gate applies to the /items/:id/attach path. Client can also opt out via skip_extraction=true (skip_reason=client_opt_out). The InvoiceInboxWorkspace renders an "Inte AI-tolkad" badge for skipped rows, distinct from the "Felaktig" failure state (status='error'). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(ui): introduce DataList + DropdownMenu primitives, roll out across list pages DataList replaces the per-row Card pattern across Granskning, Transactions, Invoices, Supplier invoices, and Pending. One bordered container with hairline rows matches the flat-with-hairlines aesthetic in CLAUDE.md — no shadows, no state-tinted borders, secondary token for selected/hover. DropdownMenu fills the gap for row-level action menus on TransactionInboxCard, TransactionHistoryList, and the page-level action menus on /transactions and /pending. Replaces ad-hoc Popover + buttons constructions. Migrates list pages and the transaction inbox/history components onto the new primitives. No behavior change beyond the visual unification. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * chore: add agent skills + gnubok domain skills, gitignore compliance reports .agents/skills/ + skills-lock.json + symlinks under .claude/skills/ check in the vercel-labs/agent-skills set pinned by the local skill manager (deploy-to-vercel, vercel-cli-with-tokens, react-best-practices, composition-patterns, react-native-skills, react-view-transitions, web-design-guidelines). Keeps the team on the same versions. .claude/skills/industry/ + .claude/skills/modifier/ are hand-authored vertical and entity-modifier skills for the specialized accountant agent — industries (konsult-it, e-handel, bygg-hantverk, reklambyra, saas-ai) and entity overlays (holding-ab, single-shareholder-ab-fmb, mixed- verksamhet). Project-owned content; lives in the repo by design. Also gitignores .compliance-reports/ — those are large generated SARIF/dossier artifacts from the compliance scanner. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * refactor(transactions): unify inbox/history chrome, drop swipe flow The transactions page mixed two-tier filtering, a swipe-view detour, and per-row Card chrome that didn't carry its weight. This pass collapses those into a single editorial-list surface and removes the unused swipe path entirely. User-visible changes: - Mode toggle (Att bokföra / Alla transaktioner) moved from a Tabs row under the header into a dropdown to the right of a unified search bar. Search now persists when switching modes. - Removed the swipe categorization view ("Gå igenom alla") and its trigger button. The 800-line SwipeCategorizationView component is deleted; suggestion-fetching shrinks to what the template picker still consumes. - Inbox rows now show one primary action: invoice/supplier-invoice match shortcut when auto-detected, else "Bokför". A new visible Link2 icon button opens the customer or supplier invoice picker manually (chosen by amount sign). Delete becomes a plain trash button — no overflow menu since it only ever held one item. - Bulk action bar swaps "Markera som privat" for "Ta bort" with a single combined confirmation. - Built SupplierInvoicePicker mirroring InvoicePicker so expense transactions can be matched to supplier invoices from the inbox. Wired through /api/transactions/{id}/match-supplier-invoice. - Template picker dialog renamed to "Bokför transaktion"; "Bokför manuellt…" and "Matcha med faktura…" promoted from muted ghost buttons at the bottom to outline buttons at the top, above the template list. - Breathing room: row padding py-3 → py-4, primary text text-sm → text-base, amount text-base, button heights h-8 → h-9, trailing gap-2 → gap-3 (in the DataList primitive itself, so every list benefits slightly). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: align package-lock.json with merged package.json The merge resolution took origin/main's package-lock.json (which dropped pdf-lib) but kept our package.json (which still requires pdf-lib for the invoice-inbox extension's PDFDocument import). `npm ci` rejected the mismatch. Regenerate the lock from the merged package.json so both files agree. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix: regenerate package-lock.json with npm@10 for CI compat Local npm@11 produced a lock that npm@10 (CI) rejected with "Missing: @swc/helpers@0.5.21". Regenerated with npm@10 --package-lock-only so CI can install. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(transactions): supplier-invoice status-leak guard + drop dead prop Two follow-ups from the merge-risk audit: - SupplierInvoicePicker now mirrors InvoicePicker's status-leak guard: if a supplier invoice is still 'approved'/'overdue' but already has a payment voucher attached (journal_entry_id on supplier_invoice_payments), hide it. Closes a UX race window between payment and status flip. Partially-paid invoices still pass through. - Drop the unused onMarkPrivate prop on TransactionInboxCard and the matching handleMarkPrivate wrapper in the parent. Both became dead when the swipe-categorisation flow was removed. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
947 lines
22 KiB
Markdown
947 lines
22 KiB
Markdown
# React Composition Patterns
|
|
|
|
**Version 1.0.0**
|
|
Engineering
|
|
January 2026
|
|
|
|
> **Note:**
|
|
> This document is mainly for agents and LLMs to follow when maintaining,
|
|
> generating, or refactoring React codebases using composition. Humans
|
|
> may also find it useful, but guidance here is optimized for automation
|
|
> and consistency by AI-assisted workflows.
|
|
|
|
---
|
|
|
|
## Abstract
|
|
|
|
Composition patterns for building flexible, maintainable React components. Avoid boolean prop proliferation by using compound components, lifting state, and composing internals. These patterns make codebases easier for both humans and AI agents to work with as they scale.
|
|
|
|
---
|
|
|
|
## Table of Contents
|
|
|
|
1. [Component Architecture](#1-component-architecture) — **HIGH**
|
|
- 1.1 [Avoid Boolean Prop Proliferation](#11-avoid-boolean-prop-proliferation)
|
|
- 1.2 [Use Compound Components](#12-use-compound-components)
|
|
2. [State Management](#2-state-management) — **MEDIUM**
|
|
- 2.1 [Decouple State Management from UI](#21-decouple-state-management-from-ui)
|
|
- 2.2 [Define Generic Context Interfaces for Dependency Injection](#22-define-generic-context-interfaces-for-dependency-injection)
|
|
- 2.3 [Lift State into Provider Components](#23-lift-state-into-provider-components)
|
|
3. [Implementation Patterns](#3-implementation-patterns) — **MEDIUM**
|
|
- 3.1 [Create Explicit Component Variants](#31-create-explicit-component-variants)
|
|
- 3.2 [Prefer Composing Children Over Render Props](#32-prefer-composing-children-over-render-props)
|
|
4. [React 19 APIs](#4-react-19-apis) — **MEDIUM**
|
|
- 4.1 [React 19 API Changes](#41-react-19-api-changes)
|
|
|
|
---
|
|
|
|
## 1. Component Architecture
|
|
|
|
**Impact: HIGH**
|
|
|
|
Fundamental patterns for structuring components to avoid prop
|
|
proliferation and enable flexible composition.
|
|
|
|
### 1.1 Avoid Boolean Prop Proliferation
|
|
|
|
**Impact: CRITICAL (prevents unmaintainable component variants)**
|
|
|
|
Don't add boolean props like `isThread`, `isEditing`, `isDMThread` to customize
|
|
|
|
component behavior. Each boolean doubles possible states and creates
|
|
|
|
unmaintainable conditional logic. Use composition instead.
|
|
|
|
**Incorrect: boolean props create exponential complexity**
|
|
|
|
```tsx
|
|
function Composer({
|
|
onSubmit,
|
|
isThread,
|
|
channelId,
|
|
isDMThread,
|
|
dmId,
|
|
isEditing,
|
|
isForwarding,
|
|
}: Props) {
|
|
return (
|
|
<form>
|
|
<Header />
|
|
<Input />
|
|
{isDMThread ? (
|
|
<AlsoSendToDMField id={dmId} />
|
|
) : isThread ? (
|
|
<AlsoSendToChannelField id={channelId} />
|
|
) : null}
|
|
{isEditing ? (
|
|
<EditActions />
|
|
) : isForwarding ? (
|
|
<ForwardActions />
|
|
) : (
|
|
<DefaultActions />
|
|
)}
|
|
<Footer onSubmit={onSubmit} />
|
|
</form>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct: composition eliminates conditionals**
|
|
|
|
```tsx
|
|
// Channel composer
|
|
function ChannelComposer() {
|
|
return (
|
|
<Composer.Frame>
|
|
<Composer.Header />
|
|
<Composer.Input />
|
|
<Composer.Footer>
|
|
<Composer.Attachments />
|
|
<Composer.Formatting />
|
|
<Composer.Emojis />
|
|
<Composer.Submit />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
)
|
|
}
|
|
|
|
// Thread composer - adds "also send to channel" field
|
|
function ThreadComposer({ channelId }: { channelId: string }) {
|
|
return (
|
|
<Composer.Frame>
|
|
<Composer.Header />
|
|
<Composer.Input />
|
|
<AlsoSendToChannelField id={channelId} />
|
|
<Composer.Footer>
|
|
<Composer.Formatting />
|
|
<Composer.Emojis />
|
|
<Composer.Submit />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
)
|
|
}
|
|
|
|
// Edit composer - different footer actions
|
|
function EditComposer() {
|
|
return (
|
|
<Composer.Frame>
|
|
<Composer.Input />
|
|
<Composer.Footer>
|
|
<Composer.Formatting />
|
|
<Composer.Emojis />
|
|
<Composer.CancelEdit />
|
|
<Composer.SaveEdit />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
)
|
|
}
|
|
```
|
|
|
|
Each variant is explicit about what it renders. We can share internals without
|
|
|
|
sharing a single monolithic parent.
|
|
|
|
### 1.2 Use Compound Components
|
|
|
|
**Impact: HIGH (enables flexible composition without prop drilling)**
|
|
|
|
Structure complex components as compound components with a shared context. Each
|
|
|
|
subcomponent accesses shared state via context, not props. Consumers compose the
|
|
|
|
pieces they need.
|
|
|
|
**Incorrect: monolithic component with render props**
|
|
|
|
```tsx
|
|
function Composer({
|
|
renderHeader,
|
|
renderFooter,
|
|
renderActions,
|
|
showAttachments,
|
|
showFormatting,
|
|
showEmojis,
|
|
}: Props) {
|
|
return (
|
|
<form>
|
|
{renderHeader?.()}
|
|
<Input />
|
|
{showAttachments && <Attachments />}
|
|
{renderFooter ? (
|
|
renderFooter()
|
|
) : (
|
|
<Footer>
|
|
{showFormatting && <Formatting />}
|
|
{showEmojis && <Emojis />}
|
|
{renderActions?.()}
|
|
</Footer>
|
|
)}
|
|
</form>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct: compound components with shared context**
|
|
|
|
```tsx
|
|
const ComposerContext = createContext<ComposerContextValue | null>(null)
|
|
|
|
function ComposerProvider({ children, state, actions, meta }: ProviderProps) {
|
|
return (
|
|
<ComposerContext value={{ state, actions, meta }}>
|
|
{children}
|
|
</ComposerContext>
|
|
)
|
|
}
|
|
|
|
function ComposerFrame({ children }: { children: React.ReactNode }) {
|
|
return <form>{children}</form>
|
|
}
|
|
|
|
function ComposerInput() {
|
|
const {
|
|
state,
|
|
actions: { update },
|
|
meta: { inputRef },
|
|
} = use(ComposerContext)
|
|
return (
|
|
<TextInput
|
|
ref={inputRef}
|
|
value={state.input}
|
|
onChangeText={(text) => update((s) => ({ ...s, input: text }))}
|
|
/>
|
|
)
|
|
}
|
|
|
|
function ComposerSubmit() {
|
|
const {
|
|
actions: { submit },
|
|
} = use(ComposerContext)
|
|
return <Button onPress={submit}>Send</Button>
|
|
}
|
|
|
|
// Export as compound component
|
|
const Composer = {
|
|
Provider: ComposerProvider,
|
|
Frame: ComposerFrame,
|
|
Input: ComposerInput,
|
|
Submit: ComposerSubmit,
|
|
Header: ComposerHeader,
|
|
Footer: ComposerFooter,
|
|
Attachments: ComposerAttachments,
|
|
Formatting: ComposerFormatting,
|
|
Emojis: ComposerEmojis,
|
|
}
|
|
```
|
|
|
|
**Usage:**
|
|
|
|
```tsx
|
|
<Composer.Provider state={state} actions={actions} meta={meta}>
|
|
<Composer.Frame>
|
|
<Composer.Header />
|
|
<Composer.Input />
|
|
<Composer.Footer>
|
|
<Composer.Formatting />
|
|
<Composer.Submit />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
</Composer.Provider>
|
|
```
|
|
|
|
Consumers explicitly compose exactly what they need. No hidden conditionals. And the state, actions and meta are dependency-injected by a parent provider, allowing multiple usages of the same component structure.
|
|
|
|
---
|
|
|
|
## 2. State Management
|
|
|
|
**Impact: MEDIUM**
|
|
|
|
Patterns for lifting state and managing shared context across
|
|
composed components.
|
|
|
|
### 2.1 Decouple State Management from UI
|
|
|
|
**Impact: MEDIUM (enables swapping state implementations without changing UI)**
|
|
|
|
The provider component should be the only place that knows how state is managed.
|
|
|
|
UI components consume the context interface—they don't know if state comes from
|
|
|
|
useState, Zustand, or a server sync.
|
|
|
|
**Incorrect: UI coupled to state implementation**
|
|
|
|
```tsx
|
|
function ChannelComposer({ channelId }: { channelId: string }) {
|
|
// UI component knows about global state implementation
|
|
const state = useGlobalChannelState(channelId)
|
|
const { submit, updateInput } = useChannelSync(channelId)
|
|
|
|
return (
|
|
<Composer.Frame>
|
|
<Composer.Input
|
|
value={state.input}
|
|
onChange={(text) => sync.updateInput(text)}
|
|
/>
|
|
<Composer.Submit onPress={() => sync.submit()} />
|
|
</Composer.Frame>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct: state management isolated in provider**
|
|
|
|
```tsx
|
|
// Provider handles all state management details
|
|
function ChannelProvider({
|
|
channelId,
|
|
children,
|
|
}: {
|
|
channelId: string
|
|
children: React.ReactNode
|
|
}) {
|
|
const { state, update, submit } = useGlobalChannel(channelId)
|
|
const inputRef = useRef(null)
|
|
|
|
return (
|
|
<Composer.Provider
|
|
state={state}
|
|
actions={{ update, submit }}
|
|
meta={{ inputRef }}
|
|
>
|
|
{children}
|
|
</Composer.Provider>
|
|
)
|
|
}
|
|
|
|
// UI component only knows about the context interface
|
|
function ChannelComposer() {
|
|
return (
|
|
<Composer.Frame>
|
|
<Composer.Header />
|
|
<Composer.Input />
|
|
<Composer.Footer>
|
|
<Composer.Submit />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
)
|
|
}
|
|
|
|
// Usage
|
|
function Channel({ channelId }: { channelId: string }) {
|
|
return (
|
|
<ChannelProvider channelId={channelId}>
|
|
<ChannelComposer />
|
|
</ChannelProvider>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Different providers, same UI:**
|
|
|
|
```tsx
|
|
// Local state for ephemeral forms
|
|
function ForwardMessageProvider({ children }) {
|
|
const [state, setState] = useState(initialState)
|
|
const forwardMessage = useForwardMessage()
|
|
|
|
return (
|
|
<Composer.Provider
|
|
state={state}
|
|
actions={{ update: setState, submit: forwardMessage }}
|
|
>
|
|
{children}
|
|
</Composer.Provider>
|
|
)
|
|
}
|
|
|
|
// Global synced state for channels
|
|
function ChannelProvider({ channelId, children }) {
|
|
const { state, update, submit } = useGlobalChannel(channelId)
|
|
|
|
return (
|
|
<Composer.Provider state={state} actions={{ update, submit }}>
|
|
{children}
|
|
</Composer.Provider>
|
|
)
|
|
}
|
|
```
|
|
|
|
The same `Composer.Input` component works with both providers because it only
|
|
|
|
depends on the context interface, not the implementation.
|
|
|
|
### 2.2 Define Generic Context Interfaces for Dependency Injection
|
|
|
|
**Impact: HIGH (enables dependency-injectable state across use-cases)**
|
|
|
|
Define a **generic interface** for your component context with three parts:
|
|
|
|
`state`, `actions`, and `meta`. This interface is a contract that any provider
|
|
|
|
can implement—enabling the same UI components to work with completely different
|
|
|
|
state implementations.
|
|
|
|
**Core principle:** Lift state, compose internals, make state
|
|
|
|
dependency-injectable.
|
|
|
|
**Incorrect: UI coupled to specific state implementation**
|
|
|
|
```tsx
|
|
function ComposerInput() {
|
|
// Tightly coupled to a specific hook
|
|
const { input, setInput } = useChannelComposerState()
|
|
return <TextInput value={input} onChangeText={setInput} />
|
|
}
|
|
```
|
|
|
|
**Correct: generic interface enables dependency injection**
|
|
|
|
```tsx
|
|
// Define a GENERIC interface that any provider can implement
|
|
interface ComposerState {
|
|
input: string
|
|
attachments: Attachment[]
|
|
isSubmitting: boolean
|
|
}
|
|
|
|
interface ComposerActions {
|
|
update: (updater: (state: ComposerState) => ComposerState) => void
|
|
submit: () => void
|
|
}
|
|
|
|
interface ComposerMeta {
|
|
inputRef: React.RefObject<TextInput>
|
|
}
|
|
|
|
interface ComposerContextValue {
|
|
state: ComposerState
|
|
actions: ComposerActions
|
|
meta: ComposerMeta
|
|
}
|
|
|
|
const ComposerContext = createContext<ComposerContextValue | null>(null)
|
|
```
|
|
|
|
**UI components consume the interface, not the implementation:**
|
|
|
|
```tsx
|
|
function ComposerInput() {
|
|
const {
|
|
state,
|
|
actions: { update },
|
|
meta,
|
|
} = use(ComposerContext)
|
|
|
|
// This component works with ANY provider that implements the interface
|
|
return (
|
|
<TextInput
|
|
ref={meta.inputRef}
|
|
value={state.input}
|
|
onChangeText={(text) => update((s) => ({ ...s, input: text }))}
|
|
/>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Different providers implement the same interface:**
|
|
|
|
```tsx
|
|
// Provider A: Local state for ephemeral forms
|
|
function ForwardMessageProvider({ children }: { children: React.ReactNode }) {
|
|
const [state, setState] = useState(initialState)
|
|
const inputRef = useRef(null)
|
|
const submit = useForwardMessage()
|
|
|
|
return (
|
|
<ComposerContext
|
|
value={{
|
|
state,
|
|
actions: { update: setState, submit },
|
|
meta: { inputRef },
|
|
}}
|
|
>
|
|
{children}
|
|
</ComposerContext>
|
|
)
|
|
}
|
|
|
|
// Provider B: Global synced state for channels
|
|
function ChannelProvider({ channelId, children }: Props) {
|
|
const { state, update, submit } = useGlobalChannel(channelId)
|
|
const inputRef = useRef(null)
|
|
|
|
return (
|
|
<ComposerContext
|
|
value={{
|
|
state,
|
|
actions: { update, submit },
|
|
meta: { inputRef },
|
|
}}
|
|
>
|
|
{children}
|
|
</ComposerContext>
|
|
)
|
|
}
|
|
```
|
|
|
|
**The same composed UI works with both:**
|
|
|
|
```tsx
|
|
// Works with ForwardMessageProvider (local state)
|
|
<ForwardMessageProvider>
|
|
<Composer.Frame>
|
|
<Composer.Input />
|
|
<Composer.Submit />
|
|
</Composer.Frame>
|
|
</ForwardMessageProvider>
|
|
|
|
// Works with ChannelProvider (global synced state)
|
|
<ChannelProvider channelId="abc">
|
|
<Composer.Frame>
|
|
<Composer.Input />
|
|
<Composer.Submit />
|
|
</Composer.Frame>
|
|
</ChannelProvider>
|
|
```
|
|
|
|
**Custom UI outside the component can access state and actions:**
|
|
|
|
```tsx
|
|
function ForwardMessageDialog() {
|
|
return (
|
|
<ForwardMessageProvider>
|
|
<Dialog>
|
|
{/* The composer UI */}
|
|
<Composer.Frame>
|
|
<Composer.Input placeholder="Add a message, if you'd like." />
|
|
<Composer.Footer>
|
|
<Composer.Formatting />
|
|
<Composer.Emojis />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
|
|
{/* Custom UI OUTSIDE the composer, but INSIDE the provider */}
|
|
<MessagePreview />
|
|
|
|
{/* Actions at the bottom of the dialog */}
|
|
<DialogActions>
|
|
<CancelButton />
|
|
<ForwardButton />
|
|
</DialogActions>
|
|
</Dialog>
|
|
</ForwardMessageProvider>
|
|
)
|
|
}
|
|
|
|
// This button lives OUTSIDE Composer.Frame but can still submit based on its context!
|
|
function ForwardButton() {
|
|
const {
|
|
actions: { submit },
|
|
} = use(ComposerContext)
|
|
return <Button onPress={submit}>Forward</Button>
|
|
}
|
|
|
|
// This preview lives OUTSIDE Composer.Frame but can read composer's state!
|
|
function MessagePreview() {
|
|
const { state } = use(ComposerContext)
|
|
return <Preview message={state.input} attachments={state.attachments} />
|
|
}
|
|
```
|
|
|
|
The provider boundary is what matters—not the visual nesting. Components that
|
|
|
|
need shared state don't have to be inside the `Composer.Frame`. They just need
|
|
|
|
to be within the provider.
|
|
|
|
The `ForwardButton` and `MessagePreview` are not visually inside the composer
|
|
|
|
box, but they can still access its state and actions. This is the power of
|
|
|
|
lifting state into providers.
|
|
|
|
The UI is reusable bits you compose together. The state is dependency-injected
|
|
|
|
by the provider. Swap the provider, keep the UI.
|
|
|
|
### 2.3 Lift State into Provider Components
|
|
|
|
**Impact: HIGH (enables state sharing outside component boundaries)**
|
|
|
|
Move state management into dedicated provider components. This allows sibling
|
|
|
|
components outside the main UI to access and modify state without prop drilling
|
|
|
|
or awkward refs.
|
|
|
|
**Incorrect: state trapped inside component**
|
|
|
|
```tsx
|
|
function ForwardMessageComposer() {
|
|
const [state, setState] = useState(initialState)
|
|
const forwardMessage = useForwardMessage()
|
|
|
|
return (
|
|
<Composer.Frame>
|
|
<Composer.Input />
|
|
<Composer.Footer />
|
|
</Composer.Frame>
|
|
)
|
|
}
|
|
|
|
// Problem: How does this button access composer state?
|
|
function ForwardMessageDialog() {
|
|
return (
|
|
<Dialog>
|
|
<ForwardMessageComposer />
|
|
<MessagePreview /> {/* Needs composer state */}
|
|
<DialogActions>
|
|
<CancelButton />
|
|
<ForwardButton /> {/* Needs to call submit */}
|
|
</DialogActions>
|
|
</Dialog>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Incorrect: useEffect to sync state up**
|
|
|
|
```tsx
|
|
function ForwardMessageDialog() {
|
|
const [input, setInput] = useState('')
|
|
return (
|
|
<Dialog>
|
|
<ForwardMessageComposer onInputChange={setInput} />
|
|
<MessagePreview input={input} />
|
|
</Dialog>
|
|
)
|
|
}
|
|
|
|
function ForwardMessageComposer({ onInputChange }) {
|
|
const [state, setState] = useState(initialState)
|
|
useEffect(() => {
|
|
onInputChange(state.input) // Sync on every change 😬
|
|
}, [state.input])
|
|
}
|
|
```
|
|
|
|
**Incorrect: reading state from ref on submit**
|
|
|
|
```tsx
|
|
function ForwardMessageDialog() {
|
|
const stateRef = useRef(null)
|
|
return (
|
|
<Dialog>
|
|
<ForwardMessageComposer stateRef={stateRef} />
|
|
<ForwardButton onPress={() => submit(stateRef.current)} />
|
|
</Dialog>
|
|
)
|
|
}
|
|
```
|
|
|
|
**Correct: state lifted to provider**
|
|
|
|
```tsx
|
|
function ForwardMessageProvider({ children }: { children: React.ReactNode }) {
|
|
const [state, setState] = useState(initialState)
|
|
const forwardMessage = useForwardMessage()
|
|
const inputRef = useRef(null)
|
|
|
|
return (
|
|
<Composer.Provider
|
|
state={state}
|
|
actions={{ update: setState, submit: forwardMessage }}
|
|
meta={{ inputRef }}
|
|
>
|
|
{children}
|
|
</Composer.Provider>
|
|
)
|
|
}
|
|
|
|
function ForwardMessageDialog() {
|
|
return (
|
|
<ForwardMessageProvider>
|
|
<Dialog>
|
|
<ForwardMessageComposer />
|
|
<MessagePreview /> {/* Custom components can access state and actions */}
|
|
<DialogActions>
|
|
<CancelButton />
|
|
<ForwardButton /> {/* Custom components can access state and actions */}
|
|
</DialogActions>
|
|
</Dialog>
|
|
</ForwardMessageProvider>
|
|
)
|
|
}
|
|
|
|
function ForwardButton() {
|
|
const { actions } = use(Composer.Context)
|
|
return <Button onPress={actions.submit}>Forward</Button>
|
|
}
|
|
```
|
|
|
|
The ForwardButton lives outside the Composer.Frame but still has access to the
|
|
|
|
submit action because it's within the provider. Even though it's a one-off
|
|
|
|
component, it can still access the composer's state and actions from outside the
|
|
|
|
UI itself.
|
|
|
|
**Key insight:** Components that need shared state don't have to be visually
|
|
|
|
nested inside each other—they just need to be within the same provider.
|
|
|
|
---
|
|
|
|
## 3. Implementation Patterns
|
|
|
|
**Impact: MEDIUM**
|
|
|
|
Specific techniques for implementing compound components and
|
|
context providers.
|
|
|
|
### 3.1 Create Explicit Component Variants
|
|
|
|
**Impact: MEDIUM (self-documenting code, no hidden conditionals)**
|
|
|
|
Instead of one component with many boolean props, create explicit variant
|
|
|
|
components. Each variant composes the pieces it needs. The code documents
|
|
|
|
itself.
|
|
|
|
**Incorrect: one component, many modes**
|
|
|
|
```tsx
|
|
// What does this component actually render?
|
|
<Composer
|
|
isThread
|
|
isEditing={false}
|
|
channelId='abc'
|
|
showAttachments
|
|
showFormatting={false}
|
|
/>
|
|
```
|
|
|
|
**Correct: explicit variants**
|
|
|
|
```tsx
|
|
// Immediately clear what this renders
|
|
<ThreadComposer channelId="abc" />
|
|
|
|
// Or
|
|
<EditMessageComposer messageId="xyz" />
|
|
|
|
// Or
|
|
<ForwardMessageComposer messageId="123" />
|
|
```
|
|
|
|
Each implementation is unique, explicit and self-contained. Yet they can each
|
|
|
|
use shared parts.
|
|
|
|
**Implementation:**
|
|
|
|
```tsx
|
|
function ThreadComposer({ channelId }: { channelId: string }) {
|
|
return (
|
|
<ThreadProvider channelId={channelId}>
|
|
<Composer.Frame>
|
|
<Composer.Input />
|
|
<AlsoSendToChannelField channelId={channelId} />
|
|
<Composer.Footer>
|
|
<Composer.Formatting />
|
|
<Composer.Emojis />
|
|
<Composer.Submit />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
</ThreadProvider>
|
|
)
|
|
}
|
|
|
|
function EditMessageComposer({ messageId }: { messageId: string }) {
|
|
return (
|
|
<EditMessageProvider messageId={messageId}>
|
|
<Composer.Frame>
|
|
<Composer.Input />
|
|
<Composer.Footer>
|
|
<Composer.Formatting />
|
|
<Composer.Emojis />
|
|
<Composer.CancelEdit />
|
|
<Composer.SaveEdit />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
</EditMessageProvider>
|
|
)
|
|
}
|
|
|
|
function ForwardMessageComposer({ messageId }: { messageId: string }) {
|
|
return (
|
|
<ForwardMessageProvider messageId={messageId}>
|
|
<Composer.Frame>
|
|
<Composer.Input placeholder="Add a message, if you'd like." />
|
|
<Composer.Footer>
|
|
<Composer.Formatting />
|
|
<Composer.Emojis />
|
|
<Composer.Mentions />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
</ForwardMessageProvider>
|
|
)
|
|
}
|
|
```
|
|
|
|
Each variant is explicit about:
|
|
|
|
- What provider/state it uses
|
|
|
|
- What UI elements it includes
|
|
|
|
- What actions are available
|
|
|
|
No boolean prop combinations to reason about. No impossible states.
|
|
|
|
### 3.2 Prefer Composing Children Over Render Props
|
|
|
|
**Impact: MEDIUM (cleaner composition, better readability)**
|
|
|
|
Use `children` for composition instead of `renderX` props. Children are more
|
|
|
|
readable, compose naturally, and don't require understanding callback
|
|
|
|
signatures.
|
|
|
|
**Incorrect: render props**
|
|
|
|
```tsx
|
|
function Composer({
|
|
renderHeader,
|
|
renderFooter,
|
|
renderActions,
|
|
}: {
|
|
renderHeader?: () => React.ReactNode
|
|
renderFooter?: () => React.ReactNode
|
|
renderActions?: () => React.ReactNode
|
|
}) {
|
|
return (
|
|
<form>
|
|
{renderHeader?.()}
|
|
<Input />
|
|
{renderFooter ? renderFooter() : <DefaultFooter />}
|
|
{renderActions?.()}
|
|
</form>
|
|
)
|
|
}
|
|
|
|
// Usage is awkward and inflexible
|
|
return (
|
|
<Composer
|
|
renderHeader={() => <CustomHeader />}
|
|
renderFooter={() => (
|
|
<>
|
|
<Formatting />
|
|
<Emojis />
|
|
</>
|
|
)}
|
|
renderActions={() => <SubmitButton />}
|
|
/>
|
|
)
|
|
```
|
|
|
|
**Correct: compound components with children**
|
|
|
|
```tsx
|
|
function ComposerFrame({ children }: { children: React.ReactNode }) {
|
|
return <form>{children}</form>
|
|
}
|
|
|
|
function ComposerFooter({ children }: { children: React.ReactNode }) {
|
|
return <footer className='flex'>{children}</footer>
|
|
}
|
|
|
|
// Usage is flexible
|
|
return (
|
|
<Composer.Frame>
|
|
<CustomHeader />
|
|
<Composer.Input />
|
|
<Composer.Footer>
|
|
<Composer.Formatting />
|
|
<Composer.Emojis />
|
|
<SubmitButton />
|
|
</Composer.Footer>
|
|
</Composer.Frame>
|
|
)
|
|
```
|
|
|
|
**When render props are appropriate:**
|
|
|
|
```tsx
|
|
// Render props work well when you need to pass data back
|
|
<List
|
|
data={items}
|
|
renderItem={({ item, index }) => <Item item={item} index={index} />}
|
|
/>
|
|
```
|
|
|
|
Use render props when the parent needs to provide data or state to the child.
|
|
|
|
Use children when composing static structure.
|
|
|
|
---
|
|
|
|
## 4. React 19 APIs
|
|
|
|
**Impact: MEDIUM**
|
|
|
|
React 19+ only. Don't use `forwardRef`; use `use()` instead of `useContext()`.
|
|
|
|
### 4.1 React 19 API Changes
|
|
|
|
**Impact: MEDIUM (cleaner component definitions and context usage)**
|
|
|
|
> **⚠️ React 19+ only.** Skip this if you're on React 18 or earlier.
|
|
|
|
In React 19, `ref` is now a regular prop (no `forwardRef` wrapper needed), and `use()` replaces `useContext()`.
|
|
|
|
**Incorrect: forwardRef in React 19**
|
|
|
|
```tsx
|
|
const ComposerInput = forwardRef<TextInput, Props>((props, ref) => {
|
|
return <TextInput ref={ref} {...props} />
|
|
})
|
|
```
|
|
|
|
**Correct: ref as a regular prop**
|
|
|
|
```tsx
|
|
function ComposerInput({ ref, ...props }: Props & { ref?: React.Ref<TextInput> }) {
|
|
return <TextInput ref={ref} {...props} />
|
|
}
|
|
```
|
|
|
|
**Incorrect: useContext in React 19**
|
|
|
|
```tsx
|
|
const value = useContext(MyContext)
|
|
```
|
|
|
|
**Correct: use instead of useContext**
|
|
|
|
```tsx
|
|
const value = use(MyContext)
|
|
```
|
|
|
|
`use()` can also be called conditionally, unlike `useContext()`.
|
|
|
|
---
|
|
|
|
## References
|
|
|
|
1. [https://react.dev](https://react.dev)
|
|
2. [https://react.dev/learn/passing-data-deeply-with-context](https://react.dev/learn/passing-data-deeply-with-context)
|
|
3. [https://react.dev/reference/react/use](https://react.dev/reference/react/use)
|