fix(deps): OSV-gaten grön — 24 sårbarheter stängda, xlsx undantagen med bevis
OSV Scanner (steg 6 i security-gaten) fällde jobbet efter att Trivy blivit grönt: 43 advisory-poster över 10 paket. Samma skanning mot origin/main ger 9 av 10 paket — posterna publicerades mot versioner vi redan kör, så main hade blivit röd vid nästa nattliga skanning oavsett denna PR. Bumpat (alla verifierade med osv-scanner och hela unit-sviten): nodemailer 10.0.6/10.0.10 -> 10.1.4 (direkt + override för mailparser) zod 4.4.3 -> 4.6.7 (^4.6.6) vite 8.1.3 -> 8.3.8 (override ^8.1.6, dev via vitest) vitest 4.1.11 -> 4.1.12 (^4.1.12, tar @vitest/mocker 4.1.12) @babel/core 7.28.6 -> 7.29.13 (override, dev via eslint-plugin-react-hooks) fast-xml-parser 5.7.2 -> 5.12.1 (override, via @aws-sdk/xml-builder) minimatch 9.0.9 -> 11.0.8 (override, dev via typescript-eslint) postcss-selector-parser 6.0.10 -> 6.1.6 (override, via @tailwindcss/typography) python-multipart -> >=0.0.31 (explicit floor i mcp-builder-skillens requirements.txt; OSV kan inte lösa en otransitiv, opinnad requirement) xlsx 0.20.3 undantas i osv-scanner.toml med effectiveUntil 2027-05-15: GHSA-4r6h-8v6p-xvw6 och GHSA-5pgg-2g8v-p4x9 har introduced:0 och INGET fixed-event (kontrollerat mot api.osv.dev), eftersom SheetJS slutade publicera till npm efter 0.18.5. Vi pinnar 0.20.3 från cdn.sheetjs.com, som redan innehåller båda fixarna (0.19.3 / 0.20.2). Skanningen rapporterar alltså en versionsupplösningsartefakt. Filen varnar uttryckligen om att lib/import/* parsar användaruppladdade arbetsböcker, så undantaget får inte läsas som tillstånd att acceptera ofixade parser-CVE:er. Verifiering: osv-scanner --config=osv-scanner.toml -> "No issues found" rc=0; 1687 filer / 22 400 tester gröna; check:types 533/533; check:lint 0 fel; check:guards passed; Trivy 0 fynd. Revert: git revert <sha>. Enda beteendepåverkande posten är osv-scanner.toml (utan den blir gaten röd igen på xlsx); minimatch 9 -> 11 används bara av lint-kedjan och verifieras av check:lint + sviten.
This commit is contained in:
@@ -1,2 +1,6 @@
|
||||
anthropic>=0.39.0
|
||||
mcp>=1.1.0
|
||||
# Transitive via mcp (multipart form parsing). Pinned as a floor because the
|
||||
# advisory scanner cannot resolve an unpinned requirement and reports the
|
||||
# oldest version it can match; 0.0.31 carries the PYSEC-2026 multipart fixes.
|
||||
python-multipart>=0.0.31
|
||||
|
||||
@@ -0,0 +1,84 @@
|
||||
# Accounted: OSV-gaten grön — 24 sårbarheter stängda, xlsx undantagen med bevis (2026-11-15)
|
||||
|
||||
`security / scan` var röd på PR #44 även efter att Trivy-steget blivit grönt.
|
||||
Steg 6, **OSV Scanner**, fällde jobbet.
|
||||
|
||||
## Fynd
|
||||
|
||||
`ghcr.io/google/osv-scanner:v2.7.1` mot `package-lock.json` +
|
||||
`.claude/skills/mcp-builder/scripts/requirements.txt`: **43 advisory-poster över
|
||||
10 paket**. Viktigt för rotorsaken: samma skanning mot `origin/main`s låsfil ger
|
||||
**9 av 10 paket** — det här var inte något PR:en införde. Nya GHSA/PYSEC-poster
|
||||
publicerades mot versioner vi redan kör, så `main` hade blivit röd vid nästa
|
||||
nattliga skanning (02:17) oavsett.
|
||||
|
||||
| Paket | Före | Efter | Väg |
|
||||
|---|---|---|---|
|
||||
| nodemailer | 10.0.6 (direkt) + 10.0.10 (mailparser) | **10.1.4** | direkt dependency + override |
|
||||
| zod | 4.4.3 | **4.6.7** | `^4.6.6` |
|
||||
| vite | 8.1.3 | **8.3.8** | override `^8.1.6` (dev, via vitest) |
|
||||
| vitest / @vitest/mocker | 4.1.11 / 4.1.11 | **4.1.12 / 4.1.12** | `^4.1.12` |
|
||||
| @babel/core | 7.28.6 | **7.29.13** | override `^7.29.6` (dev, via eslint-plugin-react-hooks) |
|
||||
| fast-xml-parser | 5.7.2 | **5.12.1** | override `^5.12.0` (via @aws-sdk/xml-builder) |
|
||||
| minimatch | 9.0.9 | **11.0.8** | override `^11.0.1` (dev, via typescript-eslint) |
|
||||
| postcss-selector-parser | 6.0.10 | **6.1.6** | override `^6.1.5` (via @tailwindcss/typography) |
|
||||
| python-multipart | olöst (otransitiv, (ospecificerad) | **>=0.0.31** | explicit floor i skillens requirements.txt |
|
||||
| xlsx | 0.20.3 | 0.20.3 | **undantagen** — se nedan |
|
||||
|
||||
## xlsx: undantaget, inte bortförklarat
|
||||
|
||||
Båda posterna (`GHSA-4r6h-8v6p-xvw6` = CVE-2023-30533 prototype pollution,
|
||||
`GHSA-5pgg-2g8v-p4x9` = CVE-2024-22363 ReDoS) har `introduced: 0` och **inget
|
||||
`fixed`-event** — kontrollerat direkt mot `api.osv.dev` 2026-11-15. Det betyder
|
||||
inte "ofixat", det betyder "ingen npm-version bär fixen": SheetJS slutade
|
||||
publicera till npm efter 0.18.5 och släpper 0.19+ från `cdn.sheetjs.com`.
|
||||
|
||||
Repot konsumerar `xlsx` som URL-dependency
|
||||
(`https://cdn.sheetjs.com/xlsx-0.20.3/xlsx-0.20.3.tgz`), och 0.20.3 innehåller
|
||||
båda fixarna (0.19.3 respektive 0.20.2). Skanningen rapporterar alltså en
|
||||
versionsupplösningsartefakt, inte en levande defekt.
|
||||
|
||||
Hanteringen är inte en tyst tystnad: `osv-scanner.toml` med två `IgnoredVulns`,
|
||||
`effectiveUntil = 2027-05-15` och full motivering, plus en uttrycklig varning i
|
||||
filen om att `lib/import/*` parsar användaruppladdade arbetsböcker — undantaget
|
||||
får aldrig läsas som tillstånd att acceptera ofixade parser-CVE:er. När SheetJS
|
||||
publicerar 0.21+, eller vi migrerar till en underhållen parser, ska filen bort.
|
||||
|
||||
## Ändring
|
||||
|
||||
- `package.json`: nodemailer `10.1.4`; zod `^4.6.6`; vitest `^4.1.12`; overrides
|
||||
utökade med `nodemailer` (mailparser-subträdet), `@babel/core`,
|
||||
`fast-xml-parser`, `minimatch`, `postcss-selector-parser`, `vite`.
|
||||
- `package-lock.json`: omgenererad med `npm install --no-audit --no-fund`.
|
||||
- `.claude/skills/mcp-builder/scripts/requirements.txt`: explicit
|
||||
`python-multipart>=0.0.31` med kommentar om varför en floor behövs (OSV kan
|
||||
inte lösa en otransitiv, opinnad requirement och rapporterar den äldsta
|
||||
version den kan matcha).
|
||||
- `osv-scanner.toml`: ny, se ovan.
|
||||
- `scripts/checks/no-new-antipatterns.mjs`: PINNED_DEPS nodemailer → `10.1.4`
|
||||
med motiveringen uppdaterad (9.x → 10.1.4 i två steg samma dag).
|
||||
|
||||
Notera att arbetsflödet redan skickar `--config` när `osv-scanner.toml` finns
|
||||
(`.gitea/workflows/security.yml`), så ingen CI-ändring behövdes.
|
||||
|
||||
## Verifiering
|
||||
|
||||
- `osv-scanner scan source --recursive --config=osv-scanner.toml .` →
|
||||
**No issues found**, rc=0 (2 filtrerade, båda xlsx, med utskriven motivering).
|
||||
- `npx vitest run --project unit` → **1687 filer / 22 400 tester passed**,
|
||||
3 filer/5 tester skipped, 163 s (efter alla bumps: zod 4.6, vite 8.3,
|
||||
vitest 4.1.12, minimatch 11, @babel 7.29).
|
||||
- `npm run check:types` → OK (533 fel, baseline 533). `check:lint` → 0 fel.
|
||||
`check:guards` → passed (pinned-dep 0).
|
||||
- Trivy fs HIGH/CRITICAL: 0 vulnerabilitets-, secret- och misconfig-fynd.
|
||||
|
||||
## Revert
|
||||
|
||||
```
|
||||
git revert <commit>
|
||||
```
|
||||
|
||||
Enda beteendepåverkande posten är `osv-scanner.toml` (om den tas bort blir
|
||||
gaten röd igen på xlsx). Paketbumparna är patch/minor utom `minimatch` 9 → 11,
|
||||
som bara används av lint-verktygskedjan och verifieras av `check:lint` +
|
||||
testsviten.
|
||||
@@ -0,0 +1,34 @@
|
||||
# osv-scanner configuration. Read by .gitea/workflows/security.yml, which passes
|
||||
# --config when this file exists.
|
||||
#
|
||||
# The two entries below are the SheetJS advisories. They are ignored because the
|
||||
# fix is not obtainable from npm at any version: SheetJS stopped publishing to
|
||||
# the npm registry after 0.18.5 and ships 0.19+ from cdn.sheetjs.com, so both
|
||||
# GHSA records have `introduced: 0` and no `fixed` event (verified against
|
||||
# api.osv.dev 2026-11-15). This repo consumes `xlsx` as a URL dependency,
|
||||
# https://cdn.sheetjs.com/xlsx-0.20.3/xlsx-0.20.3.tgz, and 0.20.3 already
|
||||
# contains both fixes:
|
||||
#
|
||||
# GHSA-4r6h-8v6p-xvw6 (CVE-2023-30533, prototype pollution) — fixed upstream in 0.19.3
|
||||
# GHSA-5pgg-2g8v-p4x9 (CVE-2024-22363, ReDoS) — fixed upstream in 0.20.2
|
||||
#
|
||||
# So the scanner is reporting a version-resolution artefact, not a live defect.
|
||||
# The entries still expire: if we ever pin an older tarball, or migrate to a
|
||||
# maintained parser, this file must be revisited rather than inherited. Owner:
|
||||
# admin/accounted maintainers. Expiry is deliberate; the nightly scan re-reports
|
||||
# both advisories the day it passes.
|
||||
#
|
||||
# Deliberately NOT in scope here: the prototype-pollution and ReDoS classes are
|
||||
# about parsing untrusted workbooks, and lib/import/* does exactly that. The
|
||||
# mitigations are upstream (both fixed in our pinned version) — do not treat
|
||||
# this file as permission to accept unfixed parser CVEs.
|
||||
|
||||
[[IgnoredVulns]]
|
||||
id = "GHSA-4r6h-8v6p-xvw6"
|
||||
effectiveUntil = 2027-05-15
|
||||
reason = "CVE-2023-30533 fixed upstream in SheetJS 0.19.3; we pin 0.20.3 from cdn.sheetjs.com. No npm release carries the fix, so no version can satisfy the advisory."
|
||||
|
||||
[[IgnoredVulns]]
|
||||
id = "GHSA-5pgg-2g8v-p4x9"
|
||||
effectiveUntil = 2027-05-15
|
||||
reason = "CVE-2024-22363 fixed upstream in SheetJS 0.20.2; we pin 0.20.3 from cdn.sheetjs.com. No npm release carries the fix, so no version can satisfy the advisory."
|
||||
Generated
+487
-395
File diff suppressed because it is too large
Load Diff
+14
-8
@@ -56,17 +56,17 @@
|
||||
"class-variance-authority": "^0.7.1",
|
||||
"clsx": "^2.1.1",
|
||||
"date-fns": "^4.4.0",
|
||||
"motion": "^12.42.2",
|
||||
"fuse.js": "^7.4.2",
|
||||
"ics": "^3.12.0",
|
||||
"js-yaml": "4.3.2",
|
||||
"jszip": "^3.10.1",
|
||||
"lucide-react": "^1.24.0",
|
||||
"mailparser": "^3.9.14",
|
||||
"motion": "^12.42.2",
|
||||
"next": "^16.4.1",
|
||||
"next-intl": "^4.13.2",
|
||||
"next-themes": "^0.4.6",
|
||||
"nodemailer": "10.0.6",
|
||||
"nodemailer": "10.1.4",
|
||||
"pdf-lib": "^1.17.1",
|
||||
"posthog-js": "^1.407.3",
|
||||
"posthog-node": "^5.46.1",
|
||||
@@ -85,7 +85,7 @@
|
||||
"tailwind-merge": "^3.6.0",
|
||||
"web-push": "^3.6.7",
|
||||
"xlsx": "https://cdn.sheetjs.com/xlsx-0.20.3/xlsx-0.20.3.tgz",
|
||||
"zod": "^4.4.3"
|
||||
"zod": "^4.6.6"
|
||||
},
|
||||
"devDependencies": {
|
||||
"@tailwindcss/postcss": "^4",
|
||||
@@ -105,14 +105,20 @@
|
||||
"tailwindcss": "^4",
|
||||
"tsx": "4.20.5",
|
||||
"typescript": "^5",
|
||||
"vitest": "^4.1.9"
|
||||
"vitest": "^4.1.12"
|
||||
},
|
||||
"overrides": {
|
||||
"html-to-text": "10.0.1",
|
||||
"sharp": "^0.35.3",
|
||||
"postcss": "^8.5.18",
|
||||
"@babel/core": "^7.29.6",
|
||||
"dompurify": "^3.4.17",
|
||||
"fast-xml-parser": "^5.12.0",
|
||||
"html-to-text": "10.0.1",
|
||||
"minimatch": "^11.0.1",
|
||||
"nodemailer": "10.1.4",
|
||||
"postcss": "^8.5.18",
|
||||
"postcss-selector-parser": "^6.1.5",
|
||||
"sharp": "^0.35.3",
|
||||
"source-map-js": "^1.2.2",
|
||||
"undici": "^6.29.1"
|
||||
"undici": "^6.29.1",
|
||||
"vite": "^8.1.6"
|
||||
}
|
||||
}
|
||||
|
||||
@@ -758,15 +758,18 @@ const PINNED_DEPS = [
|
||||
},
|
||||
{
|
||||
name: 'nodemailer',
|
||||
version: '10.0.6',
|
||||
version: '10.1.4',
|
||||
reason:
|
||||
'SMTP mailer for self-hosts (extensions/general/email/lib/smtp-service.ts). Zero-dependency MIT-0 ' +
|
||||
'package on the outbound-mail path; bumps are deliberate, reviewed PRs (audit surface), never silent. ' +
|
||||
'Bumped 9.0.5 -> 9.1.1 (2026-09-30) for HIGH advisories GHSA-2x7j-588g-ccc2 / GHSA-8m3c-c648-2xjj. ' +
|
||||
'Bumped 9.1.1 -> 10.0.6 (2026-11-15): the remaining 9.x advisories (CVE-2026-90776 header DoS, ' +
|
||||
'Bumped 9.1.1 -> 10.1.4 (2026-11-15): the remaining 9.x advisories (CVE-2026-90776 header DoS, ' +
|
||||
'GHSA-v53p-9fqp-m79j addressparser backtracking) are only fixed in 10.x, and Trivy failed the ' +
|
||||
'security gate on them. The 10.0 API used here (createTransport + sendMail) is unchanged; the ' +
|
||||
'smtp-service suite covers the transport options that matter (requireTLS, AUTH, envelope).',
|
||||
'smtp-service suite covers the transport options that matter (requireTLS, AUTH, envelope). ' +
|
||||
'10.0.6 -> 10.1.4 the same day: OSV flagged 10.0.6 and the mailparser subtree pin 10.0.10 ' +
|
||||
'(GHSA-4ffr-jq9g-5ffx, GHSA-85x2-q946-cp5h, GHSA-8c8m-p3m8-cjg8, GHSA-g73g-hqqh-jr95, ' +
|
||||
'GHSA-m943-m63m-w62w); 10.1.4 is the first release with all five.',
|
||||
},
|
||||
]
|
||||
|
||||
|
||||
Reference in New Issue
Block a user