Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
44 lines
1.4 KiB
TypeScript
44 lines
1.4 KiB
TypeScript
import { describe, it, expect, vi, beforeEach } from 'vitest'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
|
|
vi.mock('../categories', () => ({
|
|
countUnbookedTransactions: vi.fn().mockResolvedValue(4),
|
|
countInboxDocuments: vi.fn().mockResolvedValue(6),
|
|
countSuggestedMatches: vi.fn().mockResolvedValue(2),
|
|
countSupplierInvoicesAwaitingApproval: vi.fn().mockResolvedValue(1),
|
|
countVerifikatMissingDocument: vi.fn().mockResolvedValue(3),
|
|
countOverdueInvoices: vi.fn().mockResolvedValue(5),
|
|
countDeadlinesNeedingAction: vi.fn().mockResolvedValue(1),
|
|
countPendingOperations: vi.fn().mockResolvedValue(2),
|
|
}))
|
|
|
|
import { getWorklistCounts } from '../aggregate'
|
|
|
|
const supabase = {} as SupabaseClient
|
|
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
})
|
|
|
|
describe('getWorklistCounts', () => {
|
|
it('aggregates every category', async () => {
|
|
const { counts } = await getWorklistCounts(supabase, 'company-1')
|
|
expect(counts).toEqual({
|
|
book_transaction: 4,
|
|
inbox_document: 6,
|
|
suggested_match: 2,
|
|
supplier_invoice_approval: 1,
|
|
verifikat_missing_document: 3,
|
|
overdue_invoice: 5,
|
|
deadline_action: 1,
|
|
pending_operations: 2,
|
|
})
|
|
})
|
|
|
|
it('excludes suggested_match from the total (subset of book_transaction)', async () => {
|
|
const { total } = await getWorklistCounts(supabase, 'company-1')
|
|
// 4 + 6 + 1 + 3 + 5 + 1 + 2, without the 2 suggested matches.
|
|
expect(total).toBe(22)
|
|
})
|
|
})
|