Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
96 lines
2.6 KiB
TypeScript
96 lines
2.6 KiB
TypeScript
import type { KPIPreferences } from '@/types'
|
|
import { VAT_INPUT_ACCOUNTS, VAT_OUTPUT_ACCOUNTS } from '@/lib/reports/vat-declaration'
|
|
|
|
export interface KPIDefinition {
|
|
id: string
|
|
// Translation key suffix; used as `kpi.def_<id>_label` / `_description` / `_formula` / `_accounts`.
|
|
defaultAccounts: string[]
|
|
customizableAccounts: boolean
|
|
defaultVisible: boolean
|
|
format: 'currency' | 'percentage' | 'days'
|
|
colorLogic: 'positive-good' | 'negative-good' | 'neutral'
|
|
}
|
|
|
|
export const KPI_DEFINITIONS: KPIDefinition[] = [
|
|
{
|
|
id: 'netResult',
|
|
defaultAccounts: [],
|
|
customizableAccounts: false,
|
|
defaultVisible: true,
|
|
format: 'currency',
|
|
colorLogic: 'positive-good',
|
|
},
|
|
{
|
|
id: 'cashPosition',
|
|
defaultAccounts: ['1910', '1920', '1930', '1940', '1950', '1960', '1970', '1980'],
|
|
customizableAccounts: true,
|
|
defaultVisible: true,
|
|
format: 'currency',
|
|
colorLogic: 'positive-good',
|
|
},
|
|
{
|
|
id: 'outstandingReceivables',
|
|
defaultAccounts: ['1510'],
|
|
customizableAccounts: false,
|
|
defaultVisible: true,
|
|
format: 'currency',
|
|
colorLogic: 'neutral',
|
|
},
|
|
{
|
|
id: 'vatLiability',
|
|
// Same 26xx accounts as the momsdeklaration (ruta 49): see vat-declaration.ts
|
|
defaultAccounts: [...VAT_OUTPUT_ACCOUNTS, ...VAT_INPUT_ACCOUNTS],
|
|
customizableAccounts: true,
|
|
defaultVisible: true,
|
|
format: 'currency',
|
|
colorLogic: 'negative-good',
|
|
},
|
|
{
|
|
id: 'grossMargin',
|
|
defaultAccounts: [],
|
|
customizableAccounts: false,
|
|
defaultVisible: false,
|
|
format: 'percentage',
|
|
colorLogic: 'positive-good',
|
|
},
|
|
{
|
|
id: 'expenseRatio',
|
|
defaultAccounts: [],
|
|
customizableAccounts: false,
|
|
defaultVisible: false,
|
|
format: 'percentage',
|
|
colorLogic: 'negative-good',
|
|
},
|
|
{
|
|
id: 'avgPaymentDays',
|
|
defaultAccounts: [],
|
|
customizableAccounts: false,
|
|
defaultVisible: false,
|
|
format: 'days',
|
|
colorLogic: 'negative-good',
|
|
},
|
|
]
|
|
|
|
export const ALL_KPI_IDS = KPI_DEFINITIONS.map((d) => d.id)
|
|
|
|
export function getKPIDefinition(id: string): KPIDefinition | undefined {
|
|
return KPI_DEFINITIONS.find((d) => d.id === id)
|
|
}
|
|
|
|
export function getDefaultPreferences(): KPIPreferences {
|
|
return {
|
|
visibleKpis: KPI_DEFINITIONS.filter((d) => d.defaultVisible).map((d) => d.id),
|
|
kpiOrder: ALL_KPI_IDS,
|
|
accountOverrides: {},
|
|
}
|
|
}
|
|
|
|
export function mergeWithDefaults(prefs: Partial<KPIPreferences>): KPIPreferences {
|
|
const defaults = getDefaultPreferences()
|
|
return {
|
|
visibleKpis: prefs.visibleKpis ?? defaults.visibleKpis,
|
|
kpiOrder: prefs.kpiOrder ?? defaults.kpiOrder,
|
|
accountOverrides: prefs.accountOverrides ?? defaults.accountOverrides,
|
|
}
|
|
}
|