Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
53 lines
1.8 KiB
TypeScript
53 lines
1.8 KiB
TypeScript
/**
|
|
* Parse and validate optional `from_date` / `to_date` query params for the
|
|
* date-range-aware financial reports (resultat- and balansrapport).
|
|
*
|
|
* Returns the bounds clamped against the fiscal period. Both params are
|
|
* optional: when omitted, the report falls back to the period as a whole.
|
|
* Returns a `{ error }` shape on invalid input so callers can map it to a
|
|
* 400 response without each route duplicating the same checks.
|
|
*/
|
|
export type DateRange = { fromDate?: string; toDate?: string }
|
|
|
|
export type DateRangeResult =
|
|
| { ok: true; range: DateRange }
|
|
| { ok: false; error: string }
|
|
|
|
const ISO_DATE = /^\d{4}-\d{2}-\d{2}$/
|
|
|
|
export function parseReportDateRange(
|
|
searchParams: URLSearchParams,
|
|
period: { period_start: string; period_end: string }
|
|
): DateRangeResult {
|
|
const rawFrom = searchParams.get('from_date')
|
|
const rawTo = searchParams.get('to_date')
|
|
|
|
if (rawFrom && !ISO_DATE.test(rawFrom)) {
|
|
return { ok: false, error: 'from_date måste vara på formen YYYY-MM-DD.' }
|
|
}
|
|
if (rawTo && !ISO_DATE.test(rawTo)) {
|
|
return { ok: false, error: 'to_date måste vara på formen YYYY-MM-DD.' }
|
|
}
|
|
|
|
const fromDate = rawFrom ?? undefined
|
|
const toDate = rawTo ?? undefined
|
|
|
|
if (fromDate && (fromDate < period.period_start || fromDate > period.period_end)) {
|
|
return {
|
|
ok: false,
|
|
error: `from_date måste ligga inom räkenskapsåret (${period.period_start}: ${period.period_end}).`,
|
|
}
|
|
}
|
|
if (toDate && (toDate < period.period_start || toDate > period.period_end)) {
|
|
return {
|
|
ok: false,
|
|
error: `to_date måste ligga inom räkenskapsåret (${period.period_start}: ${period.period_end}).`,
|
|
}
|
|
}
|
|
if (fromDate && toDate && fromDate > toDate) {
|
|
return { ok: false, error: 'from_date får inte vara efter to_date.' }
|
|
}
|
|
|
|
return { ok: true, range: { fromDate, toDate } }
|
|
}
|