Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
76 lines
2.3 KiB
TypeScript
76 lines
2.3 KiB
TypeScript
import type { CoreEvent, CoreEventType, EventHandler } from './types'
|
|
import { createLogger } from '@/lib/logger'
|
|
|
|
// Internal handler type: loose enough for the Map, but type-safe at the public API
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
type AnyHandler = (payload: any) => Promise<void> | void
|
|
|
|
const log = createLogger('event-bus')
|
|
|
|
/**
|
|
* In-process event bus.
|
|
*
|
|
* - Handlers run concurrently via Promise.allSettled (failing handler never crashes emitter)
|
|
* - Module-level singleton (persists across requests in same process)
|
|
* - One-way: core services emit, extensions subscribe
|
|
* - Rejected handlers are logged with structured fields so they're greppable
|
|
* in Vercel logs by event type, handler name, and the originating request id
|
|
* (when carried in the payload).
|
|
*/
|
|
class EventBus {
|
|
private handlers = new Map<string, Set<AnyHandler>>()
|
|
|
|
on<T extends CoreEventType>(
|
|
eventType: T,
|
|
handler: EventHandler<T>
|
|
): () => void {
|
|
if (!this.handlers.has(eventType)) {
|
|
this.handlers.set(eventType, new Set())
|
|
}
|
|
|
|
const handlerSet = this.handlers.get(eventType)!
|
|
handlerSet.add(handler as AnyHandler)
|
|
|
|
return () => {
|
|
handlerSet.delete(handler as AnyHandler)
|
|
if (handlerSet.size === 0) {
|
|
this.handlers.delete(eventType)
|
|
}
|
|
}
|
|
}
|
|
|
|
async emit(event: CoreEvent): Promise<void> {
|
|
const handlerSet = this.handlers.get(event.type)
|
|
if (!handlerSet || handlerSet.size === 0) return
|
|
|
|
const handlers = [...handlerSet]
|
|
const results = await Promise.allSettled(
|
|
handlers.map((handler) => handler(event.payload))
|
|
)
|
|
|
|
for (let i = 0; i < results.length; i++) {
|
|
const result = results[i]
|
|
if (result.status === 'rejected') {
|
|
const handler = handlers[i]
|
|
const handlerName = handler.name || 'anonymous'
|
|
const payload = event.payload as Record<string, unknown>
|
|
|
|
log.error('handler failed', result.reason, {
|
|
eventType: event.type,
|
|
handler: handlerName,
|
|
companyId: typeof payload.companyId === 'string' ? payload.companyId : undefined,
|
|
userId: typeof payload.userId === 'string' ? payload.userId : undefined,
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
/** Remove all handlers (useful for testing). */
|
|
clear(): void {
|
|
this.handlers.clear()
|
|
}
|
|
}
|
|
|
|
/** Module-level singleton */
|
|
export const eventBus = new EventBus()
|