Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
58 lines
2.2 KiB
TypeScript
58 lines
2.2 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { updateDraftEntry } from '../engine'
|
|
import {
|
|
CannotEditNonDraftError,
|
|
JournalEntryNotFoundError,
|
|
JournalEntryNotBalancedError,
|
|
} from '../errors'
|
|
import { createQueuedMockSupabase } from '@/tests/helpers'
|
|
import type { CreateJournalEntryInput } from '@/types'
|
|
|
|
const balancedInput: CreateJournalEntryInput = {
|
|
fiscal_period_id: 'period-1',
|
|
entry_date: '2026-06-01',
|
|
description: 'Test draft',
|
|
source_type: 'manual',
|
|
voucher_series: 'A',
|
|
lines: [
|
|
{ account_number: '1930', debit_amount: 100, credit_amount: 0 },
|
|
{ account_number: '3001', debit_amount: 0, credit_amount: 100 },
|
|
],
|
|
}
|
|
|
|
describe('updateDraftEntry', () => {
|
|
it('throws JournalEntryNotFoundError when the entry does not exist', async () => {
|
|
const q = createQueuedMockSupabase()
|
|
q.enqueue({ data: null, error: { message: 'not found' } })
|
|
await expect(
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
updateDraftEntry(q.supabase as any, 'company-1', 'user-1', 'missing', balancedInput)
|
|
).rejects.toBeInstanceOf(JournalEntryNotFoundError)
|
|
})
|
|
|
|
it('refuses to edit a posted entry: only drafts are editable', async () => {
|
|
const q = createQueuedMockSupabase()
|
|
q.enqueue({ data: { id: 'e1', status: 'posted', voucher_series: 'A' }, error: null })
|
|
await expect(
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
updateDraftEntry(q.supabase as any, 'company-1', 'user-1', 'e1', balancedInput)
|
|
).rejects.toBeInstanceOf(CannotEditNonDraftError)
|
|
})
|
|
|
|
it('rejects an unbalanced draft before mutating anything', async () => {
|
|
const q = createQueuedMockSupabase()
|
|
q.enqueue({ data: { id: 'e1', status: 'draft', voucher_series: 'A' }, error: null })
|
|
const unbalanced: CreateJournalEntryInput = {
|
|
...balancedInput,
|
|
lines: [
|
|
{ account_number: '1930', debit_amount: 100, credit_amount: 0 },
|
|
{ account_number: '3001', debit_amount: 0, credit_amount: 50 },
|
|
],
|
|
}
|
|
await expect(
|
|
// eslint-disable-next-line @typescript-eslint/no-explicit-any
|
|
updateDraftEntry(q.supabase as any, 'company-1', 'user-1', 'e1', unbalanced)
|
|
).rejects.toBeInstanceOf(JournalEntryNotBalancedError)
|
|
})
|
|
})
|