Files
accounted/lib/reports/ar-ledger.ts
T
Jakob Wennberg fce6faff2c fix(api): stabilize report pagination + declare real { data, meta } envelope on v1 single/write endpoints (#811)
* fix(reports): stabilize fetchAllRows paging to stop doubled/dropped balances (#790, #791)

PostgREST `.range()` paging is only correct when the underlying query has a
stable TOTAL order. Several aggregating report queries (general ledger, trial
balance, grundbok, supplier/AR ledgers, etc.) paginated without `.order()`, so
on datasets larger than one 1000-row page Postgres could return rows in a
different order between requests — silently DUPLICATING or SKIPPING rows on a
page boundary and doubling or dropping financial totals.

- fetch-all.ts: document the ordering invariant and add an optional
  `dedupeBy` defense-in-depth that drops cross-page duplicates and warns when
  it fires (surfaces a missing `.order()` in logs instead of corrupting money).
- Add a stable `.order()` (line PK or account_number) to every paginated query
  in lib/reports/ and the account-balances route; pass `dedupeBy` on the
  money-aggregating line queries.
- Add fetch-all unit tests and update report test fixtures to carry row ids.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(api): declare the real { data, meta } envelope on v1 single/write/204 endpoints (#794)

The OpenAPI generator derives each endpoint's documented body purely from its
registered `response.success` Zod schema, and that schema is never validated at
runtime — so a route could advertise a shape its handler never sends. #802
fixed this for list endpoints; the same drift was latent on single-resource and
write endpoints, which declared the bare resource schema instead of the
`{ data, meta }` envelope the handlers actually return.

- registry.ts: extend `ResponseMetaSchema` with the optional `audit` block and
  `partial_expansions` list that writes/expansions emit; add the `NoBodyResponse`
  sentinel so 204 DELETE handlers document a bare 204 instead of a phantom 200.
- Wrap every single/write endpoint's `response.success` in `dataEnvelope(...)`
  (or `NoBodyResponse` for 204s) across the v1 routes.
- Add a response-envelope contract test that fails CI if any JSON endpoint
  forgets to wrap its schema, with binary downloads and 204s as the only
  exemptions.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(reports): extend paging dedupeBy to rc-basis-gaps and opening-balances

Address PR review: these two money-aggregating line queries already had the
stable `.order('id')` (so paging was correct) but didn't carry `id` in the
select, so they couldn't use the `dedupeBy` defense-in-depth that general-ledger
and trial-balance got. Select `id` and pass `dedupeBy: r => r.id` so the whole
report layer applies the ordering invariant consistently.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-28 13:42:50 +02:00

200 lines
6.6 KiB
TypeScript

import type { SupabaseClient } from '@supabase/supabase-js'
import { fetchAllRows } from '@/lib/supabase/fetch-all'
import { resolveSekAmount } from '@/lib/bookkeeping/currency-utils'
export interface ARInvoiceDetail {
invoice_id: string
invoice_number: string
invoice_date: string
due_date: string
total: number
paid_amount: number
/** Outstanding in the invoice's original currency. Use for display only. */
outstanding: number
/**
* Outstanding converted to SEK using the invoice-date exchange_rate. `null`
* when conversion failed (FX invoice with no rate). Callers summing across
* customers must use this field, never `outstanding`, to avoid mixing
* currencies.
*/
outstanding_sek: number | null
days_overdue: number
currency: string
}
export interface ARLedgerEntry {
customer_id: string
customer_name: string
invoices: ARInvoiceDetail[]
current: number
days_1_30: number
days_31_60: number
days_61_90: number
days_90_plus: number
total_outstanding: number
}
export interface ARLedgerReport {
entries: ARLedgerEntry[]
total_outstanding: number
total_current: number
total_overdue: number
unpaid_count: number
/**
* Number of foreign-currency invoices excluded from the SEK totals because
* they had no exchange_rate. Their detail rows are still listed (with
* outstanding_sek = null) so the user can see them.
*/
unconverted_fx_count: number
}
/**
* Generate AR ledger (kundreskontra) with aging analysis.
* BFL 5 kap. 4 § — sidoordnad bokföring: outstanding customer invoices with aging.
*/
export async function generateARLedger(
supabase: SupabaseClient,
companyId: string,
asOfDate?: string
): Promise<ARLedgerReport> {
const refDate = asOfDate ? new Date(asOfDate) : new Date()
// Fetch all unpaid/sent/overdue invoices with customer info
// eslint-disable-next-line @typescript-eslint/no-explicit-any
let invoices: any[]
try {
invoices = await fetchAllRows(({ from, to }) =>
supabase
.from('invoices')
.select('*, customer:customers(id, name)')
.eq('company_id', companyId)
.in('status', ['sent', 'overdue', 'credited'])
// Stable total order for correct paging (see fetch-all.ts).
.order('id', { ascending: true })
.range(from, to)
)
} catch {
return {
entries: [],
total_outstanding: 0,
total_current: 0,
total_overdue: 0,
unpaid_count: 0,
unconverted_fx_count: 0,
}
}
// Group by customer and calculate aging
const byCustomer = new Map<string, ARLedgerEntry>()
let unconvertedFxCount = 0
for (const inv of invoices) {
const customerId = inv.customer_id
const customerName = inv.customer?.name || 'Okänd kund'
if (!byCustomer.has(customerId)) {
byCustomer.set(customerId, {
customer_id: customerId,
customer_name: customerName,
invoices: [],
current: 0,
days_1_30: 0,
days_31_60: 0,
days_61_90: 0,
days_90_plus: 0,
total_outstanding: 0,
})
}
const entry = byCustomer.get(customerId)!
const dueDate = new Date(inv.due_date)
const daysOverdue = Math.floor((refDate.getTime() - dueDate.getTime()) / (1000 * 60 * 60 * 24))
const paidAmount = Number(inv.paid_amount) || 0
const total = Number(inv.total) || 0
const outstanding = Math.round((total - paidAmount) * 100) / 100
// Aging buckets and totals must be in SEK so they reconcile with account 1510.
// Foreign-currency invoices without an exchange_rate cannot be converted —
// adding the raw foreign amount to a SEK total is unsound, so the row is
// counted but excluded from the buckets. The detail row is still pushed so
// the user can see the invoice in the expandable list, with outstanding_sek
// = null to flag the missing conversion.
const isFx = inv.currency && inv.currency !== 'SEK'
const hasRate = inv.exchange_rate != null && Number(inv.exchange_rate) > 0
const outstandingSek =
isFx && !hasRate
? null
: resolveSekAmount(outstanding, null, inv.currency, inv.exchange_rate)
if (outstandingSek === null) unconvertedFxCount += 1
// Add invoice detail (always — even if unconvertible, so it's visible)
entry.invoices.push({
invoice_id: inv.id,
// Self-billing invoices we received have no own number — show the
// counterparty's external number instead.
invoice_number: inv.invoice_number || inv.external_invoice_number || '',
invoice_date: inv.invoice_date || '',
due_date: inv.due_date,
total,
paid_amount: paidAmount,
outstanding,
outstanding_sek: outstandingSek,
days_overdue: Math.max(0, daysOverdue),
currency: inv.currency || 'SEK',
})
if (outstandingSek === null) continue
// Bucket by aging (in SEK)
if (daysOverdue <= 0) {
entry.current += outstandingSek
} else if (daysOverdue <= 30) {
entry.days_1_30 += outstandingSek
} else if (daysOverdue <= 60) {
entry.days_31_60 += outstandingSek
} else if (daysOverdue <= 90) {
entry.days_61_90 += outstandingSek
} else {
entry.days_90_plus += outstandingSek
}
entry.total_outstanding += outstandingSek
}
// Round all amounts and sort invoices within each customer.
// Drop customers whose credit notes fully offset their open invoices (net 0).
const entries = Array.from(byCustomer.values())
.map((entry) => ({
...entry,
invoices: entry.invoices.sort((a, b) => a.due_date.localeCompare(b.due_date)),
current: Math.round(entry.current * 100) / 100,
days_1_30: Math.round(entry.days_1_30 * 100) / 100,
days_31_60: Math.round(entry.days_31_60 * 100) / 100,
days_61_90: Math.round(entry.days_61_90 * 100) / 100,
days_90_plus: Math.round(entry.days_90_plus * 100) / 100,
total_outstanding: Math.round(entry.total_outstanding * 100) / 100,
}))
.filter((entry) => entry.total_outstanding !== 0)
// Sort by total outstanding descending
entries.sort((a, b) => b.total_outstanding - a.total_outstanding)
const total_outstanding = entries.reduce((sum, e) => sum + e.total_outstanding, 0)
const total_current = entries.reduce((sum, e) => sum + e.current, 0)
const total_overdue = total_outstanding - total_current
const unpaid_count = entries.reduce(
(sum, e) => sum + e.invoices.filter((i) => i.outstanding !== 0).length,
0
)
return {
entries,
total_outstanding: Math.round(total_outstanding * 100) / 100,
total_current: Math.round(total_current * 100) / 100,
total_overdue: Math.round(total_overdue * 100) / 100,
unpaid_count,
unconverted_fx_count: unconvertedFxCount,
}
}