Files
accounted/lib/reports
Jakob Wennberg 9bb8b40420 fix(vat): veto the ruta 05 rate fallback on a contradicting account label (#1310)
* fix(vat): veto the ruta 05 rate fallback on a contradicting account label

The read-path fallback for #1289 shipped in #1296: fetchDynamicRuta05Accounts
drops the SQL sats filter and inferDomesticSalesRate resolves a NULL
default_vat_rate from the 30x1/30x2/30x3 suffix plus a matching
"25/12/6 % moms" label. That half is already on main and is not touched here.

What it lacks is a veto. Both signals can agree while the rest of the label
says the konto is not domestic taxable sales at all: "Forsaljning
byggtjanster 25 % moms, omvand betalningsskyldighet" is ruta 41, a VMB konto
is ruta 07, an export konto is ruta 36, a momsfri konto is ruta 42. Inferring
0.25 for any of them files the amount in ruta 05, which is a wrong box rather
than a missing one. A contradicting term now stands the fallback down, so the
konto keeps the behaviour it has today (omission) instead of being misfiled.
An explicitly configured rate, including an explicit 0, never reaches this
check and stays authoritative.

Two existing rules are now pinned by tests as deliberate, since a looser
resolver was proposed and rejected: the label must say the word "moms" after
the percent ("Forsaljning konsult 25 %" is a rate of pay, not a sats), and a
label naming two different sats resolves to nothing rather than to whichever
it spells out first.

Fixes #1289

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(vat): anchor the 0 % veto so it stops matching 10/20/30/100 %

The CONTRADICTING_ACCOUNT_NAME alternative `0\s*%` had no left word
boundary, so it also matched the trailing zero of any percentage ending
in zero. An ordinary domestic sales konto named "Forsaljning varor 25 %
moms, rabatt 30 %" was vetoed: agreeing 30x1 suffix, agreeing "25 %
moms" label, none of the veto's documented cases (momsfri, omvand, VMB,
export) applying. It dropped out of the ledger fetch, ruta 05 came out
short, and runVatDeclarationChecks raised a blocking
OUTPUT_VAT_WITHOUT_SALES_BASE: the exact #1261 symptom this module
exists to remove, re-created by the veto.

`\b0\s*%` keeps a genuine "0 % moms" label vetoing and stops matching
inside a longer number. The comment now records why the boundaries
differ per alternative, since the asymmetry is deliberate: "vmb" needs
both, "export" and "utanfor" are bare substrings so Swedish compounds
are caught too.

Both directions are pinned by tests that fail without the anchor.

Fixes #1289

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-07-30 18:49:39 +02:00
..
2026-07-12 19:14:12 +02:00
2026-07-23 16:16:55 +02:00
2026-07-28 19:50:16 +02:00
2026-07-28 19:50:16 +02:00
2026-07-28 19:50:16 +02:00
2026-07-08 09:54:46 +02:00