* fix(payroll): expose jämkning percentage and validity on the employee tax form (#1913)
An employee with a Skatteverket jämkning decision could not have the
adjusted withholding percentage set anywhere in the app: model, API and
engine supported jamkning_percentage / jamkning_valid_from /
jamkning_valid_to end to end, but EmployeeTaxCard never exposed them.
- EmployeeTaxCard: percentage input plus required from/to dates in the
A-skatt branch; null (= clear the beslut) when emptied or when no
table applies, mirroring tax_table_number. Both dates are required
because isJamkningValid only applies a beslut when both are set.
- Edit page: PATCH body sends the three fields as explicit values
(guarded on the card having reported), card initial seeded from the
employee, read-only Jämkning row in the tax section.
- NewEmployeeDialog: initial tax state and POST body carry the fields.
- Legacy PATCH /api/salary/employees/[id]: merged-state jämkning check
(start date required, dates ordered), same rule and messages as v1
and employee-commands, gated on the PATCH touching a jamkning key.
- lib/api/schemas.ts: truthful comment on the engine's both-dates gate.
- i18n: salary_employee.tax_jamkning_* in sv and en.
- Tests on the legacy PATCH route (400 x4, 200 x3) and the POST route.
The engine is deliberately untouched; the API/MCP contract (valid_to
optional) stays as is, follow-up filed in the PR body.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkUfWtuFCUkNtRAgMQCse2
* fix(payroll): jämkning keys reach the employee PATCH only when visible and edited (#1913)
Review findings on #1988: the card reported null for the three jämkning
fields whenever its inputs were hidden (sidoinkomst, F-skatt, FA-skatt,
ej verifierad) and the edit page forwarded those nulls, so toggling
sidoinkomst or fixing a phone number on an FA-skatt employee silently
wiped a stored beslut (which the engine still applies for FA-skatt).
The two date inputs were also natively required whenever a percentage
was present, so a beslut stored via the API/MCP without valid_to
(allowed by the schema) blocked the whole form on unrelated edits.
- lib/salary/jamkning-patch.ts (new): isJamkningEditable() and
jamkningPatch(); the keys are spread into the PATCH body with explicit
values (null = clear) only when the inputs were visible and edited,
otherwise omitted like every other sparse field.
- EmployeeTaxCard: jamkning_touched flag on EmployeeTaxValue, set by the
three handlers; required on both dates gated on it; non-blocking hint
(tax_jamkning_incomplete_hint, sv + en) on a seeded beslut missing a
date.
- Edit page spreads jamkningPatch(tax); NewEmployeeDialog initial state
carries the flag.
- Tests: lib/salary/__tests__/jamkning-patch.test.ts (keys omitted for
sidoinkomst / f_skatt / fa_skatt / not_verified / untouched seeded row,
explicit nulls when cleared, spread shape).
- DECISIONS.md: one line.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkUfWtuFCUkNtRAgMQCse2
* test(payroll): type the insert mock's payload so the typecheck ratchet accepts the jamkning tests
vi.fn(() => ...) infers an empty parameter tuple, so insert.mock.calls[0][0]
failed TS2493 under the new check:types gate (#1980) on CI. Declaring the
payload parameter keeps the assertions and makes the tuple indexable.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01FkUfWtuFCUkNtRAgMQCse2
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Jakob Wennberg
4f939ebb21