* fix(skattekonto): deep-link Skapa verifikat manuellt to a prefilled, auto-linked verifikat
"Skapa verifikat manuellt" in the SkattekontoBookDialog routed to plain
/bookkeeping: the user landed on the list with no form, no prefill and no
link to the row (reported by a user for a Slutlig skatt event, which has
no booking rule by design).
The CTA now deep-links to /bookkeeping?skv_tx=... carrying the row's id,
date, text and amount. The bookkeeping page opens the Nytt verifikat
dialog prefilled (1630 on the correct side per the booking sign
convention, balanced counter line with the motkonto left to pick, date
and description set) and, once the verifikat is saved (posted or draft),
links it back to the skattekonto row via the existing match endpoint. A
failed link degrades to a destructive toast pointing at the manual
"Matcha mot verifikat" path.
The URL params are prefill convenience only: the match route re-validates
ownership, ALREADY_BOOKED and ENTRY_ALREADY_LINKED server-side. The
parse/build/line-shaping contract lives in core lib
(lib/skatteverket/manual-verifikat-prefill.ts, unit-tested) because the
bookkeeping page cannot import from the extension.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(skattekonto): keep deep-link payload out of the URL + share the 1630 constant
Resolves the PR #1621 review findings in one pass:
- Compliance swarm (GDPR Art.5(1)(f), ISO A.8.12): the deep link no longer
carries date, text and amount as query params, where they would persist
in browser history, access logs and Referer headers. The row payload is
staged in sessionStorage, consumed single-use and validated against the
opaque skv_tx id, which is all the URL exposes. A missing or mismatched
payload degrades to the plain /bookkeeping list; the auto-link itself is
still validated server-side by the match route.
- Swedish accounting review note: SKATTEKONTO_ACCOUNT ('1630') is now
imported by the extension's booking and match libs from the core prefill
lib instead of being duplicated, so prefill and server-side booking
cannot drift.
- CodeRabbit docstring warning: the new lib exports carry docstrings.
Storage is injectable (PrefillStorage) so the node-env tests cover the
round-trip, single-use semantics, id mismatch, malformed payloads and a
throwing privacy-mode storage.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* docs(skattekonto): record the sessionStorage staging window as accepted residual risk
The compliance swarm's remaining LOW finding (ISO A.8.12) offers
documentation as its remediation path: an XSS attacker already reads the
full ledger via the session's authenticated APIs, so the sub-second
sessionStorage staging window adds no capability worth a server-issued
token roundtrip. Recorded in the lib header and DECISIONS.md.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Mattsson
4362bffc0c