* fix(enable-banking): pin Mobile BankID (decoupled) auth_method so Handelsbanken corporate connects We never sent auth_method to Enable Banking, so it fell back to the ASPSP's visible default — REDIRECT for Handelsbanken. For Handelsbanken *corporate* PSUs the redirect flow does not support Mobile BankID, so authorization failed right after the user approved in the BankID app. Mobile BankID at Handelsbanken is a DECOUPLED method flagged hidden_method=true, which Enable Banking only uses when requested explicitly. Resolve the bank's preferred auth method before /auth: query the ASPSP's auth_methods and pick the DECOUPLED (Mobile BankID) method when present, otherwise leave auth_method unset so banks that already work are untouched. The method name is read dynamically per psu_type, so it is robust across sandbox/production naming. - api-client: add approach/hidden_method to AuthMethod, fix ASPSP.auth_methods field name (was available_auth_methods, never populated), add getPreferredAuthMethod(), thread optional authMethod through startAuthorization - index: resolve authMethod in /connect and pass it on both fresh + reconnect - tests: cover method selection and request-body shaping Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * refactor(invoice-inbox): clean up bulk-selection toolbar UI Redesign the selection toolbar shown when inbox items are checked: one solid primary "Bokför valda" button with outlined secondary actions ("Fråga assistenten", "Ta bort") and a plain selection count. Removes the redundant "Avmarkera" button (users uncheck the still-visible box), fixes label clipping, and gives the toolbar more breathing room. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * chore(entitlements): bypass paywall in local development Add isPaywallBypassed() so all gated capabilities are testable locally without a subscription. Fires only on NODE_ENV=development (npm run dev) or an explicit DISABLE_PAYWALL=true escape hatch — production builds run under NODE_ENV=production and the entitlement suite runs under 'test', so both keep exercising the real gate. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(tic): resolve enskild firma bolagsuppgifter via 12-digit personnummer TIC's Lens search is fuzzy and only resolves an enskild firma from the 12-digit (century-prefixed) personnummer; a 10-digit form fuzzy-matched an unrelated entity. Expand personnummer to 12 digits before querying and reject hits whose registration number is unrelated to the request. Add a "Hämta" action to the settings Bolagsuppgifter panel to (re)fetch on demand. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * feat(transactions): implement categorize core for bank transaction categorization - Added `categorize-core.ts` to handle categorization of bank transactions, supporting single and bulk operations. - Introduced `categorizeMatchedTransaction` and `bulkBookMatchedInboxItems` functions for transaction processing. - Implemented fiscal period validation and duplicate booking detection. - Enhanced logging and error handling for transaction categorization. feat(scripts): add diagnostic script for Handelsbanken ASPSP metadata - Created `check-handelsbanken-aspsp.mjs` to fetch and display available authentication methods for Handelsbanken. - Outputs metadata for business and personal PSU types, including default authentication methods. fix(migrations): increase statement timeout for SIE bulk delete operations - Updated `20260629160000_sie_bulk_delete_statement_timeout.sql` to set a longer statement timeout for bulk delete RPCs to prevent cancellations during large imports. feat(migrations): add bulk book inbox items to pending operations - Expanded `pending_operations` table to include `bulk_book_inbox_items` operation type in `20260630120000_pending_operations_add_bulk_book_inbox_items.sql`. - Supports bulk booking of matched inbox items against bank transactions. test(pg): add tests for replace_period_opening_balance_link RPC - Implemented tests in `replace-period-opening-balance-link.pg.test.ts` to validate the functionality of the opening-balance correction flow. - Ensured immutability of opening balance links and proper handling of posted vs. non-posted entries. * fix(sie-export): update journal entries and lines handling in SIE export tests * fix(migrations): resolve version collision on 20260629160000 The SIE bulk-delete statement_timeout migration shared version 20260629160000 with journal_entries_list_series_filter (merged from main via #798/#823), causing a schema_migrations_pkey duplicate key error on apply. Rename the branch's migration to 20260629160100. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(compliance): resolve compliance-swarm + review findings - opening-balance/correct: compensating rollback for the non-atomic storno+rebook so a mid-sequence failure never leaves two posted OB entries (ASVS V2.3); durable audit event on every failure path (V16); reference the original verifikationsnummer in the corrected entry per BFL 5 kap 5§; document that requireWrite already enforces write-role + membership (V8.2.1 was a false positive) - reports sources routes: validate the cursor date component as ISO (/^\d{4}-\d{2}-\d{2}$/) before use, 400 on malformed (ASVS V1.2), applied to both the VAT-declaration and trial-balance routes - AgentSessionList: await the rename PATCH, revert the optimistic title and toast on failure (ASVS V4.5) - bank booking: exclude same-batch siblings from the booking-time duplicate guard so bulk-booking distinct same-(date,amount) transactions no longer false-positives; pre-existing duplicate detection is preserved - BulkBookInboxDialog: drop the unsafe currency-based reverse_charge default, add an omvänd skattskyldighet advisory, and type VAT options to the backend VatTreatment union - OpeningBalanceRowEditor: hold onChange in a ref (synced in effect, not during render) so an unstable callback can't cause a render loop Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
254 lines
10 KiB
TypeScript
254 lines
10 KiB
TypeScript
'use client'
|
|
|
|
import { useMemo, useState, useEffect } from 'react'
|
|
import {
|
|
Dialog,
|
|
DialogContent,
|
|
DialogHeader,
|
|
DialogTitle,
|
|
DialogDescription,
|
|
DialogFooter,
|
|
} from '@/components/ui/dialog'
|
|
import { Button } from '@/components/ui/button'
|
|
import { Label } from '@/components/ui/label'
|
|
import { Select, SelectContent, SelectItem, SelectTrigger, SelectValue } from '@/components/ui/select'
|
|
import { InfoTooltip } from '@/components/ui/info-tooltip'
|
|
import { useToast } from '@/components/ui/use-toast'
|
|
import { Loader2 } from 'lucide-react'
|
|
import { formatCurrency } from '@/lib/utils'
|
|
import type { InvoiceExtractionResult, VatTreatment } from '@/types'
|
|
|
|
// Minimal shape the dialog needs from the workspace's inbox items.
|
|
interface BulkBookInboxItem {
|
|
id: string
|
|
matched_transaction_id: string | null
|
|
created_journal_entry_id: string | null
|
|
created_supplier_invoice_id: string | null
|
|
extracted_data: InvoiceExtractionResult | null
|
|
}
|
|
|
|
interface Props {
|
|
open: boolean
|
|
onOpenChange: (v: boolean) => void
|
|
// The user's full checkbox selection. Non-bookable items are filtered out
|
|
// and surfaced as a "skipped" count so the user understands the outcome.
|
|
items: BulkBookInboxItem[]
|
|
onSuccess: () => void | Promise<void>
|
|
}
|
|
|
|
// Swedish category labels — mirrors lib/bookkeeping/category-mapping.ts
|
|
// (categoryLabels), ordered expenses-first since underlag are overwhelmingly
|
|
// costs. Values match TransactionCategorySchema in lib/api/schemas.ts.
|
|
const CATEGORY_OPTIONS: { value: string; label: string }[] = [
|
|
{ value: 'expense_software', label: 'Programvara/IT-tjänster' },
|
|
{ value: 'expense_office', label: 'Kontorskostnad' },
|
|
{ value: 'expense_consumables', label: 'Förbrukningsvaror' },
|
|
{ value: 'expense_equipment', label: 'Förbrukningsinventarier' },
|
|
{ value: 'expense_telecom', label: 'Telefon & internet' },
|
|
{ value: 'expense_travel', label: 'Resekostnad' },
|
|
{ value: 'expense_marketing', label: 'Marknadsföring' },
|
|
{ value: 'expense_professional_services', label: 'Konsulttjänst' },
|
|
{ value: 'expense_education', label: 'Utbildning' },
|
|
{ value: 'expense_representation', label: 'Representation' },
|
|
{ value: 'expense_vehicle', label: 'Bil & drivmedel' },
|
|
{ value: 'expense_bank_fees', label: 'Bankavgift' },
|
|
{ value: 'expense_card_fees', label: 'Kortavgift' },
|
|
{ value: 'expense_currency_exchange', label: 'Valutaväxling' },
|
|
{ value: 'expense_other', label: 'Övrig kostnad' },
|
|
{ value: 'income_services', label: 'Tjänsteförsäljning' },
|
|
{ value: 'income_products', label: 'Varuförsäljning' },
|
|
{ value: 'income_other', label: 'Övrig intäkt' },
|
|
{ value: 'private', label: 'Privat' },
|
|
]
|
|
|
|
// VAT treatment options. `value` is typed as `VatTreatment` (types/index.ts)
|
|
// so this list can never drift from what the backend accepts: the bulk-book
|
|
// route feeds the value straight into buildMappingResultFromCategory, which
|
|
// only recognises these six. The 12% and 6% reduced rates are ALREADY covered
|
|
// here by `reduced_12` / `reduced_6` — there is deliberately no `standard_12` /
|
|
// `standard_6` (no such treatment exists; the backend would reject it). Keep
|
|
// this list in sync with the union, not with rate labels.
|
|
const VAT_OPTIONS: { value: VatTreatment; label: string }[] = [
|
|
{ value: 'standard_25', label: 'Moms 25%' },
|
|
{ value: 'reduced_12', label: 'Moms 12%' },
|
|
{ value: 'reduced_6', label: 'Moms 6%' },
|
|
{ value: 'reverse_charge', label: 'Omvänd skattskyldighet (EU/utland)' },
|
|
{ value: 'export', label: 'Export (0%)' },
|
|
{ value: 'exempt', label: 'Momsfri' },
|
|
]
|
|
|
|
function isBookable(it: BulkBookInboxItem): boolean {
|
|
return Boolean(it.matched_transaction_id) && !it.created_journal_entry_id && !it.created_supplier_invoice_id
|
|
}
|
|
|
|
export default function BulkBookInboxDialog({ open, onOpenChange, items, onSuccess }: Props) {
|
|
const { toast } = useToast()
|
|
const [category, setCategory] = useState<string>('')
|
|
const [vatTreatment, setVatTreatment] = useState<VatTreatment>('standard_25')
|
|
const [isSubmitting, setIsSubmitting] = useState(false)
|
|
|
|
const bookable = useMemo(() => items.filter(isBookable), [items])
|
|
const notMatched = useMemo(
|
|
() => items.filter((it) => !it.matched_transaction_id && !it.created_journal_entry_id && !it.created_supplier_invoice_id).length,
|
|
[items],
|
|
)
|
|
const alreadyBooked = useMemo(
|
|
() => items.filter((it) => it.created_journal_entry_id || it.created_supplier_invoice_id).length,
|
|
[items],
|
|
)
|
|
|
|
// Reset to the safe default (25% svensk moms) each time the dialog opens.
|
|
// Currency is deliberately NOT used to preselect omvänd skattskyldighet: a
|
|
// foreign currency does not imply a foreign seller — a Swedish supplier can
|
|
// invoice in EUR and still debit 25% moms. Reverse charge is a property of
|
|
// the seller (utländsk, utan svenskt momsnr), never of the currency, so
|
|
// defaulting to it from currency alone would silently mis-book domestic VAT.
|
|
// The advisory rendered under the Moms picker spells this out to the user.
|
|
useEffect(() => {
|
|
if (open) setVatTreatment('standard_25')
|
|
}, [open])
|
|
|
|
const totalSek = useMemo(
|
|
() => bookable.reduce((s, it) => s + (it.extracted_data?.totals?.total ?? 0), 0),
|
|
[bookable],
|
|
)
|
|
|
|
const submit = async () => {
|
|
if (!category || bookable.length === 0) return
|
|
setIsSubmitting(true)
|
|
try {
|
|
const res = await fetch('/api/extensions/ext/invoice-inbox/items/bulk-book', {
|
|
method: 'POST',
|
|
headers: { 'Content-Type': 'application/json' },
|
|
body: JSON.stringify({
|
|
item_ids: bookable.map((it) => it.id),
|
|
category,
|
|
vat_treatment: vatTreatment,
|
|
}),
|
|
})
|
|
const json = await res.json().catch(() => ({}))
|
|
if (!res.ok) {
|
|
throw new Error(json.error ?? `HTTP ${res.status}`)
|
|
}
|
|
const bookedCount: number = json.data?.booked_count ?? 0
|
|
const skippedCount: number = json.data?.skipped_count ?? 0
|
|
const parts: string[] = []
|
|
if (bookedCount > 0) parts.push(`${bookedCount} bokförda`)
|
|
if (skippedCount > 0) parts.push(`${skippedCount} överhoppade`)
|
|
toast({
|
|
title: 'Bulkbokföring klar',
|
|
description: parts.join(' · ') || 'Inga underlag bokfördes',
|
|
variant: bookedCount === 0 ? 'destructive' : 'default',
|
|
})
|
|
onOpenChange(false)
|
|
await onSuccess()
|
|
} catch (err) {
|
|
toast({
|
|
title: 'Bokföringen misslyckades',
|
|
description: err instanceof Error ? err.message : 'Okänt fel',
|
|
variant: 'destructive',
|
|
})
|
|
} finally {
|
|
setIsSubmitting(false)
|
|
}
|
|
}
|
|
|
|
const skippedNote: string | null = useMemo(() => {
|
|
const bits: string[] = []
|
|
if (notMatched > 0) bits.push(`${notMatched} saknar matchad transaktion`)
|
|
if (alreadyBooked > 0) bits.push(`${alreadyBooked} redan bokförda`)
|
|
return bits.length > 0 ? bits.join(' · ') : null
|
|
}, [notMatched, alreadyBooked])
|
|
|
|
return (
|
|
<Dialog open={open} onOpenChange={onOpenChange}>
|
|
<DialogContent className="sm:max-w-md">
|
|
<DialogHeader>
|
|
<DialogTitle>Bokför {bookable.length} underlag</DialogTitle>
|
|
<DialogDescription>
|
|
Varje underlag bokförs mot sin matchade banktransaktion med samma kategori och momsbehandling.
|
|
</DialogDescription>
|
|
</DialogHeader>
|
|
|
|
<div className="space-y-4">
|
|
<div className="space-y-2">
|
|
<Label htmlFor="bulk-category">Kategori</Label>
|
|
<Select value={category} onValueChange={setCategory}>
|
|
<SelectTrigger id="bulk-category">
|
|
<SelectValue placeholder="Välj kategori" />
|
|
</SelectTrigger>
|
|
<SelectContent>
|
|
{CATEGORY_OPTIONS.map((opt) => (
|
|
<SelectItem key={opt.value} value={opt.value}>
|
|
{opt.label}
|
|
</SelectItem>
|
|
))}
|
|
</SelectContent>
|
|
</Select>
|
|
</div>
|
|
|
|
<div className="space-y-2">
|
|
<div className="flex items-center gap-1">
|
|
<Label htmlFor="bulk-vat">Moms</Label>
|
|
<InfoTooltip
|
|
content={
|
|
<>
|
|
Välj <strong>Omvänd skattskyldighet</strong> för köp från en utländsk säljare utan
|
|
svenskt momsnummer (t.ex. EU-tjänster som moln/mjukvara). Svenska fakturor med moms:
|
|
välj den sats kvittot visar — valutan avgör inte.
|
|
</>
|
|
}
|
|
/>
|
|
</div>
|
|
<Select value={vatTreatment} onValueChange={(v) => setVatTreatment(v as VatTreatment)}>
|
|
<SelectTrigger id="bulk-vat">
|
|
<SelectValue />
|
|
</SelectTrigger>
|
|
<SelectContent>
|
|
{VAT_OPTIONS.map((opt) => (
|
|
<SelectItem key={opt.value} value={opt.value}>
|
|
{opt.label}
|
|
</SelectItem>
|
|
))}
|
|
</SelectContent>
|
|
</Select>
|
|
|
|
{vatTreatment === 'reverse_charge' && (
|
|
<div className="rounded-md border border-border bg-secondary/40 p-3 text-xs text-muted-foreground">
|
|
<strong className="font-medium text-foreground">Kontrollera säljaren.</strong>{' '}
|
|
Omvänd skattskyldighet gäller bara köp från en <strong className="font-medium text-foreground">utländsk
|
|
säljare utan svenskt momsregistreringsnummer</strong> — t.ex. EU-tjänster, EU-varor,
|
|
byggtjänster eller viss elektronik. Valutan avgör inte: en svensk säljare kan fakturera i
|
|
EUR och ändå debitera 25% moms. Är säljaren svensk och momsen står på kvittot, välj i
|
|
stället rätt momssats ovan.
|
|
</div>
|
|
)}
|
|
</div>
|
|
|
|
{totalSek > 0 && (
|
|
<p className="text-xs text-muted-foreground tabular-nums">
|
|
Underlagens summa: {formatCurrency(totalSek)}
|
|
</p>
|
|
)}
|
|
|
|
{skippedNote && (
|
|
<p className="text-xs text-muted-foreground">
|
|
Hoppas över: {skippedNote}.
|
|
</p>
|
|
)}
|
|
</div>
|
|
|
|
<DialogFooter>
|
|
<Button variant="ghost" onClick={() => onOpenChange(false)} disabled={isSubmitting}>
|
|
Avbryt
|
|
</Button>
|
|
<Button onClick={submit} disabled={isSubmitting || !category || bookable.length === 0}>
|
|
{isSubmitting && <Loader2 className="h-4 w-4 mr-2 animate-spin" />}
|
|
Bokför {bookable.length} underlag
|
|
</Button>
|
|
</DialogFooter>
|
|
</DialogContent>
|
|
</Dialog>
|
|
)
|
|
}
|