* fix(transactions): close booking duplicate guard blind spots G1-G3
The booking-time duplicate guard missed the most common bank-fee twin
shapes:
- G1: the sibling scan matched on the EXACT date only, so a duplicate
import with a drifted date (CSV bokforingsdag vs PSD2 valutadag) was
invisible. The scan now uses a +-3 day window with a deterministic
ranking where exact-date candidates always outrank drifted ones
(force=true re-detection stays bound to the reviewed candidate).
- G2: booked-ness required transactions.journal_entry_id, so bulk-booked
(transaction_voucher_links) and multi-allocated (invoice_payments /
supplier_invoice_payments) siblings read as unbooked. The scan now
batch-fetches the anchor rows and resolves the verifikat via
getPrimaryJournalEntryId (is_transaction_booked semantics).
- G3: the ledger scan excluded every voucher linked to any transaction,
so a voucher booked from a date-drifted duplicate row escaped BOTH
halves and the booking proceeded with no warning. A voucher whose
linking transaction itself matches the target (same ore in the same
currency, compatible cash account, date in the window) is now returned
as the twin with transaction_id set.
All candidate picks keep explicit total-order tiebreakers so a force
re-detect returns the same candidate the user reviewed, and the
SEK-or-null amount contract is unchanged.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(transactions): offer match/ignore for sibling duplicates and route all 409s into the dialog
The duplicate dialog hid its match action for sibling-transaction
candidates (canMatch required transaction_id === null), so the user who
most needed steering saw only 'Bokfor anda'. manualLink explicitly
allows N:1 links, so the match action is now offered for both candidate
kinds. Sibling candidates get question-form body copy ('vill du matcha
mot verifikatet i stallet?') and an additional 'Ignorera transaktionen'
action via the existing POST /api/transactions/[id]/ignore, which is the
correct resolution when the row itself is a duplicate import (matching
would double-count the bank side, booking the ledger side).
Two clients dead-ended the TRANSACTION_BOOK_POSSIBLE_DUPLICATE 409 in a
destructive toast with no way forward:
- the counterparty-template branch of handleQuickReviewConfirm now sets
the shared duplicateWarning state exactly like runCategorize, with the
force retry bound to the reviewed candidate's voucher
- BankReconciliationView's quick-book now opens the same dialog, with
match/ignore refreshing the reconciliation lists
New sv/en strings: dialog_duplicate_body_sibling,
dialog_duplicate_ignore, dialog_duplicate_ignore_failed. File-level
parity tests pin the 409 routing and the dialog affordances.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(transactions): duplicate guard on the bulk-book samlingsverifikation path
/api/transactions/bulk-book never called detectBookingDuplicate, so a
batch containing an already-booked twin minted a second verifikat with
no warning. The route now runs the shared per-tx guard before the RPC,
with intra-batch exclusions (the other selected txs are distinct events
the user picked, and the link-existing target voucher is the batch's own
destination), returning 409 TRANSACTION_BOOK_POSSIBLE_DUPLICATE with the
candidate and the flagged tx id.
BulkBookDialog routes the 409 into DuplicateBookingDialog for review
(view voucher / cancel / book anyway) instead of a dead-end toast;
'Bokfor anda' re-runs the batch with force=true. On force the route
re-detects and records each dismissed candidate as
BankTransactionDuplicateDismissed in behandlingshistorik (BFNAR 2013:2
kap 8), parity with the /categorize bypass. Detection failures stay
fail-open. Note: the MCP RPC twin (gnubok_bulk_book_transactions)
bypasses this route and remains unguarded; guarding inside the RPC needs
a migration and is out of scope here.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
* fix(transactions): gate the duplicate-dialog ignore hint on the action being present
The sibling body copy mentioned ignoring the row, but two render sites
(the manual booking form and the bulk dialog) show sibling candidates
without the ignore action. The guidance now lives in a separate
dialog_duplicate_ignore_hint string rendered only when the Ignorera
button itself renders, so copy never points at a button that is not
there.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
---------
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Jakob Wennberg
0d3ba5268d