* fix(invoices): say what is missing when an invoice preview cannot be rendered
The PDF route already refuses with a structured envelope that names exactly
what the invoice lacks (no bankgiro, plusgiro, Swish or bank account for a
SEK invoice; no IBAN account for a foreign currency) and where to add it.
Two clients threw that away:
- The settings preview dialog (Inställningar -> Fakturering -> Förhandsvisa
faktura) wrapped the envelope's inner object in new Error(), which
stringified it to "[object Object]" and left only the generic "Kunde inte
hantera fakturan. Försök igen." fallback. The parsed body now goes to the
error mapper whole, with the invoice context and status.
- The invoice page's Förhandsgranska navigated a new tab straight to the
re-render URL, so a 400 showed the raw JSON in that tab. The tab is now
opened blank inside the click's activation window, the PDF is fetched
first, and the tab gets the PDF as a blob URL or is closed again with the
refusal in a toast. The archived delivery copy keeps the direct open.
Ladda ner on the same page had a fixed "Kunde inte generera PDF" for
re-render refusals and now maps the body the same way.
Regression test on the mapper covers the exact call shape the two surfaces
use and pins the old mangled shape as the fallback it produced.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GUdZPW46a16GWUdgt2qSZA
* fix(invoices): probe the PDF route before opening the preview tab
Resolves the review findings on the first push in one pass.
Skeptic (correctness): the archived-copy branch still called window.open
with 'noopener', which returns null by spec even on success, so every
successful archived preview also fired the "popup blocked" toast (#1613
had the same defect). Both branches now go through openDeferredTab, which
opens with a real handle and severs the opener itself.
Skeptic (regression): serving the re-render as a blob URL lost the
Content-Disposition filename and gave the tab an address that dies on
reload. The route gains ?probe=1, which runs every refusal check and
answers 204 without rendering; the page probes first, shows a refusal as a
toast, and otherwise points the tab at the real inline URL. Filename,
reload and the single render are all kept. The blob URL is gone, which
also settles the compliance swarm's noopener and unrevoked-blob notes and
CodeRabbit's revoke request.
CodeRabbit: the probe fetch is bounded by AbortSignal.timeout so a stalled
route cannot leave a blank tab open, and the network-error mapper now
receives the active locale and invoice context.
Tests: route probe (204 without render, same 400 envelope as the render,
unknown value ignored) and the URL helper's probe flag.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GUdZPW46a16GWUdgt2qSZA
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
Mattsson
9418de585f