971952fe19
* fix(mail): request gmail.readonly alone and read the mailbox address from Gmail's profile Google's restricted-scope review (2026-08-31) bounced the Gmail connector on a "scope discrepancy": the authorization URL asked for `openid email` on top of gmail.readonly, while the Cloud Console declares gmail.readonly only, and the review string-matches the two. The extra scopes existed solely to learn the mailbox address from the id_token. Gmail's users.getProfile returns that address under gmail.readonly, so the consent request now carries exactly one scope and the callback reads the address from the profile. Also adds `app_metadata.mfa_exempt === true` to shouldEnforceMfa. Google's reviewers log in with credentials we hand them and treat a second factor as an "authentication blocker"; app_metadata is service-role only, so this is an operator switch for demo accounts, never a user-reachable setting. Tests: scope pinned in google-oauth.test.ts, profile read in gmail-client.test.ts, callback path in oauth-callback.test.ts, flag shape in mfa.test.ts. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UD3HsDX8hnJEqpt35azxBJ * fix(auth): time-box the reviewer MFA exemption instead of a boolean flag Superagent's P1 on the first shape was fair: a boolean app_metadata.mfa_exempt relied on someone remembering to clear it. The exemption is now app_metadata.mfa_exempt_until, an ISO timestamp honoured only while it lies in the future, so a forgotten flag dies on its own. Anything malformed or non-string enforces MFA. Still service-role only, still meant for the one demo account Google's OAuth reviewers log in with. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UD3HsDX8hnJEqpt35azxBJ --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
49 lines
1.8 KiB
TypeScript
49 lines
1.8 KiB
TypeScript
/**
|
|
* MFA (Multi-Factor Authentication) helpers.
|
|
*
|
|
* MFA is only required on the hosted version, never for self-hosted deployments.
|
|
* Enforcement is application-side (middleware + API routes), not RLS.
|
|
*/
|
|
|
|
import { flagEnabled, isSelfHosted } from '@/lib/env/public-flags'
|
|
|
|
export function isMfaRequired(): boolean {
|
|
if (isSelfHosted()) return false
|
|
return flagEnabled(process.env.NEXT_PUBLIC_REQUIRE_MFA)
|
|
}
|
|
|
|
/**
|
|
* A time-boxed exemption: `app_metadata.mfa_exempt_until` holds an ISO
|
|
* timestamp, and the gate is skipped only while that instant is in the
|
|
* future. app_metadata is written only through the service role (never from a
|
|
* browser session), so this is an operator switch for the one kind of account
|
|
* that must be usable by someone who cannot enrol an authenticator: Google's
|
|
* OAuth verification reviewers, who log in with credentials we hand them and
|
|
* treat any second factor as an "authentication blocker".
|
|
*
|
|
* Time-boxed rather than a boolean so a forgotten flag cannot outlive the
|
|
* review: the exemption dies on its own. Anything malformed enforces MFA.
|
|
*/
|
|
export function isMfaExemptionActive(
|
|
user: { app_metadata?: Record<string, unknown> },
|
|
now: Date = new Date(),
|
|
): boolean {
|
|
const until = user.app_metadata?.mfa_exempt_until
|
|
if (typeof until !== 'string') return false
|
|
const expires = Date.parse(until)
|
|
if (Number.isNaN(expires)) return false
|
|
return expires > now.getTime()
|
|
}
|
|
|
|
/**
|
|
* Check if MFA should be enforced for a specific user.
|
|
* BankID-linked users skip TOTP because BankID is inherently 2FA.
|
|
* A live, time-boxed exemption (see isMfaExemptionActive) also skips it.
|
|
*/
|
|
export function shouldEnforceMfa(user: { app_metadata?: Record<string, unknown> }): boolean {
|
|
if (!isMfaRequired()) return false
|
|
if (user.app_metadata?.bankid_linked) return false
|
|
if (isMfaExemptionActive(user)) return false
|
|
return true
|
|
}
|