Files
accounted/lib/reports/__tests__/vat-settlement.test.ts
T
Mattsson b6332e9ff4 Fix/skv connection flow (#1015)
* feat(salary): one-click AGI submission with filing state machine and success feedback

The AGI panel required users to know that "Ladda ner AGI-fil" was the
generate step, then click submit, signing link, and kvittens manually.
A nollkorning filing stalled on "AGI-XML saknas" pointing at a UI path
that does not exist.

- New primary button "Lamna in till Skatteverket" chains the existing
  endpoints client-side: generate XML if missing, POST underlag, poll
  kontrollresultat, create signing link, open Mina Sidor in a tab opened
  synchronously at click (popup-blocker safe). Inline stepper shows each
  step; the four old buttons become collapsed advanced/recovery actions,
  auto-expanded in stale-draft and rejected states. XML download stays
  visible and free for manual filing.
- deriveAgiFilingState() + useAgiSubmission() lift the per-period
  submission record to the run page: the progress rail and salary hero
  now render the real state machine (generated, underlag inskickat,
  vantar pa BankID-signatur, inlamnad med kvittensnummer) instead of
  telling users to "lamna in" an already-submitted declaration.
- Success card with kvittensnummer and signature metadata once signed,
  plus a toast when a poll flips the state while the page is open.
- AGI kvittens cron every 15 min instead of every 2 h so filings signed
  on another device get stamped and emailed promptly.
- Advanced submit also auto-generates, and the stale "Lon -> AGI ->
  Generera" error text now points at the real buttons.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(enable-banking): instant OAuth callback feedback and dead-attempt cleanup

The bank redirect landed on a blank page for the several seconds the
callback spent exchanging the PSD2 session and mirroring accounts, and
every failed connect attempt left a status='error' row that rendered
forever as an "Atgard kravs" card next to a successful retry, showing
duplicate connections to the same bank.

- Stream a branded "Slutfor bankanslutningen" progress page from the
  callback: the shell flushes before the session exchange starts and a
  script/meta redirect follows when the work completes, with a 30s
  slow-work escape hatch. Fast outcomes (denial, bad params, unknown
  state) keep their plain redirects.
- Delete never-activated connection rows (no session_id, no
  accounts_data) on denial or exchange failure, and sweep leftovers for
  the same bank on the next connect. Established connections keep their
  "Atgard krävs" card via the accounts_data guard; FKs are ON DELETE
  SET NULL so deletion has no dependents.
- Show "Banken ar ansluten: hamtar dina konton" while the settings
  panel loads after the callback instead of an anonymous spinner.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): reject re-send of issued invoices and gate bookkeeping on the sent flip

A direct POST to /api/invoices/[id]/send against an already-issued
invoice re-emailed the customer and posted a second revenue verifikat
(createInvoiceJournalEntry has no dedup), overwriting journal_entry_id
and orphaning the first entry. Only the UI hid the button; the v1 route
and the MCP commit executor already rejected non-drafts.

- Non-draft invoices now return 409 INVOICE_ALREADY_SENT.
- The draft to sent status flip is an optimistic lock (status guard plus
  row-count check); journal entry, accrual schedules, PDF archival and
  the invoice.sent event only run for the request that won the flip.
- On a flip failure the journal entry is deferred: the row stays draft
  and a retry re-runs the pipeline, ending with exactly one verifikat.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): payment links, failure visibility and sandbox guard for recurring auto-send

- sendInvoiceFromSchedule now auto-creates an online payment link via
  applyPaymentLinkToInvoice before rendering and passes the payment
  link QR to the PDF: parity with the dashboard and v1 send routes,
  which recurring invoices silently lacked.
- The recurring cron persists last_run_warning both when a claimed run
  throws (hourly retries stay visible on the schedule) and when a stale
  schedule is rolled forward, so a deterministic failure can no longer
  skip a month silently.
- Auto-send is blocked for sandbox companies at the email chokepoint
  (freeze-and-retain: the invoice is still generated as a draft),
  covering both the cron and the run-now route with one guard.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(salary): close the Fortnox payroll API gaps (phases 1-4)

Payroll now runs end-to-end through the open API, including onboarding a
client from another payroll system, with every write staged for approval.

- v1: per-employee payslips (list/detail/PDF), payslip line writes,
  run roster attach/remove, absence ranges (per-day storage), jamkning
  fields, cutover opening balances (single + atomic bulk PUT), vacation
  balance + vacation-year-close. PUT added to the wrapper's idempotency/
  test-key set (test keys could otherwise write through PUT).
- MCP: 10 new tools (get_employee/get_payslip/list_absence/
  get_vacation_balance reads + staged update_payslip_line,
  register_absence, create_employee, update_employee,
  set_employee_opening_balances, close_vacation_year), executors, risk
  tiers, op-type CHECK expansions. create_employee encrypts personnummer
  at staging: pending_operations never holds plaintext.
- Scope-map audit retrofit: 11 formerly unmapped tools now scoped;
  BREAKING for keys that relied on the 4 default-allow writes.
- Cutover: employee_opening_balances (derived lock trigger, self-unlocks
  on run correction), engine YTD/karens/liability integration,
  Ingaende saldon section in the employee editor.
- Arbetsschema-lite: employees.hours_per_week/workdays_per_week drive the
  hourly/daily divisors; legacy 173/21 preserved exactly at defaults so
  existing pay math is byte-identical.
- Vacation ledger + semesterberedning/arsavslut: recomputed per-year day
  balances (synced on book/correct, non-fatal), year-close with the
  min-20 floor, 5-year sparade-dagar expiry to forced payout, and a
  2920/2940 drift adjustment via the bookkeeping engine; Semester
  dashboard card with preview-then-confirm dialog.
- Fix: Zod 4 defaults leak through .partial(), which made every sparse
  employee PATCH fail validation and reset defaulted columns.

Migrations 20260713100000/101000/110000/121000/122000 (applied to
staging with version rows; prod via merge). vacation_ledger renamed from
20260713120000 to avoid colliding with vat_declaration_totals_rpc.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* perf: cut dashboard page-load latency (region, round trips, caching, VAT RPC)

The dominant cost was infrastructure: Vercel functions ran in iad1
(Washington D.C.) while Supabase (DB + auth) lives in eu-north-1
(Stockholm), so every request paid 4-5 transatlantic round trips of
auth + company resolution before doing any real work (measured
530-1900ms for single-query GETs in prod logs). Pin functions to arn1
and cut the redundant work on top:

- vercel.json: functions to arn1, same city as the database
- getActiveCompanyId: preference + first-membership queries run in
  parallel; the fallback result doubles as validation in the common
  single-company case (one round trip instead of two sequential)
- withRouteContext: Server-Timing header and authMs/companyMs/handlerMs
  in the op-completed log, so latency is attributable per phase
- dashboard layout: nav badge counts off the critical path; DashboardNav
  loads them client-side via the new use-worklist-badges SWR hook with
  debounced realtime revalidation
- swr (new dependency, approved): global provider; useCompanySettings
  shares one cache entry across consumers and renders from cache on
  back-navigation instead of re-showing skeletons
- /pending: realtime refetch debounced; bulk operations previously
  fired 4 requests per row-change event
- VAT declaration: new get_vat_declaration_totals RPC returns
  per-account totals, settlement-shape detection (#984) and
  source_type counts in ONE round trip instead of paging every
  entry+line through PostgREST. Account lists stay TS-side parameters
  so ACCOUNT_RUTA remains the single source of truth. Shape-exclusion
  coverage moved to tests/pg/vat-declaration-totals-rpc.pg.test.ts;
  DDL already applied to staging.
- bundle: CommandPalette lazy-mounts on first Ctrl/Cmd+K, AgentChat
  dynamic-imports the markdown parser, @vercel/speed-insights (new
  dependency, approved) added for real-user timings

The /salary fetch-waterfall fix from the same effort already landed
inside 2084a756.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): settle öre-rounded payments from the mark-paid flow

An invoice with öresavrundning shows a rounded "Att betala" on the PDF;
the customer pays that amount (up to 50 öre off the stored öre total) and
the invoice-page mark-paid flow rejected it with
MATCH_AMOUNT_EXCEEDS_REMAINING: a dead end, while the bank-transaction
match flow already absorbed the residual to 3740.

- PaymentBookingDialog now proposes the rounded bank leg plus the 3740
  residual line (credit when rounded up, debit when rounded down),
  resolved via getDisplayTotal from the per-invoice override and
  company_settings.ore_rounding.
- settleInvoicePayment and the v1 mark-paid route absorb the sub-krona
  residual, gated by planInvoicePaymentForLines: absorption applies ONLY
  when the caller lines carry the exact residual on 3740; otherwise the
  strict plan applies (sub-krona partials stay partial, no-3740
  overshoots keep the 400), so the GL can never diverge from the AR
  sub-ledger.
- planInvoicePayment absorb-band boundary tightened to >= 1 kr: an
  exactly-1-kr overshoot used to slip past both the guard and the absorb
  branch and silently over-record paid_amount (pre-existing on the
  bank-match path).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(security): resolve all 7 PR compliance findings

- ASVS V3.3: per-request CSP nonce on the enable-banking finalize page
  (mirrors the mcp-oauth consent page); inline scripts are nonce-bound
- ASVS V16: decouple callback finalize work from the response stream
  (eager promise + next/server after()) so a client disconnect cannot
  drop session persistence or the consent_granted audit emit
- ISO 27001 A.8.15: failed audit-event emits log through the structured
  logger with a stable message for log-based alerting
- ASVS V2.3: recurring-invoice cron and run-now routes resolve
  isSandboxCompany themselves and pass an explicit suppressAutoSend flag
  (defence in depth around the email chokepoint, freeze-and-retain kept)
- ISO 27001 A.8.11: stagePendingOperation rejects plaintext
  personnummer-bearing keys in params/preview_data (key-based guard;
  EF org numbers make value-matching unsafe)
- ASVS V4.5: employee PATCH body is truly sparse; cleared number fields
  are omitted instead of resetting DB values to hardcoded fallbacks
- ASVS V8.2.1: route-level tests pin the v1 cross-company deny (404 by
  convention, not 403) on the payslip PDF endpoint

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat: implement vacation-year basis change validation and error handling

- Added tests to block vacation-year basis changes when open balances exist.
- Implemented error handling for open-balances guard query failures in the settings route.
- Enhanced absence route to reject reversed date ranges with a validation error.
- Updated absence handling to use atomic upserts instead of delete+insert for better performance and reliability.
- Refactored salary calculation logic to correctly handle age-based avgifter rates according to Skatteverket's rules.
- Improved error messaging for vacation year closure adjustments.
- Adjusted employee opening balances handling to preserve audit information during upserts.

* feat(settings): add validation to block vacation-year basis change with open balances

feat(absence): reject reversed date ranges in absence queries

fix(absence): update absence handling to use atomic upserts instead of delete+insert

fix(employee): improve validation for jamkning dates in employee updates

fix(opening-balances): ensure created_by field is preserved during upserts

test(absence): enhance tests for absence range and date validations

test(calculation): add tests for age-based avgifter rates and edge cases

test(semesterberedning): validate vacation year closure adjustments and error handling

test(employee-opening-balances): update tests to reflect changes in salary_run_employees schema

* fix(migrations): implement NOT VALID constraints for pending_operations and add validation migration

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-13 22:54:33 +02:00

307 lines
12 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
import { buildVatSettlementProposal } from '../vat-settlement'
// ============================================================
// Mock: fetchVatAccountTotals now goes through the
// get_vat_declaration_totals RPC (aggregation + settlement-shape detection
// in SQL, verified by tests/pg/vat-declaration-totals-rpc.pg.test.ts), so
// the mock seeds the RPC payload directly: per-account totals as the SQL
// GROUP BY returns them (already excluding settlement entries) plus the
// shaped entries the RPC surfaces. The existing-entries lookup and the
// fiscal-period resolution still go through from().
// ============================================================
interface MockData {
/** Per-account totals as returned by the RPC (post settlement-exclusion). */
totals?: Array<{ account_number: string; debit: number; credit: number }>
/** Settlement-shaped entries surfaced by the RPC. */
shaped?: Array<Record<string, unknown>>
/** Existing vat_settlement entries in the period. */
existing?: Array<Record<string, unknown>>
/** Error returned by the existing-settlement lookup. */
existingError?: { message: string }
/** fiscal_periods row for yearly (helårsmoms) bounds. */
fiscalPeriod?: { period_start: string; period_end: string } | null
}
let rpcCalls: Array<{ fn: string; params: Record<string, unknown> }>
function makeClient(data: MockData) {
rpcCalls = []
return {
rpc: vi.fn().mockImplementation(async (fn: string, params: Record<string, unknown>) => {
rpcCalls.push({ fn, params })
return {
data: {
totals: data.totals ?? [],
settlement_shaped_entries: data.shaped ?? [],
source_type_counts: {},
},
error: null,
}
}),
from: vi.fn().mockImplementation(() => {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
const b: Record<string, any> = {}
for (const m of ['select', 'eq', 'neq', 'in', 'gte', 'lte', 'order', 'range', 'limit']) {
b[m] = vi.fn().mockReturnValue(b)
}
b.maybeSingle = vi.fn().mockResolvedValue({ data: data.fiscalPeriod ?? null, error: null })
// The only awaited from() query left in the proposal builder is the
// tagged existing-settlement lookup.
b.then = (resolve: (v: unknown) => void) =>
resolve(
data.existingError
? { data: null, error: data.existingError }
: { data: data.existing ?? [], error: null },
)
return b
}),
// eslint-disable-next-line @typescript-eslint/no-explicit-any
} as any
}
function total(account_number: string, debit: number, credit: number) {
return { account_number, debit, credit }
}
beforeEach(() => {
vi.clearAllMocks()
})
describe('buildVatSettlementProposal', () => {
it('clears the 26xx accounts, books the filed whole-krona net on 2650 and the öre gap on 3740', async () => {
const supabase = makeClient({
totals: [
total('2611', 0, 2500.75),
total('2641', 1000.5, 0),
// Revenue feeds ruta05 but is never part of the settlement entry.
total('3001', 0, 10003.0),
],
})
const proposal = await buildVatSettlementProposal(supabase, 'company-1', 'quarterly', 2026, 1)
expect(proposal.period).toEqual({
type: 'quarterly', year: 2026, period: 1, start: '2026-01-01', end: '2026-03-31',
})
expect(proposal.entry_date).toBe('2026-03-31')
expect(proposal.description).toBe('Momsredovisning Kvartal 1 2026')
expect(proposal.is_empty).toBe(false)
// Filed net = trunc(2500.75) - trunc(1000.50) = 1500 (öretal faller bort)
expect(proposal.filed_net).toBe(1500)
expect(proposal.rounding_amount).toBe(0.25)
expect(proposal.lines).toEqual([
{ account_number: '2611', debit_amount: 2500.75, credit_amount: 0 },
{ account_number: '2641', debit_amount: 0, credit_amount: 1000.5 },
{
account_number: '2650', debit_amount: 0, credit_amount: 1500,
line_description: 'Moms att betala',
},
{
account_number: '3740', debit_amount: 0, credit_amount: 0.25,
line_description: 'Öres- och kronutjämning',
},
])
// The proposed entry always balances.
const debits = proposal.lines.reduce((s, l) => s + l.debit_amount, 0)
const credits = proposal.lines.reduce((s, l) => s + l.credit_amount, 0)
expect(debits).toBeCloseTo(credits, 2)
// The projection must ignore already-booked settlements, or booking once
// would change the next proposal: the RPC receives the settlement net
// accounts so it can shape-detect and exclude them.
expect(rpcCalls).toHaveLength(1)
expect(rpcCalls[0].fn).toBe('get_vat_declaration_totals')
expect(rpcCalls[0].params.p_net_accounts).toEqual(['2650', '1650'])
expect(rpcCalls[0].params.p_company_id).toBe('company-1')
})
it('books a refund period as a 1650 (Momsfordran) debit', async () => {
const supabase = makeClient({
totals: [
total('2611', 0, 100),
total('2641', 400, 0),
],
})
const proposal = await buildVatSettlementProposal(supabase, 'company-1', 'monthly', 2026, 6)
expect(proposal.filed_net).toBe(-300)
expect(proposal.rounding_amount).toBe(0)
expect(proposal.lines).toEqual([
{ account_number: '2611', debit_amount: 100, credit_amount: 0 },
{ account_number: '2641', debit_amount: 0, credit_amount: 400 },
{
account_number: '1650', debit_amount: 300, credit_amount: 0,
line_description: 'Moms att återfå',
},
])
})
it('clears an account sitting on the wrong side (credit-note-heavy period)', async () => {
const supabase = makeClient({
// Output VAT with a net DEBIT balance: credit notes exceeded sales.
totals: [total('2611', 50, 0)],
})
const proposal = await buildVatSettlementProposal(supabase, 'company-1', 'monthly', 2026, 2)
expect(proposal.filed_net).toBe(-50)
expect(proposal.lines).toEqual([
{ account_number: '2611', debit_amount: 0, credit_amount: 50 },
{
account_number: '1650', debit_amount: 50, credit_amount: 0,
line_description: 'Moms att återfå',
},
])
})
it('is empty when the period has no VAT-account activity (revenue alone does not settle)', async () => {
const supabase = makeClient({
totals: [total('3001', 0, 1000)],
})
const proposal = await buildVatSettlementProposal(supabase, 'company-1', 'quarterly', 2026, 2)
expect(proposal.is_empty).toBe(true)
expect(proposal.lines).toEqual([])
expect(proposal.filed_net).toBe(0)
})
it('uses the räkenskapsår bounds for yearly VAT when a fiscal period is supplied', async () => {
const supabase = makeClient({
totals: [total('2611', 0, 100), total('2641', 25, 0)],
fiscalPeriod: { period_start: '2025-07-01', period_end: '2026-06-30' },
})
const proposal = await buildVatSettlementProposal(
supabase, 'company-1', 'yearly', 2026, 1, { fiscalPeriodId: 'fp-1' },
)
expect(proposal.period.start).toBe('2025-07-01')
expect(proposal.period.end).toBe('2026-06-30')
expect(proposal.entry_date).toBe('2026-06-30')
expect(proposal.description).toBe('Momsredovisning Helår 2026')
})
it('surfaces existing vat_settlement entries in the period', async () => {
const existing = [{
id: 'je-1', status: 'posted', entry_date: '2026-03-31',
voucher_series: 'M', voucher_number: 3,
}]
const supabase = makeClient({
totals: [total('2611', 0, 100)],
existing,
})
const proposal = await buildVatSettlementProposal(supabase, 'company-1', 'quarterly', 2026, 1)
expect(proposal.existing_entries).toEqual(existing)
})
it('gates on a manual settlement-shaped entry and still proposes the full-period clear (#984)', async () => {
const manualSettlement = {
id: 'e2', status: 'posted', entry_date: '2026-03-31',
source_type: 'manual', voucher_series: 'A', voucher_number: 9,
}
const supabase = makeClient({
// The RPC already excluded the manual momsomföring from the totals
// (that exclusion is pg-tested); what reaches JS is the business
// activity plus the shaped entry to gate on.
totals: [
total('2611', 0, 100),
total('2641', 25, 0),
],
shaped: [manualSettlement],
})
const proposal = await buildVatSettlementProposal(supabase, 'company-1', 'quarterly', 2026, 1)
// The manual settlement is excluded from the projection: the proposal
// shows the same full-period clear the report shows, and the posted
// shaped entry gates the booking button via existing_entries.
expect(proposal.is_empty).toBe(false)
expect(proposal.filed_net).toBe(75)
expect(proposal.lines).toEqual([
{ account_number: '2611', debit_amount: 100, credit_amount: 0 },
{ account_number: '2641', debit_amount: 0, credit_amount: 25 },
{
account_number: '2650', debit_amount: 0, credit_amount: 75,
line_description: 'Moms att betala',
},
])
expect(proposal.existing_entries).toEqual([manualSettlement])
})
it('does not gate on a storno of a settlement (annullera must re-enable booking)', async () => {
const supabase = makeClient({
// Settlement + storno cancel out of the totals inside the RPC; both
// still come back as shaped entries. Neither may gate: the reversed
// manual settlement has no balance effect and the storno is the
// cancellation itself.
totals: [total('2611', 0, 100)],
shaped: [
{
id: 'e2', status: 'reversed', entry_date: '2026-03-31',
source_type: 'manual', voucher_series: 'A', voucher_number: 9,
},
{
id: 'e3', status: 'posted', entry_date: '2026-03-31',
source_type: 'storno', voucher_series: 'A', voucher_number: 10,
},
],
})
const proposal = await buildVatSettlementProposal(supabase, 'company-1', 'quarterly', 2026, 1)
expect(proposal.existing_entries).toEqual([])
expect(proposal.filed_net).toBe(100)
expect(proposal.lines).toEqual([
{ account_number: '2611', debit_amount: 100, credit_amount: 0 },
{
account_number: '2650', debit_amount: 0, credit_amount: 100,
line_description: 'Moms att betala',
},
])
})
it('ignores a plain VAT payment on 2650 (no declaration accounts touched)', async () => {
const supabase = makeClient({
// Paying last period's VAT debt: 2650 against the bank account. The
// entry touches a settlement net account but no declaration account,
// so the RPC does NOT shape it: its 2650 total comes back as-is and
// must neither gate nor shift the rutor / clearing lines.
totals: [
total('2611', 0, 100),
total('2650', 75, 0),
],
shaped: [],
})
const proposal = await buildVatSettlementProposal(supabase, 'company-1', 'quarterly', 2026, 1)
expect(proposal.existing_entries).toEqual([])
expect(proposal.filed_net).toBe(100)
expect(proposal.lines).toEqual([
{ account_number: '2611', debit_amount: 100, credit_amount: 0 },
{
account_number: '2650', debit_amount: 0, credit_amount: 100,
line_description: 'Moms att betala',
},
])
})
it('throws when the existing-settlement lookup fails (the UI gate depends on it)', async () => {
const supabase = makeClient({
totals: [total('2611', 0, 100)],
existingError: { message: 'boom' },
})
await expect(
buildVatSettlementProposal(supabase, 'company-1', 'quarterly', 2026, 1),
).rejects.toThrow('existing vat_settlement lookup failed: boom')
})
})