Jakob Wennberg
f55bfc478b
Cross-checked all 86 booking templates (26 packs + 60 static) against BAS 2026.
The pack catalogue is clean; the static registry had three defects, none of
which any existing check could see.
Two named accounts that do not exist in BAS 2026, so account-backfill.ts cannot
seed them and EVERY booking through them failed with AccountsNotInChartError:
vehicle_parking 5614 -> 5619 the BAS 561x run skips 5614; 5619 is the
sibling "Ovriga kostnader for personbilar"
it_cloud_hosting 5421 -> 5420 BAS has no 5421; both sibling SaaS templates
already use 5420 Programvaror
One that posted successfully to the wrong account, which is worse because
nothing complained:
travel_hotel 5820 -> 5830 5820 is Hyrbilskostnader. The Hotell template
filed hotel nights under car hire, balanced,
and looked fine. 5830 is "Kost och logi".
An existing test asserted the 5820 behaviour, so the bug was pinned as
expected output. That assertion now reads 5830 and carries the reason.
Adds template-accounts-exist.test.ts so the 5614 class cannot return: every
account any static template names must resolve in BAS 2026, account numbers
must be strings, and a VAT-bearing purchase may not debit equity or revenue.
That last check is deliberately narrow: class 1 is legitimate, equipment_capital
debits 1250 Inventarier and reclaims VAT, which is how capex is booked. Verified
the guard fails on 5614 and passes on 5619 rather than trusting it.
The pack catalogue already had this check via scripts/validate-packs.ts. The
static registry had nothing, which is how it drifted.
Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
75 lines
3.1 KiB
TypeScript
75 lines
3.1 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { BOOKING_TEMPLATES } from '@/lib/bookkeeping/booking-templates'
|
|
import { getBASReference } from '@/lib/bookkeeping/bas-reference'
|
|
|
|
/**
|
|
* Every account a booking template names must exist in BAS 2026.
|
|
*
|
|
* This is not pedantry: `lib/bookkeeping/account-backfill.ts` seeds a missing
|
|
* account into a company's chart on demand ONLY if it appears in
|
|
* BAS_REFERENCE. An account that does not is unreachable, so the template
|
|
* fails with AccountsNotInChartError every single time it is used, for every
|
|
* company. It is a template that can never work.
|
|
*
|
|
* Three shipped templates were in exactly that state until this test existed:
|
|
* vehicle_parking 5614 (the BAS 561x run skips 5614)
|
|
* it_cloud_hosting 5421 (BAS has 5420 Programvaror, no 5421)
|
|
* preliminar-f-skatt-ef 2012 (found separately by the pack validator)
|
|
*
|
|
* The pack catalogue gets this check from `scripts/validate-packs.ts`. The
|
|
* static registry had nothing, which is why it drifted.
|
|
*/
|
|
describe('BOOKING_TEMPLATES reference only real BAS accounts', () => {
|
|
const accountFields = ['debit_account', 'credit_account', 'debit_account_ab', 'credit_account_ab'] as const
|
|
|
|
it('every referenced account resolves in BAS 2026', () => {
|
|
const missing: string[] = []
|
|
|
|
for (const t of BOOKING_TEMPLATES) {
|
|
for (const field of accountFields) {
|
|
const account = (t as unknown as Record<string, string | undefined>)[field]
|
|
if (!account) continue
|
|
if (!getBASReference(account)) {
|
|
missing.push(`${t.id}.${field} = ${account}`)
|
|
}
|
|
}
|
|
}
|
|
|
|
expect(
|
|
missing,
|
|
`These templates name accounts that do not exist in BAS 2026, so account-backfill ` +
|
|
`cannot seed them and every booking through them fails:\n ${missing.join('\n ')}`,
|
|
).toEqual([])
|
|
})
|
|
|
|
it('account numbers are strings, never numbers', () => {
|
|
for (const t of BOOKING_TEMPLATES) {
|
|
for (const field of accountFields) {
|
|
const account = (t as unknown as Record<string, unknown>)[field]
|
|
if (account === undefined) continue
|
|
expect(typeof account, `${t.id}.${field}`).toBe('string')
|
|
}
|
|
}
|
|
})
|
|
|
|
it('a VAT-bearing purchase never debits equity or revenue', () => {
|
|
// Catches a transposed account number that happens to exist. Deliberately
|
|
// narrow: class 1 is legitimate here (equipment_capital debits 1250
|
|
// Inventarier and reclaims VAT, which is how capex is booked), and classes
|
|
// 4-7 are ordinary costs. What a purchase can never debit is class 2
|
|
// (equity and liabilities) or class 3 (revenue): those would be a sign
|
|
// error, not a categorisation choice.
|
|
const FORBIDDEN = new Set([2, 3])
|
|
|
|
for (const t of BOOKING_TEMPLATES) {
|
|
if (!t.vat_rate || t.direction !== 'expense') continue
|
|
const cls = Number(t.debit_account.charAt(0))
|
|
expect(
|
|
FORBIDDEN.has(cls),
|
|
`${t.id} charges VAT ${t.vat_rate} but debits ${t.debit_account} (class ${cls}): ` +
|
|
`a purchase cannot debit equity/liabilities or revenue`,
|
|
).toBe(false)
|
|
}
|
|
})
|
|
})
|