Jakob Wennberg
4dfd790de5
* feat(bookkeeping): Ny verifikat modal, ledger-style list, SIE no-underlag exemptions Verifikat UX - "Ny verifikat" opens in a modal (NewJournalEntryDialog) instead of an inline tab; the review step renders inline in the dialog rather than stacking a second dialog. - JournalEntryForm: konteringsrader are the focus, with a compact pre-filled metadata bar (datum/serie/text/valuta/period) on top; verifikationstext auto-fills from the first row's account. - JournalEntryList: belopp shown on collapsed rows; expanded view is an aligned Konto/Benämning/Debet/Kredit table. SIE imports no longer flood "Att hantera: saknade underlag" - Import gains an opt-in (off by default) toggle to mark imported verifikat as "Inget underlag krävs"; a "Rekommenderas vid migrering" badge nudges it for historical years. - Multi-select batch-mark in the list for selective cleanup. - Filter-scoped bulk mark (POST /api/bookkeeping/no-doc-required/bulk-missing): marks every missing-doc verifikat matching the active filters across all pages, with a dry_run count to confirm scope — the scalable remedy for a post-import flood. - Shared helper markEntriesNoDocRequired + per-entry batch route. Tests: no-doc helper, batch route, bulk-missing route. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(bookkeeping): address PR #698 review findings - JournalEntryForm: restore the explicit "no underlag" acknowledgement in the modal's inline review. When no document is attached, the confirm button reads "Bokför utan underlag" (BFL 5 kap 6-7 §§), equivalent to the blocking dialog the non-bare flow shows — the bare path no longer posts behind only a passive banner. - batch no-doc route: guard the ownership query with source_type IN NEEDS_DOC_SOURCE_TYPES so a crafted request can't exempt non-document-requiring entries (defense in depth on top of company + posted scoping). - bulk-missing route: resolve doc/exemption status by querying only the candidate ids (chunked) instead of loading the company's full document_attachments and journal_entry_no_doc_required tables into memory — data minimisation + bounded memory for large migrations (the most-repeated reviewer finding). Triaged as non-issues (left as-is): partial-import exemption (gated on result.success == zero errors), reason write-back (sidecar row is FK-linked and carries the reason), and "bulk-exempting manual entries" (consistent with the existing per-entry NoDocRequiredToggle). No DB migration — reuses the existing journal_entry_no_doc_required table. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * fix(bookkeeping): centralize bulk-missing date/series validation in Zod Move the ISO-date and verifikationsserie format checks into the Zod schema so malformed input is rejected with a clean 400 instead of being silently nulled (or, for a shaped-but-invalid date, throwing a 500 via fetchAllRows). The date refinement rejects values like 9999-99-99 / 2026-02-30 that a bare /^\d{4}-\d{2}-\d{2}$/ regex lets through. Addresses the PR #698 reviewer nit on split schema-vs-runtime validation. +2 route tests. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
61 lines
2.6 KiB
TypeScript
61 lines
2.6 KiB
TypeScript
import { describe, it, expect, vi } from 'vitest'
|
|
import { markEntriesNoDocRequired } from '@/lib/bookkeeping/no-doc-required'
|
|
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
|
|
function makeMock() {
|
|
const upsert = vi.fn().mockResolvedValue({ error: null })
|
|
const from = vi.fn().mockReturnValue({ upsert })
|
|
return { supabase: { from } as unknown as SupabaseClient, upsert, from }
|
|
}
|
|
|
|
describe('markEntriesNoDocRequired', () => {
|
|
it('writes nothing and returns 0 for an empty list', async () => {
|
|
const { supabase, from } = makeMock()
|
|
const n = await markEntriesNoDocRequired(supabase, 'c1', 'u1', [], null)
|
|
expect(n).toBe(0)
|
|
expect(from).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('inserts one chunk with the right rows, reason and conflict options', async () => {
|
|
const { supabase, upsert, from } = makeMock()
|
|
const n = await markEntriesNoDocRequired(supabase, 'c1', 'u1', ['a', 'b'], 'Importerad')
|
|
expect(n).toBe(2)
|
|
expect(from).toHaveBeenCalledWith('journal_entry_no_doc_required')
|
|
expect(upsert).toHaveBeenCalledTimes(1)
|
|
const [rows, opts] = upsert.mock.calls[0]
|
|
expect(rows).toEqual([
|
|
{ journal_entry_id: 'a', company_id: 'c1', user_id: 'u1', reason: 'Importerad' },
|
|
{ journal_entry_id: 'b', company_id: 'c1', user_id: 'u1', reason: 'Importerad' },
|
|
])
|
|
expect(opts).toEqual({ onConflict: 'journal_entry_id', ignoreDuplicates: true })
|
|
})
|
|
|
|
it('de-dupes ids and defaults reason to null', async () => {
|
|
const { supabase, upsert } = makeMock()
|
|
const n = await markEntriesNoDocRequired(supabase, 'c1', 'u1', ['a', 'a', 'b'], null)
|
|
expect(n).toBe(2)
|
|
const [rows] = upsert.mock.calls[0]
|
|
expect(rows.map((r: { journal_entry_id: string }) => r.journal_entry_id)).toEqual(['a', 'b'])
|
|
expect(rows[0].reason).toBeNull()
|
|
})
|
|
|
|
it('chunks large id lists into batches of 500', async () => {
|
|
const { supabase, upsert } = makeMock()
|
|
const ids = Array.from({ length: 1200 }, (_, i) => `id-${i}`)
|
|
const n = await markEntriesNoDocRequired(supabase, 'c1', 'u1', ids, null)
|
|
expect(n).toBe(1200)
|
|
expect(upsert).toHaveBeenCalledTimes(3) // 500 + 500 + 200
|
|
expect(upsert.mock.calls[0][0]).toHaveLength(500)
|
|
expect(upsert.mock.calls[1][0]).toHaveLength(500)
|
|
expect(upsert.mock.calls[2][0]).toHaveLength(200)
|
|
})
|
|
|
|
it('throws when an upsert errors', async () => {
|
|
const upsert = vi.fn().mockResolvedValue({ error: { message: 'boom' } })
|
|
const supabase = { from: vi.fn().mockReturnValue({ upsert }) } as unknown as SupabaseClient
|
|
await expect(
|
|
markEntriesNoDocRequired(supabase, 'c1', 'u1', ['a'], null),
|
|
).rejects.toThrow('boom')
|
|
})
|
|
})
|