Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
39 lines
1.3 KiB
TypeScript
39 lines
1.3 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { classifyAccount } from '../account-classifier'
|
|
|
|
describe('classifyAccount: BAS-known accounts delegate to bas-reference', () => {
|
|
it.each([
|
|
['1930', 'asset', 'debit'],
|
|
['2110', 'untaxed_reserves', 'credit'],
|
|
['2440', 'liability', 'credit'],
|
|
['3001', 'revenue', 'credit'],
|
|
['8016', 'revenue', 'credit'],
|
|
['8310', 'revenue', 'credit'],
|
|
['8420', 'expense', 'debit'],
|
|
['8811', 'revenue', 'debit'],
|
|
['8910', 'expense', 'debit'],
|
|
] as const)('%s -> %s/%s', (num, type, balance) => {
|
|
expect(classifyAccount(num)).toEqual({ account_type: type, normal_balance: balance })
|
|
})
|
|
})
|
|
|
|
describe('classifyAccount: non-BAS accounts use heuristic fallback', () => {
|
|
it.each([
|
|
['1355', 'asset', 'debit'],
|
|
['2199', 'untaxed_reserves', 'credit'],
|
|
['2999', 'liability', 'credit'],
|
|
['3099', 'revenue', 'credit'],
|
|
['4995', 'expense', 'debit'],
|
|
['7095', 'expense', 'debit'],
|
|
['8015', 'revenue', 'credit'],
|
|
['8025', 'revenue', 'credit'],
|
|
['8195', 'revenue', 'credit'],
|
|
['8213', 'revenue', 'credit'],
|
|
['8499', 'expense', 'debit'],
|
|
['8895', 'revenue', 'credit'],
|
|
['8995', 'expense', 'debit'],
|
|
] as const)('%s -> %s/%s', (num, type, balance) => {
|
|
expect(classifyAccount(num)).toEqual({ account_type: type, normal_balance: balance })
|
|
})
|
|
})
|