Files
accounted/lib/agent/intents/__tests__/route-mapping.test.ts
T
Jakob Wennberg bcbe9b0903 feat(assistant): say what the conversation is anchored to (#1222)
* feat(assistant): say what the conversation is anchored to

agent_conversations.context_ref has been written since the first intents
shipped and read by nothing. The panel ignored it, so a thread resumed three
days later showed the messages with no indication of which invoice or which
bokslut it concerned, even though the row knew. /chat did worse: it printed the
ref raw, so the subtitle under someone's own conversation read
"invoice:5f3a-9c21-...", a database identifier shown to an accountant.

Both surfaces now render the same chip, which names the thing and links to it.
This matters more since the panel docks: sitting beside the page, "what is this
about" is a question the surface should answer rather than the user's memory.

The mapping is a data map in route-mapping.ts, not a switch in a component
(plan seam 8.5), so a flow run's ref renders in both surfaces with no change to
either. A ref it cannot read renders nothing rather than a broken chip.

Two refs deliberately have no link. There is no /transactions/[id] route, so a
transaction chip points at the list. The document inbox is an extension mounted
under /e/[sector], and core must not hardcode a path that exists only when the
extension is enabled, so that one is named without being linked.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

* fix(assistant): review triage: make the colon test observable, drop an overclaim

The colon-splitting test asserted on a kpi ref, and kpi discards its id, so it
passed even with a parser that dropped everything after the second colon. Moved
to invoice:abc:2026, where the id reaches the href. Verified by switching
indexOf to lastIndexOf and confirming the test fails.

ContextChip's comment said a flow run's ref renders with no change to either
surface. It does not: an unknown kind maps to null and renders nothing until
the map gains an entry. The seam is that adding one is a single entry in one
file, which is what the comment now says.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
2026-07-27 11:26:16 +02:00

175 lines
7.1 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import { routeToIntent, contextRefToTarget } from '../route-mapping'
describe('routeToIntent', () => {
it('falls back to general.help when pathname is null/undefined/empty', () => {
for (const input of [null, undefined, '']) {
const out = routeToIntent(input as string | null | undefined)
expect(out.intentId).toBe('general.help')
expect(out.labelSuffix).toBeNull()
}
})
it('routes the root and list pages to general.help', () => {
for (const route of ['/', '/transactions', '/invoices', '/customers', '/reports']) {
const out = routeToIntent(route)
expect(out.intentId).toBe('general.help')
expect(out.intentArgs.route).toBe(route)
expect(out.labelSuffix).toBeNull()
expect(out.contextRef).toBeUndefined()
}
})
it('routes /invoices/new to invoice.draft without an id', () => {
const out = routeToIntent('/invoices/new')
expect(out.intentId).toBe('invoice.draft')
expect(out.intentArgs).toEqual({})
expect(out.contextRef).toBeUndefined()
expect(out.labelSuffix).toBe('om denna faktura')
})
it('routes /invoices/[id] to invoice.draft with the id', () => {
const out = routeToIntent('/invoices/abc-123')
expect(out.intentId).toBe('invoice.draft')
expect(out.intentArgs).toEqual({ invoice_id: 'abc-123' })
expect(out.contextRef).toBe('invoice:abc-123')
expect(out.labelSuffix).toBe('om denna faktura')
})
it('routes /invoices/[id]/credit to invoice.draft with the parent id', () => {
// The credit-note form is still an invoice context: same intent, same
// captured entity. The :credit suffix isn't its own intent.
const out = routeToIntent('/invoices/abc-123/credit')
expect(out.intentId).toBe('invoice.draft')
expect(out.intentArgs).toEqual({ invoice_id: 'abc-123' })
expect(out.contextRef).toBe('invoice:abc-123')
})
it('routes /supplier-invoices/[id] to supplier_invoice.review', () => {
const out = routeToIntent('/supplier-invoices/sup-1')
expect(out.intentId).toBe('supplier_invoice.review')
expect(out.intentArgs).toEqual({ supplier_invoice_id: 'sup-1' })
expect(out.contextRef).toBe('supplier_invoice:sup-1')
expect(out.labelSuffix).toBe('om denna leverantörsfaktura')
})
it('does NOT route /supplier-invoices/new to supplier_invoice.review (no entity yet)', () => {
// There's no invoice to review yet: fall through so the Opus intent
// doesn't fire on an empty capture.
const out = routeToIntent('/supplier-invoices/new')
expect(out.intentId).toBe('general.help')
})
it('falls through /bookkeeping/[id] to general.help (FAB is suppressed on the verifikation editor)', () => {
// The verifikation editor is a dense regulatory surface; AgentTrigger
// hides the FAB on /bookkeeping/[id] entirely. routeToIntent still
// returns a sensible default in case anything else queries it.
const out = routeToIntent('/bookkeeping/je-7')
expect(out.intentId).toBe('general.help')
expect(out.intentArgs).toEqual({ route: '/bookkeeping/je-7' })
expect(out.labelSuffix).toBeNull()
expect(out.contextRef).toBeUndefined()
})
it('routes /bookkeeping/year-end to bokslut.step (matches the page button: no two-agents-on-one-page)', () => {
const out = routeToIntent('/bookkeeping/year-end')
expect(out.intentId).toBe('bokslut.step')
expect(out.intentArgs).toEqual({ step_id: null })
expect(out.contextRef).toBe('bokslut:overview')
expect(out.labelSuffix).toBe('om bokslutet')
})
it('routes /kpi to kpi.explain (matches the page button)', () => {
const out = routeToIntent('/kpi')
expect(out.intentId).toBe('kpi.explain')
expect(out.intentArgs).toEqual({ kpi_key: 'översikt' })
expect(out.contextRef).toBe('kpi:översikt')
expect(out.labelSuffix).toBe('om nyckeltalen')
})
it('does NOT route bare /bookkeeping list page to verifikation.draft', () => {
const out = routeToIntent('/bookkeeping')
expect(out.intentId).toBe('general.help')
})
it('routes /settings/<panel> to settings.help with the panel slug', () => {
const out = routeToIntent('/settings/invoicing')
expect(out.intentId).toBe('settings.help')
expect(out.intentArgs).toEqual({ panel: 'invoicing' })
expect(out.labelSuffix).toBeNull()
})
it('takes the first segment after /settings as the panel slug (ignores deeper paths)', () => {
const out = routeToIntent('/settings/invoicing/templates/new')
expect(out.intentId).toBe('settings.help')
expect(out.intentArgs).toEqual({ panel: 'invoicing' })
})
it('routes bare /settings without a panel slug to general.help', () => {
const out = routeToIntent('/settings')
expect(out.intentId).toBe('general.help')
})
})
describe('contextRefToTarget', () => {
/**
* Every shape the app actually writes. Collected by grepping the call sites
* rather than invented, so a new intent that writes a ref this cannot read
* shows up as a chip that never renders, not as a wrong link.
*/
it('resolves each ref the app writes today', () => {
expect(contextRefToTarget('invoice:abc-123')).toEqual({
label: 'Faktura',
href: '/invoices/abc-123',
})
expect(contextRefToTarget('supplier_invoice:abc-123')).toEqual({
label: 'Leverantörsfaktura',
href: '/supplier-invoices/abc-123',
})
expect(contextRefToTarget('transaction:abc-123')).toEqual({
label: 'Transaktion',
href: '/transactions',
})
expect(contextRefToTarget('verifikation:new')).toEqual({
label: 'Verifikation',
href: '/bookkeeping',
})
expect(contextRefToTarget('bokslut:overview')).toEqual({
label: 'Bokslut',
href: '/bookkeeping/year-end',
})
expect(contextRefToTarget('kpi:översikt')).toEqual({ label: 'Nyckeltal', href: '/kpi' })
})
it('names the document inbox without linking it', () => {
// It is an extension route under /e/[sector]; core cannot hardcode a path
// that only exists when the extension is enabled.
expect(contextRefToTarget('inbox:bulk')).toEqual({
label: 'Dokumentinkorgen',
href: null,
})
})
it('returns nothing rather than a broken chip for refs it cannot read', () => {
expect(contextRefToTarget(null)).toBeNull()
expect(contextRefToTarget(undefined)).toBeNull()
expect(contextRefToTarget('')).toBeNull()
expect(contextRefToTarget('invoice')).toBeNull()
expect(contextRefToTarget('invoice:')).toBeNull()
expect(contextRefToTarget(':abc')).toBeNull()
expect(contextRefToTarget('flow_run:abc')).toBeNull()
})
it('keeps ids that need escaping out of the path', () => {
// Ids reach this from the database, not from the router.
expect(contextRefToTarget('invoice:a b/c')?.href).toBe('/invoices/a%20b%2Fc')
})
it('keeps the id intact when it contains a colon', () => {
// Split on the FIRST colon. Asserted on a kind that PUTS the id in the
// href: kpi discards its id, so the same assertion there would pass even
// if the parser dropped everything after the second colon.
expect(contextRefToTarget('invoice:abc:2026')?.href).toBe('/invoices/abc%3A2026')
})
})