5d7952a01e
* feat(mcp): model-free document upload via signed URL (#748) Adds gnubok_create_document_upload + gnubok_complete_document_upload so document bytes reach storage through a short-lived signed PUT URL and never pass through the model context. Fixes silent base64 corruption on real-size PDFs and the context blowup on batch uploads. - pending/ staage keys with TTL cleanup; completion validates magic bytes + SHA-256, moves bytes to the WORM key and adopts the reserved UUID as document id, making retries and concurrent completions idempotent - legacy gnubok_upload_document kept for clients without file access, description now points to the signed-URL pair; shared mime resolution and inbox-item creation extracted - both new tools mapped in TOOL_SCOPE_MAP (transactions:write) and MCP_TOOL_CAPABILITY_MAP (ai) so the paywall and scope gates hold - payload guard ceiling 58.5K to 59K after trimming the create tool's outputSchema to upload_id/upload_url/expires_at Fixes #748 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(mcp): satisfy capability-map lock and phantom-column scanner The exact-entries lock in capability-maps.test.ts now includes the signed-URL pair as dispatch-only AI tools, and the inbox insert uses a literal payload (explicit UUID instead of a conditional spread) so the no-phantom-columns scanner can resolve every column. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
175 lines
5.9 KiB
TypeScript
175 lines
5.9 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { makeDocumentAttachment } from '@/tests/helpers'
|
|
import { TOOL_SCOPE_MAP } from '@/lib/auth/api-keys'
|
|
import { MCP_TOOL_CAPABILITY_MAP } from '@/lib/entitlements/keys'
|
|
|
|
const mocks = vi.hoisted(() => ({
|
|
createPendingDocumentUpload: vi.fn(),
|
|
completePendingDocumentUpload: vi.fn(),
|
|
extractInvoiceFields: vi.fn(),
|
|
}))
|
|
|
|
vi.mock('@/lib/core/documents/document-service', async (importOriginal) => {
|
|
const actual = await importOriginal<typeof import('@/lib/core/documents/document-service')>()
|
|
return {
|
|
...actual,
|
|
createPendingDocumentUpload: mocks.createPendingDocumentUpload,
|
|
completePendingDocumentUpload: mocks.completePendingDocumentUpload,
|
|
}
|
|
})
|
|
|
|
vi.mock('@/extensions/general/invoice-inbox/lib/extract-invoice-fields', async (importOriginal) => {
|
|
const actual = await importOriginal<
|
|
typeof import('@/extensions/general/invoice-inbox/lib/extract-invoice-fields')
|
|
>()
|
|
return { ...actual, extractInvoiceFields: mocks.extractInvoiceFields }
|
|
})
|
|
|
|
import { tools } from '../server'
|
|
|
|
const companyId = '11111111-1111-4111-8111-111111111111'
|
|
const userId = '22222222-2222-4222-8222-222222222222'
|
|
const uploadId = '33333333-3333-4333-8333-333333333333'
|
|
|
|
function findTool(name: string) {
|
|
const tool = tools.find((candidate) => candidate.name === name)
|
|
if (!tool) throw new Error(`Tool not found: ${name}`)
|
|
return tool
|
|
}
|
|
|
|
function makeQueryBuilder(result: { data: unknown; error: unknown }) {
|
|
const builder: Record<string, unknown> = {}
|
|
for (const method of ['select', 'eq', 'limit', 'insert']) {
|
|
builder[method] = vi.fn().mockReturnValue(builder)
|
|
}
|
|
builder.maybeSingle = vi.fn().mockResolvedValue(result)
|
|
builder.single = vi.fn().mockResolvedValue(result)
|
|
return builder
|
|
}
|
|
|
|
describe('MCP model-free document upload tools', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
mocks.createPendingDocumentUpload.mockResolvedValue({
|
|
uploadId,
|
|
signedUrl: 'https://storage.example/upload?token=signed',
|
|
expiresAt: '2026-08-03T12:00:00.000Z',
|
|
})
|
|
mocks.completePendingDocumentUpload.mockResolvedValue({
|
|
document: makeDocumentAttachment({
|
|
id: uploadId,
|
|
user_id: userId,
|
|
company_id: companyId,
|
|
file_name: 'invoice.pdf',
|
|
mime_type: 'application/pdf',
|
|
}),
|
|
buffer: new TextEncoder().encode('%PDF-1.4\n%%EOF\n').buffer,
|
|
})
|
|
mocks.extractInvoiceFields.mockResolvedValue({
|
|
data: {
|
|
supplier: { name: 'Synthetic Supplier AB', orgNumber: null },
|
|
invoice: { number: 'INV-1' },
|
|
},
|
|
})
|
|
})
|
|
|
|
it('returns an unauthenticated PUT URL without accepting file bytes', async () => {
|
|
const tool = findTool('gnubok_create_document_upload')
|
|
const result = await tool.execute(
|
|
{ file_name: 'invoice.pdf' },
|
|
companyId,
|
|
userId,
|
|
{} as never,
|
|
)
|
|
|
|
expect(mocks.createPendingDocumentUpload).toHaveBeenCalledWith(
|
|
expect.anything(),
|
|
companyId,
|
|
userId,
|
|
expect.stringMatching(/^[0-9a-f-]{36}$/),
|
|
'invoice.pdf',
|
|
)
|
|
expect(result).toEqual({
|
|
upload_id: uploadId,
|
|
upload_url: 'https://storage.example/upload?token=signed',
|
|
expires_at: '2026-08-03T12:00:00.000Z',
|
|
})
|
|
const schema = tool.inputSchema as { properties: Record<string, unknown> }
|
|
expect(schema.properties).not.toHaveProperty('file_content_base64')
|
|
})
|
|
|
|
it('completes the reserved upload and uses the upload UUID for both records', async () => {
|
|
const inboxInsert = makeQueryBuilder({ data: { id: uploadId, status: 'received' }, error: null })
|
|
const invoiceLookups = [
|
|
makeQueryBuilder({ data: null, error: null }),
|
|
makeQueryBuilder({ data: null, error: null }),
|
|
inboxInsert,
|
|
]
|
|
const supplier = makeQueryBuilder({ data: null, error: null })
|
|
const from = vi.fn((table: string) => {
|
|
if (table === 'invoice_inbox_items') return invoiceLookups.shift()
|
|
if (table === 'suppliers') return supplier
|
|
throw new Error(`Unexpected table: ${table}`)
|
|
})
|
|
|
|
const result = await findTool('gnubok_complete_document_upload').execute(
|
|
{ upload_id: uploadId, file_name: 'invoice.pdf', mime_type: 'application/pdf' },
|
|
companyId,
|
|
userId,
|
|
{ from } as never,
|
|
)
|
|
|
|
expect(mocks.completePendingDocumentUpload).toHaveBeenCalledWith(
|
|
expect.anything(),
|
|
companyId,
|
|
userId,
|
|
uploadId,
|
|
'invoice.pdf',
|
|
'application/pdf',
|
|
)
|
|
expect(inboxInsert.insert).toHaveBeenCalledWith(
|
|
expect.objectContaining({ id: uploadId, document_id: uploadId }),
|
|
)
|
|
expect(result).toMatchObject({
|
|
document_id: uploadId,
|
|
inbox_item_id: uploadId,
|
|
status: 'received',
|
|
})
|
|
expect(mocks.extractInvoiceFields).toHaveBeenCalledOnce()
|
|
})
|
|
|
|
it('returns an already completed inbox item without downloading or extracting again', async () => {
|
|
const existing = makeQueryBuilder({
|
|
data: {
|
|
id: uploadId,
|
|
document_id: uploadId,
|
|
status: 'received',
|
|
extracted_data: { invoice: { number: 'INV-1' } },
|
|
matched_supplier_id: null,
|
|
},
|
|
error: null,
|
|
})
|
|
const result = await findTool('gnubok_complete_document_upload').execute(
|
|
{ upload_id: uploadId, file_name: 'invoice.pdf', mime_type: 'application/pdf' },
|
|
companyId,
|
|
userId,
|
|
{ from: vi.fn().mockReturnValue(existing) } as never,
|
|
)
|
|
|
|
expect(result).toMatchObject({ document_id: uploadId, inbox_item_id: uploadId })
|
|
expect(mocks.completePendingDocumentUpload).not.toHaveBeenCalled()
|
|
expect(mocks.extractInvoiceFields).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('keeps scope and AI capability gates aligned across all upload paths', () => {
|
|
for (const name of [
|
|
'gnubok_create_document_upload',
|
|
'gnubok_complete_document_upload',
|
|
'gnubok_upload_document',
|
|
]) {
|
|
expect(TOOL_SCOPE_MAP[name]).toBe('transactions:write')
|
|
expect(MCP_TOOL_CAPABILITY_MAP[name]).toBe('ai')
|
|
}
|
|
})
|
|
})
|