Jakob Wennberg
3e1ea29d02
Multi-step executors (match_transaction_invoice, credit_invoice) post an irreversible voucher or persist a credit note and then run later fallible steps. A failure there previously marked the whole op status=rejected, hiding the posted entity and its id from operators. - new migration 20260722134114: add failed_partial to the pending_operations status CHECK and treat it as terminal in both immutability triggers (immutable, undeletable, never re-claimable) - PartialCommitError + ExecutorResult.partialPostedIds carry the posted ids; the dispatcher writes status=failed_partial with result_data.posted_ids and returns code=partial_commit - instrument only the two named executors; hoist the read-only settlement-account resolution above the storno in the match executor - consumer sweep: status union + query schema widened, failed_partial folds into the Avvisade tab with a badge and posted-ids detail line, bulk/reject routes and MCP tools message it explicitly, worklist and expiry sweep intentionally untouched (not pending work) - tests: pg-real coverage for the new terminal semantics, dispatcher unit tests for both partial paths plus byte-for-byte regression guards Fixes #842 Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
77 lines
3.2 KiB
TypeScript
77 lines
3.2 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { validateQuery } from '@/lib/api/validate'
|
|
import { PendingOperationsQuerySchema } from '@/lib/api/schemas'
|
|
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
|
|
|
|
/**
|
|
* GET /api/pending-operations
|
|
*
|
|
* List pending operations for the authenticated user.
|
|
* Query params: status (default: pending), limit, offset
|
|
*/
|
|
export const GET = withRouteContext(
|
|
'pending_operation.list',
|
|
async (request, { supabase, companyId }) => {
|
|
const result = validateQuery(request, PendingOperationsQuerySchema)
|
|
if (!result.success) return result.response
|
|
const { status, limit, offset } = result.data
|
|
|
|
// Terminal tabs (Godkända/Avvisade) order by when the op was RESOLVED, not
|
|
// created: auto-expired ops are ≥30 days old by construction, so a
|
|
// created_at ordering would bury a fresh expiry sweep below a month of
|
|
// newer rejections and the "Utgick automatiskt" context would never be seen.
|
|
const orderColumn = status === 'pending' ? 'created_at' : 'resolved_at'
|
|
|
|
// 'failed_partial' rows (issue #842: op failed AFTER posting an
|
|
// irreversible voucher) surface inside the Avvisade tab rather than a
|
|
// fourth tab: they are resolved-with-failure and must stay visible to the
|
|
// operator, but a dedicated tab for a rare state would bury it. A direct
|
|
// ?status=failed_partial query still returns only those rows.
|
|
const statusesFor = (candidate: string): string[] =>
|
|
candidate === 'rejected' ? ['rejected', 'failed_partial'] : [candidate]
|
|
|
|
const listPromise = supabase
|
|
.from('pending_operations')
|
|
.select('*', { count: 'exact' })
|
|
.eq('company_id', companyId)
|
|
.in('status', statusesFor(status))
|
|
.order(orderColumn, { ascending: false, nullsFirst: false })
|
|
.range(offset, offset + limit - 1)
|
|
|
|
// Return every tab count with the active list. The browser previously
|
|
// called this authenticated route four times, repeating auth and company
|
|
// resolution for one list plus three counters. The active list already
|
|
// supplies its own exact count, so only the other two lightweight head
|
|
// queries are needed here.
|
|
const statuses = ['pending', 'committed', 'rejected'] as const
|
|
const otherStatuses = statuses.filter((candidate) => candidate !== status)
|
|
const [listResult, ...otherCountResults] = await Promise.all([
|
|
listPromise,
|
|
...otherStatuses.map((candidate) =>
|
|
supabase
|
|
.from('pending_operations')
|
|
.select('id', { count: 'exact', head: true })
|
|
.eq('company_id', companyId)
|
|
.in('status', statusesFor(candidate)),
|
|
),
|
|
])
|
|
|
|
const { data, error, count } = listResult
|
|
|
|
if (error) {
|
|
return NextResponse.json({ error: getUserErrorMessage(error) }, { status: 500 })
|
|
}
|
|
|
|
const counts: Partial<Record<(typeof statuses)[number] | 'failed_partial', number>> = {
|
|
[status]: count ?? 0,
|
|
}
|
|
otherStatuses.forEach((candidate, index) => {
|
|
const result = otherCountResults[index]
|
|
if (!result.error) counts[candidate] = result.count ?? 0
|
|
})
|
|
|
|
return NextResponse.json({ data: data ?? [], count, counts })
|
|
},
|
|
)
|