* feat(customers): carry contact person and invoice copy recipients through migration Extends the arcim-migration entity mapper, Fortnox provider mapper, canonical DTOs, customer APIs (web + v1) and invoice send flows so contact person and customer-level invoice CC/BCC addresses survive provider migrations. NULL means unconfigured and empty means an explicit clear, so re-syncs enrich legacy gaps without resurrecting deliberately removed values. Fortnox fixed assets are split into a dedicated follow-up issue. Fixes #1345 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore(db): bump customer metadata migration past pack-slug version Main already contains 20260803230000; keep new versions strictly newest so Supabase branching applies them in order. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(customers): complete Customer type consumers and make enrichment payload resolvable The preview-pdf mock customer and the makeCustomer fixture now carry the three new metadata fields, fixing the type-check failure in Build (zero extensions) and Vercel. The enrichment update in the migration orchestrator now spells its payload as an object literal typed CustomerMetadataEnrichment (absent keys drop at serialization), so the phantom-column guard resolves the columns instead of counting another unresolvable dynamic payload past its ceiling. The cc/bcc guards also verify element types instead of casting. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
224 lines
9.0 KiB
TypeScript
224 lines
9.0 KiB
TypeScript
import { NextResponse } from 'next/server'
|
|
import { validateBody } from '@/lib/api/validate'
|
|
import { UpdateCustomerSchema } from '@/lib/api/schemas'
|
|
import { validateVatNumber } from '@/lib/vat/vies-client'
|
|
import { withRouteContext } from '@/lib/api/with-route-context'
|
|
import { errorResponseFromCode } from '@/lib/errors/get-structured-error'
|
|
import { encryptCustomerPersonalNumber, maskCustomerRow } from '@/lib/customers/protect-personal-number'
|
|
import { isMaskedPersonalNumber } from '@/lib/customers/mask-personal-number'
|
|
import { getErrorMessage as getUserErrorMessage } from '@/lib/errors/get-error-message'
|
|
|
|
export const GET = withRouteContext(
|
|
'customer.get',
|
|
async (_request, ctx, { params }: { params: Promise<{ id: string }> }) => {
|
|
const { id } = await params
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
const opLog = log.child({ customerId: id })
|
|
|
|
const { data, error } = await supabase
|
|
.from('customers')
|
|
.select('*')
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.single()
|
|
|
|
if (error) {
|
|
if (error.code === 'PGRST116') {
|
|
return errorResponseFromCode('CUSTOMER_NOT_FOUND', opLog, { requestId })
|
|
}
|
|
opLog.error('customer fetch failed', error)
|
|
return errorResponseFromCode('INTERNAL_ERROR', opLog, {
|
|
requestId,
|
|
details: { reason: getUserErrorMessage(error) },
|
|
})
|
|
}
|
|
|
|
const { data: invoices } = await supabase
|
|
.from('invoices')
|
|
.select('id, invoice_number, invoice_date, due_date, status, total, currency')
|
|
.eq('customer_id', id)
|
|
.eq('company_id', companyId)
|
|
.order('invoice_date', { ascending: false })
|
|
|
|
return NextResponse.json({ data: { ...maskCustomerRow(data), invoices: invoices || [] } })
|
|
},
|
|
)
|
|
|
|
export const PATCH = withRouteContext(
|
|
'customer.update',
|
|
async (request, ctx, { params }: { params: Promise<{ id: string }> }) => {
|
|
const { id } = await params
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
const opLog = log.child({ customerId: id })
|
|
|
|
const result = await validateBody(request, UpdateCustomerSchema, {
|
|
log: opLog,
|
|
operation: 'customer.update',
|
|
})
|
|
if (!result.success) return result.response
|
|
const body = result.data
|
|
|
|
const { data: existing, error: existingError } = await supabase
|
|
.from('customers')
|
|
.select('id, customer_type')
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.single()
|
|
|
|
if (existingError || !existing) {
|
|
if (existingError?.code === 'PGRST116') {
|
|
return errorResponseFromCode('CUSTOMER_NOT_FOUND', opLog, { requestId })
|
|
}
|
|
opLog.error('customer lookup before update failed', existingError)
|
|
return errorResponseFromCode('CUSTOMER_UPDATE_FAILED', opLog, { requestId })
|
|
}
|
|
|
|
// No ordinary read returns the stored personnummer, only '********-1234',
|
|
// or '********-????' when the stored value could not be decrypted. A
|
|
// client that PATCHes back a customer it just read therefore submits one
|
|
// of those, and it counts as "field not supplied": it carries no new
|
|
// value, so it must not be validated, stored or treated as a clear.
|
|
// CustomerForm strips it before sending, but the guard belongs here too:
|
|
// any other client (script, agent, future UI) that skips it would
|
|
// otherwise destroy the value.
|
|
//
|
|
// Both forms are recognized via lib/customers/mask-personal-number.ts so
|
|
// this route, UpdateCustomerSchema and the form cannot disagree about what
|
|
// counts as a mask. They previously each carried their own '-1234'-only
|
|
// copy, which made an undecryptable row uneditable in every field, not
|
|
// just this one.
|
|
const personalNumberSubmitted =
|
|
body.personal_number !== undefined && !isMaskedPersonalNumber(body.personal_number)
|
|
|
|
const effectiveType = body.customer_type ?? existing.customer_type
|
|
if (personalNumberSubmitted && body.personal_number && effectiveType !== 'individual') {
|
|
return errorResponseFromCode('CUSTOMER_PERSONAL_NUMBER_NOT_ALLOWED', opLog, { requestId })
|
|
}
|
|
|
|
const updateData: Record<string, unknown> = {}
|
|
if (body.name !== undefined) updateData.name = body.name
|
|
if (body.customer_type !== undefined) updateData.customer_type = body.customer_type
|
|
// Empty string clears the customer number, same as an explicit null.
|
|
if (body.customer_number !== undefined) updateData.customer_number = body.customer_number || null
|
|
if (body.contact_person !== undefined) updateData.contact_person = body.contact_person
|
|
if (body.email !== undefined) updateData.email = body.email
|
|
if (body.phone !== undefined) updateData.phone = body.phone
|
|
if (body.invoice_email_cc_addresses !== undefined) {
|
|
updateData.invoice_email_cc_addresses = body.invoice_email_cc_addresses
|
|
}
|
|
if (body.invoice_email_bcc_addresses !== undefined) {
|
|
updateData.invoice_email_bcc_addresses = body.invoice_email_bcc_addresses
|
|
}
|
|
if (body.address_line1 !== undefined) updateData.address_line1 = body.address_line1
|
|
if (body.address_line2 !== undefined) updateData.address_line2 = body.address_line2
|
|
if (body.postal_code !== undefined) updateData.postal_code = body.postal_code
|
|
if (body.city !== undefined) updateData.city = body.city
|
|
if (body.country !== undefined) updateData.country = body.country
|
|
if (body.org_number !== undefined) updateData.org_number = body.org_number
|
|
if (body.vat_number !== undefined) updateData.vat_number = body.vat_number
|
|
if (personalNumberSubmitted) {
|
|
// Stored as ciphertext; customers_personal_number_check accepts that
|
|
// shape only (20260726110000).
|
|
updateData.personal_number = encryptCustomerPersonalNumber(body.personal_number)
|
|
} else if (body.customer_type !== undefined && effectiveType !== 'individual') {
|
|
updateData.personal_number = null
|
|
}
|
|
if (body.language !== undefined) updateData.language = body.language
|
|
if (body.default_payment_terms !== undefined) updateData.default_payment_terms = body.default_payment_terms
|
|
if (body.notes !== undefined) updateData.notes = body.notes
|
|
|
|
const { data, error } = await supabase
|
|
.from('customers')
|
|
.update(updateData)
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
.select()
|
|
.single()
|
|
|
|
if (error) {
|
|
if (error.code === 'PGRST116') {
|
|
return errorResponseFromCode('CUSTOMER_NOT_FOUND', opLog, { requestId })
|
|
}
|
|
if (error.code === '23505') {
|
|
return errorResponseFromCode('CUSTOMER_DUPLICATE_ORG_NUMBER', opLog, {
|
|
requestId,
|
|
details: { orgNumber: body.org_number },
|
|
})
|
|
}
|
|
opLog.error('customer update failed', error)
|
|
return errorResponseFromCode('CUSTOMER_UPDATE_FAILED', opLog, {
|
|
requestId,
|
|
details: { reason: getUserErrorMessage(error) },
|
|
})
|
|
}
|
|
|
|
// Re-run VIES validation when the VAT number changes on an EU business
|
|
// customer (non-blocking).
|
|
const isEuBusiness = (body.customer_type || data.customer_type) === 'eu_business'
|
|
if (body.vat_number !== undefined && isEuBusiness) {
|
|
try {
|
|
if (body.vat_number) {
|
|
const vatResult = await validateVatNumber(body.vat_number)
|
|
const validatedAt = vatResult.valid ? new Date().toISOString() : null
|
|
await supabase
|
|
.from('customers')
|
|
.update({
|
|
vat_number_validated: vatResult.valid,
|
|
vat_number_validated_at: validatedAt,
|
|
})
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
data.vat_number_validated = vatResult.valid
|
|
data.vat_number_validated_at = validatedAt
|
|
} else {
|
|
await supabase
|
|
.from('customers')
|
|
.update({ vat_number_validated: false, vat_number_validated_at: null })
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
data.vat_number_validated = false
|
|
data.vat_number_validated_at = null
|
|
}
|
|
} catch (err) {
|
|
opLog.warn('auto-VIES validation failed on customer update', err as Error)
|
|
}
|
|
}
|
|
|
|
return NextResponse.json({ data: maskCustomerRow(data) })
|
|
},
|
|
{ requireWrite: true },
|
|
)
|
|
|
|
export const DELETE = withRouteContext(
|
|
'customer.delete',
|
|
async (_request, ctx, { params }: { params: Promise<{ id: string }> }) => {
|
|
const { id } = await params
|
|
const { supabase, companyId, log, requestId } = ctx
|
|
const opLog = log.child({ customerId: id })
|
|
|
|
const { error, count } = await supabase
|
|
.from('customers')
|
|
.delete({ count: 'exact' })
|
|
.eq('id', id)
|
|
.eq('company_id', companyId)
|
|
|
|
if (error) {
|
|
if (error.code === '23503') {
|
|
return errorResponseFromCode('CUSTOMER_HAS_INVOICES', opLog, { requestId })
|
|
}
|
|
opLog.error('customer delete failed', error)
|
|
return errorResponseFromCode('CUSTOMER_DELETE_FAILED', opLog, {
|
|
requestId,
|
|
details: { reason: getUserErrorMessage(error) },
|
|
})
|
|
}
|
|
|
|
if (count === 0) {
|
|
return errorResponseFromCode('CUSTOMER_NOT_FOUND', opLog, { requestId })
|
|
}
|
|
|
|
return NextResponse.json({ success: true })
|
|
},
|
|
{ requireWrite: true },
|
|
)
|