* fix(agent): stop sending every page view to a third-party avatar CDN
Eight avatar SVGs were loaded from api.dicebear.com on every render. In an
accounting product that meant every authenticated page view told a third party
who was looking at it, from a domain we do not control, on the path of a
logged-in surface. A firewalled or self-hosted install showed no faces at all.
The SVGs are now generated once and served from public/agent-avatars. Each
entry records the seed it came from, so the set can be regenerated
reproducibly, and the command to do it is in the file.
The licence question that made this look like a founder decision resolved
itself on inspection: Notionists is by Zoish under CC0 1.0, public domain, no
attribution required. Confirmed on dicebear.com/licenses and, more usefully, in
each downloaded file's own RDF metadata, so the terms travel with the asset
rather than living in a commit message.
Tests pin the properties that matter rather than the file list: no entry may be
a remote URL, every entry must have a file behind it, and no shipped SVG may
carry an <image href>, a url(https://…), an xlink:href or a <script>, since
self-hosting a file that then phones home would reintroduce exactly the request
this removes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
* test(agent): assert the property, not a list of elements, for avatar externals
The external-reference check enumerated <image href>, url(https://…) and
xlink:href, which left <use href>, <feImage href> and scheme-relative //host
through: exactly the requests the guard claims to prevent, via elements it
happened not to list. That is how this sort of allowlist rots.
It now strips the parts that legitimately carry URLs and are never fetched (the
RDF metadata block, xmlns declarations) and then asserts that NOTHING in what
remains points off-origin. Verified by injecting each of the four bypasses into
a real asset and confirming the test fails on all of them.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Jakob Wennberg
2da96c0be2
