Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
53 lines
2.2 KiB
TypeScript
53 lines
2.2 KiB
TypeScript
import { describe, it, expect } from 'vitest'
|
|
import { isImportedTransaction } from '@/lib/transactions/origin'
|
|
|
|
describe('isImportedTransaction', () => {
|
|
describe('imported (ignore-only, never deletable)', () => {
|
|
it('treats a row with a live bank connection as imported', () => {
|
|
expect(isImportedTransaction({ bank_connection_id: 'bc-1', import_source: null })).toBe(true)
|
|
})
|
|
|
|
it('treats a row with a bank connection as imported even if import_source looks in-app', () => {
|
|
// The bank link wins: a PSD2 row is imported regardless of the source tag.
|
|
expect(isImportedTransaction({ bank_connection_id: 'bc-1', import_source: 'manual' })).toBe(true)
|
|
})
|
|
|
|
it('treats Enable Banking sync rows as imported', () => {
|
|
expect(isImportedTransaction({ bank_connection_id: null, import_source: 'enable_banking' })).toBe(true)
|
|
})
|
|
|
|
it('treats CAMT053 bank-file imports as imported', () => {
|
|
expect(isImportedTransaction({ bank_connection_id: null, import_source: 'camt053' })).toBe(true)
|
|
})
|
|
|
|
it.each(['csv_nordea', 'csv_lunar', 'csv_seb'])(
|
|
'treats CSV bank-file import %s as imported',
|
|
(source) => {
|
|
expect(isImportedTransaction({ bank_connection_id: null, import_source: source })).toBe(true)
|
|
},
|
|
)
|
|
|
|
it('treats an unknown future import source as imported (safe default)', () => {
|
|
expect(isImportedTransaction({ bank_connection_id: null, import_source: 'some_new_feed' })).toBe(true)
|
|
})
|
|
})
|
|
|
|
describe('user-created (deletable when unbooked)', () => {
|
|
it('treats a null source with no bank link as user-created (manual add)', () => {
|
|
expect(isImportedTransaction({ bank_connection_id: null, import_source: null })).toBe(false)
|
|
})
|
|
|
|
it('treats create-from-document (manual) as user-created', () => {
|
|
expect(isImportedTransaction({ bank_connection_id: null, import_source: 'manual' })).toBe(false)
|
|
})
|
|
|
|
it('treats MCP/agent-created rows as user-created', () => {
|
|
expect(isImportedTransaction({ bank_connection_id: null, import_source: 'mcp' })).toBe(false)
|
|
})
|
|
|
|
it('tolerates omitted (undefined) origin fields', () => {
|
|
expect(isImportedTransaction({})).toBe(false)
|
|
})
|
|
})
|
|
})
|