01dbef4015
* feat(dimensions): PR4 reports — dimension-filtered P&L everywhere + Resultat per projekt/kostnadsställe The Project P&L milestone of the dimensions plan (dev_docs §7 PR4). One choke point lights up everything: generateTrialBalance gains options.dimensions (SIE dim → code map) pushed down as jsonb containment (dimensions @>, served by idx_jel_dimensions_gin) on both line queries, with company-wide opening balances dropped when filtered (they cannot be dimension-scoped; P&L-safe by whitelist). Resultatrapport, resultaträkning, huvudbok, monthly-breakdown and the TB drill-down inherit the filter; the KPI route filters only its P&L-side inputs (income statement, months, expense composition) — never cash/VAT. New report lib/reports/dimension-pnl.ts — "Resultat per projekt/ kostnadsställe" (Fortnox Resultatrapport projekt): value-as-column matrix over one dimension with an explicit "(Utan dimension)" bucket computed as the residual against the same trial-balance pass resultatrapport uses, so every row and the Totalt column reconcile with the unfiltered resultatrapport by construction. Registered in REPORT_CATALOG (visible only when dimensions_enabled), slug-routed view + xlsx export. UI: DimensionFilter (dimension + value picker, persistent "Filtrerad — ej fullständig rapport" chip) mounts in FocusedReport for catalog entries flagged dimensions: true; huvudbok rows show line dim codes. Statutory exclusion pinned by TEST, not convention: lib/reports/__tests__/dimension-statutory-guard.test.ts fails if the filter parser leaks into balance sheet, balansrapport, kassaflöde, VAT, SIE or full-archive routes/generators, or if the catalog whitelist widens. MCP: new gnubok_get_dimension_pnl (reports:read); dimensions filter arg on get_trial_balance/get_income_statement/get_general_ledger with resolve-don't-select (names → registry codes, resolution echoes); query_journal totals fixed to aggregate the FULL match set (was silently slice-scoped while claiming otherwise) with an honest totals_scope field, plus group_by / group_by_dimension aggregation. Also: voucher-detail dim-6 badge now uses the registry name instead of the non-standard "PR" abbreviation (#859 review follow-up). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(dimensions): address #862 review — export disclosure, prior-column suppression, period-label honesty, route hardening - Filtered XLSX/PDF exports now carry the partial-view disclosure past the file boundary (BFNAR 2013:2): filename suffix (-dim6-p001), a "Filtrerad … — ej fullständig rapport" row on every sheet, and a header note/title line in the PDFs. - Resultatrapport drops the prior-year column when a dimension filter is active — project codes are time-limited under K2/K3, so "this code last year" may be a different project (same rule as narrowed date ranges). - dimension-pnl no longer accepts fromDate: the matrix is cumulative from period_start by design (closing-balance semantics), and the period label now states exactly that instead of echoing a lower bound that was never applied. Routes/MCP tool updated to toDate-only. - dimension-pnl routes 404 on an unknown/foreign period id and cap dim_no to 4 digits (matching the MCP tool's PostgREST-path guard, which the generator now also enforces itself). - Statutory-guard test's generateTrialBalance call-site scan is paren-aware instead of a 300-char window; added fully-untagged and injection-guard test cases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
96 lines
2.8 KiB
TypeScript
96 lines
2.8 KiB
TypeScript
/**
|
|
* Shared types for report drill-down to source vouchers.
|
|
*
|
|
* Every aggregated row (trial balance row, VAT ruta, AR customer, supplier
|
|
* row) can be expanded to show the underlying journal entries that
|
|
* contributed to it. The endpoints under
|
|
* `/api/reports/<report>/<key>/sources` return these in a paginated form.
|
|
*/
|
|
|
|
/**
|
|
* A single contributing line from a journal entry. Voucher number + series
|
|
* uniquely identify the verifikat, while `journal_entry_id` is the route
|
|
* target for `/bookkeeping/[id]`.
|
|
*/
|
|
export type ReportSourceLine = {
|
|
journal_entry_id: string
|
|
voucher_number: number
|
|
voucher_series: string
|
|
date: string
|
|
description: string
|
|
debit: number
|
|
credit: number
|
|
/** SIE dim → code tags on the line; omitted when untagged. */
|
|
dimensions?: Record<string, string>
|
|
}
|
|
|
|
/**
|
|
* Lazy-fetcher signature for client-side expansion. The component calls this
|
|
* the first time the user expands a row.
|
|
*/
|
|
export type ReportSourceFetcher = () => Promise<{
|
|
lines: ReportSourceLine[]
|
|
next_cursor?: string | null
|
|
}>
|
|
|
|
/**
|
|
* Response envelope for the lazy-fetch endpoints. The page-level reports
|
|
* never include the full `lines[]` to avoid eager loading thousands of
|
|
* entries on a trial balance.
|
|
*/
|
|
export type ReportSourceResponse = {
|
|
account_number?: string
|
|
account_name?: string
|
|
ruta?: string
|
|
customer_id?: string
|
|
supplier_id?: string
|
|
lines: ReportSourceLine[]
|
|
next_cursor: string | null
|
|
}
|
|
|
|
/**
|
|
* Loader state passed to subscribers. Mirrors the React hook output so the
|
|
* pure (node-testable) loader can drive the same semantics as the hook.
|
|
*/
|
|
export interface SourceLoaderState {
|
|
lines: ReportSourceLine[] | null
|
|
loading: boolean
|
|
error: string | null
|
|
}
|
|
|
|
/**
|
|
* Pure-TS loader: encapsulates the fetch + cache + error semantics used by
|
|
* the React hook in `components/reports/ReportRowExpansion`. Returning a
|
|
* minimal subscription protocol keeps the React layer thin and testable.
|
|
*
|
|
* Repeated calls to `load()` after a successful fetch are no-ops, so toggling
|
|
* a row open/closed never refetches.
|
|
*/
|
|
export function createSourceLoader(
|
|
fetcher: ReportSourceFetcher,
|
|
onChange: (state: SourceLoaderState) => void
|
|
) {
|
|
let state: SourceLoaderState = { lines: null, loading: false, error: null }
|
|
|
|
const emit = (next: Partial<SourceLoaderState>) => {
|
|
state = { ...state, ...next }
|
|
onChange(state)
|
|
}
|
|
|
|
return {
|
|
getState: () => state,
|
|
load: async () => {
|
|
if (state.lines !== null || state.loading) return
|
|
emit({ loading: true, error: null })
|
|
try {
|
|
const result = await fetcher()
|
|
emit({ lines: result.lines, loading: false })
|
|
} catch (err) {
|
|
const message =
|
|
err instanceof Error ? err.message : 'Kunde inte hämta verifikat'
|
|
emit({ error: message, loading: false })
|
|
}
|
|
},
|
|
}
|
|
}
|