Files
accounted/lib/reports/kpi-definitions.ts
T
Jakob Wennberg f266c386f3 chore: repo-wide bloat sweep, remove dead code and fold duplicate helpers (#2150)
* chore: repo-wide bloat sweep, remove dead code and fold duplicate helpers

Remove 33 dead files, ~270 unreferenced exports/types, 13 dead i18n
namespaces and 4 unused dependencies; fold byte-identical helper copies
into one canonical home each (lib/utils chunk/sleep/utcDateStamp,
lib/dates/iso, lib/invariants/uuid, lib/xml/escape, lib/reports/sru/format,
lib/pdf/number-text, lib/browser/panel-request, lib/api/v1/body +
v1ValidationError rolled out to ~55 v1 routes, booking-template schemas).

No behaviour change: v1 bodies and status codes, MCP tool schemas, DB
writes and money math are untouched. Naive ore rounding was deliberately
not swapped for roundOre; see DECISIONS.md 2026-09-02 for the full list
of things left alone on purpose.

tsc, lint, 19588 unit tests and check:guards green; antipattern baseline
ratcheted (naive-ore-round 622 -> 620, hand-rolled-invariant 115 -> 113).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

* test(transactions): import RawTransaction from @/types after the ingest re-export removal

CI's type ratchet (check:types, full tsconfig) caught the one test file
that still imported the type through lib/transactions/ingest.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-02 11:51:16 +02:00

92 lines
2.5 KiB
TypeScript

import type { KPIPreferences } from '@/types'
import { VAT_INPUT_ACCOUNTS, VAT_OUTPUT_ACCOUNTS } from '@/lib/reports/vat-declaration'
export interface KPIDefinition {
id: string
// Translation key suffix; used as `kpi.def_<id>_label` / `_description` / `_formula` / `_accounts`.
defaultAccounts: string[]
customizableAccounts: boolean
defaultVisible: boolean
format: 'currency' | 'percentage' | 'days'
colorLogic: 'positive-good' | 'negative-good' | 'neutral'
}
export const KPI_DEFINITIONS: KPIDefinition[] = [
{
id: 'netResult',
defaultAccounts: [],
customizableAccounts: false,
defaultVisible: true,
format: 'currency',
colorLogic: 'positive-good',
},
{
id: 'cashPosition',
defaultAccounts: ['1910', '1920', '1930', '1940', '1950', '1960', '1970', '1980'],
customizableAccounts: true,
defaultVisible: true,
format: 'currency',
colorLogic: 'positive-good',
},
{
id: 'outstandingReceivables',
defaultAccounts: ['1510'],
customizableAccounts: false,
defaultVisible: true,
format: 'currency',
colorLogic: 'neutral',
},
{
id: 'vatLiability',
// Same 26xx accounts as the momsdeklaration (ruta 49): see vat-declaration.ts
defaultAccounts: [...VAT_OUTPUT_ACCOUNTS, ...VAT_INPUT_ACCOUNTS],
customizableAccounts: true,
defaultVisible: true,
format: 'currency',
colorLogic: 'negative-good',
},
{
id: 'grossMargin',
defaultAccounts: [],
customizableAccounts: false,
defaultVisible: false,
format: 'percentage',
colorLogic: 'positive-good',
},
{
id: 'expenseRatio',
defaultAccounts: [],
customizableAccounts: false,
defaultVisible: false,
format: 'percentage',
colorLogic: 'negative-good',
},
{
id: 'avgPaymentDays',
defaultAccounts: [],
customizableAccounts: false,
defaultVisible: false,
format: 'days',
colorLogic: 'negative-good',
},
]
export const ALL_KPI_IDS = KPI_DEFINITIONS.map((d) => d.id)
export function getDefaultPreferences(): KPIPreferences {
return {
visibleKpis: KPI_DEFINITIONS.filter((d) => d.defaultVisible).map((d) => d.id),
kpiOrder: ALL_KPI_IDS,
accountOverrides: {},
}
}
export function mergeWithDefaults(prefs: Partial<KPIPreferences>): KPIPreferences {
const defaults = getDefaultPreferences()
return {
visibleKpis: prefs.visibleKpis ?? defaults.visibleKpis,
kpiOrder: prefs.kpiOrder ?? defaults.kpiOrder,
accountOverrides: prefs.accountOverrides ?? defaults.accountOverrides,
}
}