Files
accounted/lib/reports/__tests__/continuity-check.test.ts
T
Jakob Wennberg a8801430f4 fix(reports): stop driving report queries from the unfiltered journal_entry_lines side (#971)
* fix(reports): drive report line queries from journal_entries, not the unfiltered lines side

Every report generator fetched journal_entry_lines with a
journal_entries!inner(...) embed and put the tenant filter on the
embedded side (.eq('journal_entries.company_id', ...)). PostgREST
compiles that to a correlated INNER JOIN LATERAL with a parameterized
LIMIT inside, which blocks join reordering: Postgres walked the ENTIRE
journal_entry_lines table (603k rows, all tenants) per report query.
Measured in production: 13.6 s vs 2.7 ms for the equivalent plain join,
against Supabase's 8 s statement_timeout; nightly cloud backups failed
for 5 of 11 companies on 2026-07-09 and a GL report 500'd.

Introduce lib/bookkeeping/entry-lines.ts with a shared two-step fetch:

1. fetch matching journal_entries (id + caller-selected columns)
   filtered by company_id / fiscal_period_id / status / entry_date /
   source_type, paginated via fetchAllRows;
2. fetch journal_entry_lines with .in('journal_entry_id', chunk) in
   chunks of 100 ids (URL-length safety), paginated per chunk;
3. reattach the parent entry to each line under the embed's key shape
   (line.journal_entries = {...}, aliasable) and sort lines by id
   ascending to preserve the old .order('id') semantics.

Converted call sites (selected columns and filters preserved):
trial-balance (x2), general-ledger, journal-register, sie-export
(reuses its existing entry list via fetchLinesByEntryIds),
vat-declaration, dimension-pnl, opening-balances, monthly-breakdown,
periodisk-sammanstallning, rc-basis-gaps (sibling-line fetch now also
chunked), ar-reconciliation, supplier-reconciliation,
bank-reconciliation, asset-service (x2), bolagsskatt-calculator,
sarskild-loneskatt-calculator.

Tests: unit tests for the helper (chunk size, reattachment shape,
forced id/journal_entry_id columns, empty result, cross-chunk sort,
error propagation); existing report/reconciliation/bokslut test mocks
updated to the two-step query shape, preserving every assertion about
report output.

From the 2026-07-09 production log triage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(reports): stop echoing raw error messages from the general-ledger route

The catch handler returned err.message to the client in
details.reason; internal error strings (SQL fragments, table names,
timeout messages) must not reach the browser. The error is already
logged server-side with the request id, so the client envelope keeps
only the REPORT_GENERATION_FAILED code.

From the 2026-07-09 production log triage.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-10 11:03:28 +02:00

303 lines
10 KiB
TypeScript

import { describe, it, expect, vi, beforeEach } from 'vitest'
// ============================================================
// Mock Supabase: table-keyed result queues
// ============================================================
type MockResult = { data?: unknown; error?: unknown; count?: number }
let mockResults: Record<string, MockResult[]>
function makeBuilder(tableName: string) {
const b: Record<string, unknown> = {}
for (const m of ['select', 'eq', 'in', 'lt', 'neq', 'order', 'range', 'update']) {
b[m] = vi.fn().mockReturnValue(b)
}
const consume = (): MockResult => {
const queue = mockResults[tableName]
if (!queue || queue.length === 0) {
// The two-step entry-lines fetch (lib/bookkeeping/entry-lines.ts) reads
// journal_entries before journal_entry_lines. Tests queue line rows
// directly, so default the entries step to one generic entry.
if (tableName === 'journal_entries') {
return { data: [{ id: 'entry-1' }], error: null }
}
return { data: null, error: null }
}
return queue.shift()!
}
b.single = vi.fn().mockImplementation(async () => consume())
b.then = (resolve: (v: unknown) => void) => resolve(consume())
return b
}
function makeClient() {
const rpc = vi.fn().mockImplementation(async (fn: string) => {
const queue = mockResults[`rpc:${fn}`]
if (!queue || queue.length === 0) return { data: [], error: null }
return queue.shift()!
})
return {
from: vi.fn().mockImplementation((table: string) => makeBuilder(table)),
rpc,
// eslint-disable-next-line @typescript-eslint/no-explicit-any
} as any
}
import { validateBalanceContinuity } from '../continuity-check'
let supabase: ReturnType<typeof makeClient>
beforeEach(() => {
vi.clearAllMocks()
mockResults = {}
supabase = makeClient()
})
describe('validateBalanceContinuity', () => {
it('returns valid for first period (no previous_period_id)', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p1', name: 'FY2024', period_start: '2024-01-01', previous_period_id: null, opening_balance_entry_id: null } },
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p1')
expect(result.valid).toBe(true)
expect(result.discrepancies).toEqual([])
expect(result.checked_accounts).toBe(0)
expect(result.previous_period_name).toBeNull()
})
it('returns valid when IB matches UB', async () => {
mockResults = {
fiscal_periods: [
// Target period
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
// Previous period (for name)
{ data: { id: 'p1', name: 'FY2024' } },
// Previous period (for generateTrialBalance)
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
// Previous period lines (trial balance: prior OB comes from RPC, defaults empty)
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
{ account_number: '2099', debit_amount: 0, credit_amount: 30000 },
{ account_number: '1510', debit_amount: 10000, credit_amount: 0 },
],
},
// Current period OB entry lines (getOpeningBalances)
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
{ account_number: '2099', debit_amount: 0, credit_amount: 30000 },
{ account_number: '1510', debit_amount: 10000, credit_amount: 0 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1510', account_name: 'Kundfordringar', account_class: 1 },
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
{ account_number: '2099', account_name: 'Årets resultat', account_class: 2 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(true)
expect(result.discrepancies).toEqual([])
expect(result.checked_accounts).toBe(3)
expect(result.period_name).toBe('FY2025')
expect(result.previous_period_name).toBe('FY2024')
})
it('detects discrepancy in one account', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
{ data: { id: 'p1', name: 'FY2024' } },
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
// Previous UB: 1930 = 50000 debit
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
{ account_number: '2099', debit_amount: 0, credit_amount: 50000 },
],
},
// Current IB: 1930 = 49000 debit (mismatch!)
{
data: [
{ account_number: '1930', debit_amount: 49000, credit_amount: 0 },
{ account_number: '2099', debit_amount: 0, credit_amount: 50000 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
{ account_number: '2099', account_name: 'Årets resultat', account_class: 2 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(false)
expect(result.discrepancies).toHaveLength(1)
expect(result.discrepancies[0].account_number).toBe('1930')
expect(result.discrepancies[0].previous_ub_net).toBe(50000)
expect(result.discrepancies[0].current_ib_net).toBe(49000)
expect(result.discrepancies[0].difference).toBe(1000)
})
it('detects account present in UB but not IB', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
{ data: { id: 'p1', name: 'FY2024' } },
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
// Previous UB has 1510 and 2440
{
data: [
{ account_number: '1510', debit_amount: 10000, credit_amount: 0 },
{ account_number: '2440', debit_amount: 0, credit_amount: 10000 },
],
},
// Current IB only has 1510 (2440 missing)
{
data: [
{ account_number: '1510', debit_amount: 10000, credit_amount: 0 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1510', account_name: 'Kundfordringar', account_class: 1 },
{ account_number: '2440', account_name: 'Leverantörsskulder', account_class: 2 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(false)
expect(result.discrepancies).toHaveLength(1)
expect(result.discrepancies[0].account_number).toBe('2440')
expect(result.discrepancies[0].previous_ub_net).toBe(-10000)
expect(result.discrepancies[0].current_ib_net).toBe(0)
})
it('detects account present in IB but not UB', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
{ data: { id: 'p1', name: 'FY2024' } },
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
// Previous UB: only 1930
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
],
},
// Current IB: 1930 + 1510 (1510 shouldn't be here)
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
{ account_number: '1510', debit_amount: 5000, credit_amount: 0 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(false)
expect(result.discrepancies).toHaveLength(1)
expect(result.discrepancies[0].account_number).toBe('1510')
expect(result.discrepancies[0].previous_ub_net).toBe(0)
expect(result.discrepancies[0].current_ib_net).toBe(5000)
})
it('treats sub-öre float drift as valid (ORE_TOLERANCE = 0.005 SEK)', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: 'ob-1' } },
{ data: { id: 'p1', name: 'FY2024' } },
{ data: { period_start: '2024-01-01', opening_balance_entry_id: null } },
],
journal_entry_lines: [
{
data: [
{ account_number: '1930', debit_amount: 50000.001, credit_amount: 0 },
],
},
{
data: [
{ account_number: '1930', debit_amount: 50000, credit_amount: 0 },
],
},
],
chart_of_accounts: [
{
data: [
{ account_number: '1930', account_name: 'Företagskonto', account_class: 1 },
],
},
],
}
const result = await validateBalanceContinuity(supabase, 'company-1', 'p2')
expect(result.valid).toBe(true)
expect(result.discrepancies).toEqual([])
})
it('throws when period not found', async () => {
mockResults = {
fiscal_periods: [
{ data: null, error: { message: 'not found' } },
],
}
await expect(
validateBalanceContinuity(supabase, 'company-1', 'nonexistent')
).rejects.toThrow('Fiscal period not found')
})
it('throws when previous period not found', async () => {
mockResults = {
fiscal_periods: [
{ data: { id: 'p2', name: 'FY2025', period_start: '2025-01-01', previous_period_id: 'p1', opening_balance_entry_id: null } },
{ data: null, error: { message: 'not found' } },
],
}
await expect(
validateBalanceContinuity(supabase, 'company-1', 'p2')
).rejects.toThrow('Previous fiscal period not found')
})
})