Files
accounted/lib/providers/amounts.ts
T
Jakob Wennberg dc5079a912 fix(providers): stop inventing 25% VAT on migrated invoices (#1745)
* fix(providers): stop inventing 25% VAT on migrated invoices

An invoice migrated from Fortnox displayed "Momsbehandling: 25 % moms"
next to "Moms: 0 kr", with no line items behind it. It was not a display
bug: the record really did hold vat_rate 25 and vat_amount 0.

Fortnox answers GET /3/invoices with the short form, which carries no
Net, no TotalVAT and no InvoiceRows; those live only on the detail form.
The migration mapped the list payload alone, so `Net ?? total` made the
net equal the gross, VAT derived as gross minus net came out 0, and with
no rows to read a rate from, inferVatTreatment/inferVatRate fell through
to their `return 'standard_25'` / `return 25` defaults. The result
balanced, so nothing downstream noticed.

Measured on prod: 8 712 sales invoices across 43 companies assert a rate
beside 0 kr of VAT (286 MSEK of subtotal), plus 1 240 supplier invoices.
None are booked, but 263 are still open, and the no-items booking
fallback in invoice-entries.ts credits the full gross to 30xx and emits
no 2611 line at all.

Not Fortnox-only. Visma reported its VAT-inclusive TotalAmount as the
ex-VAT amount and read rows via `LineTotal`/`VatRatePercent`, neither of
which exists in the eAccounting schema (the real names are AmountNoVat
and PercentVat), so its lines all landed at 0. Bjorn Lunden reported the
gross as the net with no lines at all. Briox and WINT had the same
gross-as-net fallback, and Bokio defaulted a missing totalTax to 0.

- lib/providers/amounts.ts: readers that return undefined for an absent
  field, so "the provider says zero" stays distinct from "did not say"
- every mapper: populate taxTotal and per-line taxAmount from what the
  payload actually states; leave the net undefined when it does not
- provider-data-fetcher: hydrate the detail endpoint that every config
  has always declared and nothing ever called, open invoices first,
  within a time budget, reporting whatever it could not reach
- entity-mapper: derive rate and treatment from evidence; when there is
  none, write vat_rate null and flag vatUnresolved instead of asserting
  a standard rate

Existing rows are untouched; repairing them needs a separate decision.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(providers): keep subtotal + VAT equal to the invoice total

Providers state net, VAT and gross independently and they need not agree:
Fortnox's Total is the amount to pay after öresavrundning while
Net + TotalVAT is the unrounded Gross, so the two differ by up to 50 öre.

Passing both through as stated put that gap into the invoice row, where
subtotal + vat_amount no longer equalled total. The header booking path
in invoice-entries.ts derives the 1510 debit from the sum of its credits,
so the receivable would land a few öre away from what the customer owes
while the verifikat still balanced: the same silent shape as the bug this
branch fixes.

resolveVatTriple now always returns a pair summing to the gross, keeping
the VAT intact (it reaches the momsdeklaration) and absorbing the
rounding into the net.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(providers): address invoice detail by the configured idField

Hydration built the detail path from dto.id. Björn Lundén's sales config
names invoiceNumber as its idField while its mapper builds dto.id from
entityId, so BL sales invoices would have been hydrated from the wrong
resource, or from none. Every other provider/resource pair happens to
agree on the two, which is what made the mismatch easy to miss.

The config's idField is the authority, read off the raw payload, with
dto.id only as the fallback. The regression test uses BL with entityId
99001 and invoiceNumber 5 so the two cannot coincide.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(providers): store vat_rate null for migrated mixed-rate invoices

resolveInvoiceVat labelled the header with the first line's rate, so an
invoice carrying both 25 % and 6 % lines was recorded as a 25 % invoice.
buildInvoiceWriteData already stores isMixedRate ? null : theRate for
natively created invoices; migrated ones now match.

The money was already right and stays right: generatePerRateLines groups
per item rate, so a mixed invoice books 25 % and 6 % separately off the
per-line vat_rate/vat_amount this branch fixed. Only the header label was
overstating what the source said.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

* fix(providers): bound hydration against auth failures and the clock

Two failure modes that only appear against a real provider.

A 401 or 403 fails identically for every remaining invoice, so the pass
now stops on the first one instead of issuing hundreds more doomed
calls. That matters more than it looks: TokenBucketRateLimiter keys on
the literal string 'global', so Fortnox's 4 req/s is a platform-wide
budget shared by every company and every concurrent migration, not a
per-token one. A 404 is about one invoice and does not stop the pass.

The budget was checked before starting a call but never during one. The
clients retry 429s and 5xx with backoff (Fortnox: 6 attempts, up to 60 s
apart), so a call starting one millisecond inside the budget could still
be retrying minutes later, and three concurrent ones could hold the
migration past its 300 s function ceiling. Each call is now raced
against the deadline; the socket is not cancelled, but control returns
and the remaining invoices are reported unhydrated instead of the run
dying.

Both outcomes are reported as HydrationReport.abortedBy so a partial
pass is visible rather than looking complete.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <invoice@arcim.io>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-22 12:07:52 +02:00

140 lines
5.2 KiB
TypeScript

import { roundOre } from '@/lib/money';
/**
* Numeric field readers for provider payloads.
*
* Every provider mapper used to collapse "this field is not in the payload"
* into a number with `?? 0` or `?? total`. For VAT that is not a harmless
* default: it is an assertion. A missing `TotalVAT` became "0 kr moms", a
* missing `Net` became "net equals gross", and the migration then wrote an
* invoice claiming 25 % moms alongside 0 kr of it. The record balanced, so
* nothing downstream complained.
*
* These helpers return `undefined` for an absent field so callers can tell
* "the provider says zero" from "the provider did not say". Deciding what to
* do with genuinely unknown VAT belongs to the caller, not to a `??`.
*/
/**
* First present, finite numeric value among `keys`.
*
* Providers spell the same quantity differently across endpoints and API
* versions (Fortnox `Net` vs `NetAmount`, Visma `TotalAmount` vs
* `TotalAmountInvoiceCurrency`), and the live payloads have repeatedly
* differed from the published spec. Taking a candidate list rather than a
* single key means an unexpected spelling degrades to `undefined`, which is
* flagged, instead of to a fabricated zero, which is not.
*
* Strings are accepted because several providers serialise decimals as
* strings; empty strings and nulls are not numbers and are skipped.
*/
export function readNumber(
raw: Record<string, unknown> | undefined | null,
keys: readonly string[],
): number | undefined {
if (!raw) return undefined;
for (const key of keys) {
if (!(key in raw)) continue;
const value = raw[key];
if (value === null || value === undefined || value === '') continue;
const n = typeof value === 'number' ? value : Number(value);
if (Number.isFinite(n)) return n;
}
return undefined;
}
/**
* The VAT figures a provider payload yielded, with "unknown" preserved.
*
* `net` and `vat` are independently optional: Fortnox's detail payload gives
* both, Björn Lundén's list payload gives neither, and a provider that gives
* only one still lets the third be derived against `gross`.
*/
export interface ResolvedVat {
/** Amount excluding VAT, or undefined when no evidence established it. */
net?: number;
/** VAT amount, or undefined when no evidence established it. */
vat?: number;
}
/**
* Complete a net/VAT/gross triple from whichever two are known.
*
* Returns only what the inputs support. With just a gross total, both fields
* come back undefined rather than net = gross and VAT = 0: "we only know what
* the customer paid" is the honest reading, and the caller flags it.
*
* The returned pair ALWAYS satisfies `net + vat === gross`. Providers state
* all three independently and they need not agree: Fortnox's `Total` is the
* amount to pay after öresavrundning, while `Net + TotalVAT` is the unrounded
* `Gross`, so the two differ by up to 50 öre. Passing both through as stated
* would put that gap into the invoice row, where `subtotal + vat_amount` no
* longer equals `total`; the header booking path derives the 1510 debit from
* the sum of its credits, so the receivable would land a few öre away from
* what the customer actually owes while the verifikat still balanced. The VAT
* is the figure that must survive intact (it reaches the momsdeklaration), so
* the gap is absorbed into the net.
*/
export function resolveVatTriple(params: {
gross: number;
net?: number;
vat?: number;
}): ResolvedVat {
const { gross, net, vat } = params;
if (vat !== undefined) return { net: roundOre(gross - vat), vat };
if (net !== undefined) return { net, vat: roundOre(gross - net) };
return {};
}
/**
* Product of two optional numbers, undefined unless both are present.
*
* Used to reconstruct a line amount from unit price x quantity when the
* provider's own line-total field is absent. Returning undefined for a
* missing factor keeps a half-known line from being recorded as 0.
*/
export function multiplyIfBothPresent(
a: number | undefined,
b: number | undefined,
): number | undefined {
if (a === undefined || b === undefined) return undefined;
return roundOre(a * b);
}
/**
* Sum per-line VAT when every line carries an amount, else undefined.
*
* A partial sum would understate the total, so one line missing its VAT
* discards the whole sum rather than reporting a number that is too low.
*/
export function sumLineVat(
lines: readonly { taxAmount?: { value: number } }[],
): number | undefined {
if (lines.length === 0) return undefined;
if (lines.some((line) => line.taxAmount === undefined)) return undefined;
return roundOre(lines.reduce((sum, line) => sum + (line.taxAmount?.value ?? 0), 0));
}
/**
* VAT for one line from its rate and net amount.
*
* Only when the provider actually stated a rate: `taxPercent` undefined means
* the rate is unknown, and 0 % is a real answer that must not be invented.
* Accepts both unit conventions (25 and 0.25) because providers mix them.
*/
export function lineVatFromPercent(
lineNet: number,
taxPercent: number | undefined,
): number | undefined {
if (taxPercent === undefined || !Number.isFinite(taxPercent)) return undefined;
const rate = taxPercent > 1 ? taxPercent / 100 : taxPercent;
return roundOre(lineNet * rate);
}