150e2a3f14
* feat(reconciliation): skattekonto bridge engine, sync-time twin proposals, account-keyed facade The engine half of the reconciliation page (design: Avstämningsmotorn). - lib/reconciliation/skattekonto-reconciliation.ts: getSkattekontoReconciliationStatus anchors at the saldo snapshot and returns the bridge (saldo hos Skatteverket, händelser som saknas, 1630-rader utan händelse, ignorerade, ingående skillnad, bokfört), the item buckets the page shows (proposed, unmatched external, unmatched ledger, matched, ignored, upcoming), opening_difference, unexplained_difference (0,00 by construction when data is consistent), dead-link handling (a link to a reversed/draft entry counts as unlinked and is flagged), awaiting_external for ledger lines within 5 days of the snapshot, staleness, and a window that scopes item lists without hiding older rows. Core reads skattekonto_transactions and the extension's snapshot row directly; no @/extensions import. - lib/reconciliation/gl-balance.ts: one ledger-balance helper with the trial-balance predicate status IN (posted, reversed). The drift check summed posted only, which misstated 1630 for any company with a storno on the account; skattekonto-drift.ts now delegates to the helper. - Proposals at sync: migration 20260823120000 adds suggested_journal_entry_id / suggested_at (ON DELETE SET NULL, partial index on open rows); the sync calls refreshSkattekontoProposals after the upsert. findMatchSuggestionsBulk now assigns one-to-one across rows (AGI period first, then nearest date) and falls back to an entry whose 1630 lines net to the amount (split lines); a proposal is never a link. - lib/reconciliation/service.ts + schemas.ts: the account-keyed facade (bank:<cash_account_id> | skattekonto | manual:NNNN) with listReconciliationAccounts (enabled cash accounts folded per IBAN, skattekonto when configured) and getAccountStatus dispatching to the bank engine or the new one; shared Zod shapes for the v1 registry, MCP schemas and the UI (PR 2). Tests: identity on a mixed fixture, storno pair, stale snapshot, awaiting window, window scoping, failed ledger read, live-linked entries never proposed; matcher one-to-one and split-line cases; proposal refresh writes/clears; service dedupe and dispatch. No UI in this PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): roundOre instead of inline öre rounding (guard ratchet) The antipattern ratchet counts Math.round(x*100)/100; the new engine used it in five places. Switch to roundOre from @/lib/money and ratchet the baseline down by the three occurrences this removes net of the matcher rewrite. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(reconciliation): three doors over one engine: dashboard routes, v1 API and MCP tools for account-keyed reconciliation PR 2 of the Avstämning build (design: Avstämning via API och MCP). Every door calls lib/reconciliation/{service,items,actions}.ts; none re-implements a link. - lib/reconciliation/items.ts: listAccountItems per account_key, the page's buckets (proposed, unmatched_external, unmatched_ledger, matched, ignored, upcoming), limit/offset; skattekonto from the engine, bank from the scoped transactions + unlinked GL lines (netted per entry). - lib/reconciliation/actions.ts: matchPairs (pairs or use_proposals, dry run, partial success with codes), unmatchLink, setItemIgnored; emits reconciliation.matched / reconciliation.unmatched. - lib/skatteverket/skattekonto-link.ts: canonical core link semantics for a skattekonto row (single line or entry net on 1630, live-link guard, race-safe update, unlink, ignore); the extension keeps its own matchSkattekontoToEntry until its tests are ported. - Dashboard routes /api/reconciliation/accounts[...]: list, status, items, links (POST), links/{linkId} (DELETE), items/{itemId}/ignore (POST); apply directly (a human clicked). - v1 routes /api/v1/companies/{id}/reconciliation/accounts[...]: same six, withApiV1, new scopes reconciliation:read / reconciliation:write (write is a staging scope for SoD), Idempotency-Key + dry_run on writes, registered for OpenAPI, load-routes, skills/accounted-api regenerated. Legacy bank routes and their transactions:* scopes unchanged. - MCP: gnubok_get_reconciliation_status takes account_key (legacy bank path untouched), new gnubok_list_reconciliation_items (default catalog), gnubok_reconcile_match (stages reconciliation_match, preflight = status) and gnubok_reconcile_unmatch (stages reconciliation_unmatch), both search-only to stay under the tools/list payload ceiling; gnubok_link_transaction_to_journal_entry moved to search. Executors in commit.ts; risk tiers medium/low; migration pair 20260823130000/130001 adds the two op types to the CHECK constraint (value list = live prod as of 2026-08-23 + the two); close_period loadout updated. Tests: service/actions/items/link unit tests, v1 route tests (401/403/400/404/ happy, idempotency, dry run), dashboard route tests, MCP tool tests + the guard suite (payload ceiling, descriptions, staging meta, qualified ids). Guards and apiskill:check green; no type errors in changed files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): refresh the v1 spec snapshot and keep the ignore update readable by the phantom-column guard The six new v1 reconciliation endpoints and the two new scopes were not recorded in the spec snapshot, and setSkattekontoRowIgnored updated through one conditional payload, which the phantom-column scanner cannot read (ceiling 380 -> 381). Two literal payloads instead; snapshot updated. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(reconciliation): the Avstämning page, one body for every account with an outside truth /reconciliation in Arbeta (after Transaktioner), on the approved layout: an account rail on the left (bank accounts and the skattekonto, logo or monogram, last fetch, status dot, URL-owned selection), and for the selected account four tiles (outside, ledger, difference, unexplained), the bridge that explains the difference, an actions row (link the proposed pairs, book the unbooked skattekonto events, run the bank matcher) and a full-width table banded by bucket with proposal rows linkable one by one. Every read and write goes through the PR 2 dashboard routes, so the page shows exactly what the v1 API and the MCP tools see. Also: nav item, command palette entry, sv/en strings. Period picker, manual match mode and sign-off are deliberately not here (PR 4/5). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(reconciliation): sign-off, period picker, Hem row and the three doors for it "Markera som avstämd t.o.m. <datum>" as an append-only attestation: account_reconciliations (who signed which account through which date, with the numbers as they stood; reopen stamps instead of deletes; RLS members write as themselves, viewers read). Policy in one place (lib/reconciliation/signoff.ts): refused with an unexplained difference unless forced with a note, refused past today or past the skattekonto snapshot, refused at or before an active sign-off; reopen is the undo. Every status read now carries the latest active sign-off and the rail shows "avstämt t.o.m.". Three doors: dashboard routes (GET/POST .../signoff, POST .../reopen), v1 (same, scope reconciliation:signoff, Idempotency-Key, dry-run, registry + regenerated API skill), MCP gnubok_reconcile_signoff (search catalog, stages reconciliation_signoff after a policy dry run; executor + risk tier + op-type CHECK migration pair). Events reconciliation.signed_off / reconciliation.reopened, and the four reconciliation events join the public webhook set (additive; API version unchanged, changelog section added). Page: räkenskapsår + range picker in the header (own preset memory, opens on this month) scoping the bridge, the items and the default sign-off date; sign-off dialog with the forced-with-note path; reopen on hover. Hem: worklist category reconciliation_due ("Konton att stämma av"), zero until the company has signed anything off. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): classify reconciliation:signoff as a tenant write for the MCP role guard gnubok_reconcile_signoff carries the deliberately separate reconciliation:signoff scope; the central viewer guard keys on the :write/:approve/:manage suffixes, so a viewer could reach the tool (RLS would still refuse the row, but the guard is the intended layer). Add :signoff to the classifier; the strictness test that caught it now passes. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(providers): serve local rate-limiter waiters in arrival order Two callers that both found the in-memory bucket empty each set their own timeout; the timeouts expired at the same instant from different timer lists and which woke first was platform-dependent. hydrateInvoices relies on "started first, requested first" to serve open invoices before paid ones, so lib/providers/__tests__/hydrate-invoices.test.ts flipped on CI (twice on #1817) while holding locally. A promise queue makes the local waiters FIFO without changing the rate; the Upstash path is untouched. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> (cherry picked from commit 14a7599bf2c6fa7f97de6ffab3dc4cf4d0e1827d) * feat(reconciliation): agent surfaces: summary resource, attention category, reconcile-month skill, skattekonto notice, fair sync order Accounted://reconciliation/summary: every reconcilable account with its state, unexplained difference, open counts, last fetch and latest sign-off, plus a next step; the rail as a resource, on the same service function the page and v1 use. Accounted://attention gains reconciliation_due (shared predicate with the Hem row). A reconcile-month workflow skill and the reconcile_month loadout describe the account-keyed flow (summary -> bridge -> buckets -> sign-off). The skattekonto sync persists its reconciliation summary (skattekonto_reconciliation_latest) so the new Hem notice skv_unexplained ("Skattekontot stämmer inte med bokföringen: X är oförklarat", link to /reconciliation?account=skattekonto) costs one small read instead of a bridge computation per render; it honours the drift tolerance and its id carries the whole-krona amount so öre noise never resurfaces a dismissal. The skattekonto sync cron orders eligible companies by stalest sync (never-synced first) before its per-run cap, so the tail is no longer starved by a fixed order. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * chore: retrigger preview build (builder OOM during Running TypeScript, not the diff) * fix(reconciliation): visual pass round 1: full-width table, bank tile shows the period sum From Jakob's first look at the page on real data: - The items table now spans the full page width (the approved layout); the rail + tiles + bridge + actions stay in the two-column grid above it, which now lives inside AccountOverview (the rail rides in as a prop) so the table can break out below. - The bank account's first tile said "okänt": it read external_balance (the reported bank balance, often unknown) while its label says Banktransaktioner i perioden. It now shows the bridge's period sum, matching the label, the difference and the bridge line. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * feat(reconciliation): bank brand icons in the rail The rail resolves each bank account's icon from its connection's bank_name (falling back to the account name) against square brand icons committed under public/logos/banks/: the set covers every bank with a live connection in prod as of 2026-08-24 (SEB, Lunar, Handelsbanken, Swedbank, Nordea, Svea, Länsförsäkringar, Revolut, Wise, Danske, Klarna, Northmill, PayPal, plus Stripe for named accounts). Word-boundary matching so lookalike names never hijack a logo; anything unmatched (the small sparbanker, file imports) keeps the monogram. The skattekonto already had its Skatteverket mark. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * fix(reconciliation): label the bank period sum as netto Jakob read 'Banktransaktioner i perioden 399 941 kr' as gross activity (his is ~1,9 MSEK) and rightly asked why it was so low: the value is the net movement (in - out), which is what the bridge compares against the net booked movement on the ledger account. Verified against raw prod data (237 rows, 1 169 126,40 in, -769 185,04 out = 399 941,36). The tile and the bridge line now say '(netto)' / '(net)'. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
129 lines
5.9 KiB
TypeScript
129 lines
5.9 KiB
TypeScript
/**
|
|
* Notices: the unified degraded-state model (system & integration health).
|
|
*
|
|
* One source of truth for "something the user relies on is broken or about
|
|
* to break", shared by the Hem notice line and (via /api/notices) any client
|
|
* surface. The sibling of lib/worklist, which owns actionable bookkeeping
|
|
* work items; notices own connection/health state. Every surface that shows
|
|
* degraded integration state MUST read it from lib/notices instead of
|
|
* hand-rolling its own detection, so the same fact is never double-modeled
|
|
* with diverging thresholds.
|
|
*
|
|
* Each category documents its pending ("notice active") and done conditions.
|
|
*/
|
|
|
|
export const NOTICE_CATEGORIES = [
|
|
/**
|
|
* A bank connection has already failed.
|
|
* Pending: bank_connections.status IN ('expired', 'error'): same predicate
|
|
* as BankSyncStatusChip's "attention" state.
|
|
* Done: the connection is renewed (status back to 'active') or removed.
|
|
*/
|
|
'bank_connection_broken',
|
|
/**
|
|
* The Skatteverket connection can no longer authenticate.
|
|
* Pending: a skatteverket_tokens row exists for (user, company) with
|
|
* status = 'needs_reconsent', or its access token is expired with
|
|
* no usable refresh token (refresh_token NULL or refresh_count
|
|
* >= 10): mirrors the skatteverket extension's /status route.
|
|
* Done: the user re-consents with BankID (storeTokens resets the row)
|
|
* or disconnects entirely (no row = not connected = no notice).
|
|
*/
|
|
'skv_disconnected',
|
|
/**
|
|
* A connected cloud backup is failing (dead token or errored auto-sync).
|
|
* Pending: a cloud-backup provider connection exists in extension_data
|
|
* with status = 'needs_reauth', or its schedule's
|
|
* last_auto_sync_status = 'error'.
|
|
* Done: reconnect/re-auth, or the next auto-sync succeeds.
|
|
*/
|
|
'backup_failing',
|
|
/**
|
|
* A PSD2 bank consent expires within 14 days.
|
|
* Pending: bank_connections.status = 'active' AND consent_expires within
|
|
* (0, 14] days. A connection that has ALREADY failed is counted
|
|
* by bank_connection_broken instead (status filter makes the two
|
|
* categories disjoint: broken supersedes expiring by construction).
|
|
* Done: the consent is renewed (consent_expires moves out) or the
|
|
* connection expires (moves to bank_connection_broken).
|
|
*/
|
|
'bank_connection_expiring',
|
|
/**
|
|
* The skattekonto does not agree with the ledger after the latest sync.
|
|
* Pending: the skatteverket extension's persisted reconciliation summary
|
|
* (extension_data key skattekonto_reconciliation_latest, written
|
|
* on every sync) has |unexplained_difference| above the drift
|
|
* tolerance (skattekonto_drift_tolerance, default 1 SEK).
|
|
* Done: the next sync computes an unexplained difference within
|
|
* tolerance (rows linked, booked or ignored), or the summary is
|
|
* gone (extension disconnected).
|
|
*/
|
|
'skv_unexplained',
|
|
/**
|
|
* The signed-in account looks bookkeeping-empty while a same-orgnr company
|
|
* with real bookkeeping exists in another account (#1231).
|
|
* Pending: lib/company/other-account-hint shouldShowOtherAccountHint().
|
|
* Done: the account gets bookkeeping of its own, or the user switches.
|
|
*/
|
|
'other_account_hint',
|
|
] as const
|
|
|
|
export type NoticeCategory = (typeof NOTICE_CATEGORIES)[number]
|
|
|
|
export type NoticeSeverity = 'error' | 'warning'
|
|
|
|
/**
|
|
* Fixed cross-category priority: surfaces that show a single notice show the
|
|
* first active one in this order. Tune here, never per call site.
|
|
*/
|
|
export const NOTICE_PRIORITY: readonly NoticeCategory[] = [
|
|
'bank_connection_broken',
|
|
'skv_disconnected',
|
|
'backup_failing',
|
|
'bank_connection_expiring',
|
|
'skv_unexplained',
|
|
'other_account_hint',
|
|
]
|
|
|
|
export interface Notice {
|
|
/**
|
|
* Stable identity of THIS occurrence: the category plus a state
|
|
* discriminator (connection id + status, expiry date). A dismissal is
|
|
* stored against the id, so dismissals silence a state, never a category.
|
|
*
|
|
* Two invariants keep dismissals honest, and every id must satisfy both:
|
|
*
|
|
* 1. Stable per incident: the discriminator must not embed anything the
|
|
* system re-stamps while the SAME incident persists (a cron-updated
|
|
* last-attempt timestamp), or a dismissed notice resurrects daily.
|
|
* backup_failing therefore discriminates on (provider, reason) only.
|
|
* 2. Reaped on recovery: the read path (getCompanyNotices) best-effort
|
|
* deletes the caller's stored dismissals for any category that is
|
|
* currently healthy, matched by the `category:` id prefix. That is what
|
|
* makes a NEW failure after a healthy spell resurface even when it mints
|
|
* the exact same id as the dismissed one: error -> dismiss (hidden while
|
|
* failing) -> healthy (dismissal reaped on the next read) -> new error
|
|
* -> visible again. Categories whose id changes per incident anyway
|
|
* (bank ids embed connection id + status/expiry, skv embeds the
|
|
* incident's first-error/expiry timestamp) get the same reaping as
|
|
* hygiene. other_account_hint has no `category:` prefix and is never
|
|
* reaped: dismissing it silences the condition itself.
|
|
*
|
|
* Ids are also bounded: multi-connection discriminators collapse to a
|
|
* count + 8-char sha256 digest of the sorted parts (categories.ts), so an
|
|
* id never grows with the number of connections and stays well under the
|
|
* dismiss schema cap (lib/api/schemas.ts).
|
|
*/
|
|
id: string
|
|
category: NoticeCategory
|
|
severity: NoticeSeverity
|
|
/** Key in the `notices` i18n namespace. */
|
|
messageKey: string
|
|
/** ICU params for messageKey (bank names, counts, days). */
|
|
messageParams?: Record<string, string | number>
|
|
/** Key in the `notices` namespace for the action link label. */
|
|
actionKey: string
|
|
/** Where the action link goes (client surfaces may override per category). */
|
|
actionHref: string
|
|
}
|