Files
accounted/lib/invoices/editor-payload.ts
T
Jakob Wennberg 2b5b813b7a feat(invoices): rebuild the invoice editor as the snabbflöde single column (#1654)
* refactor(invoices): extract editor payload builders with parity tests

Extract the three near-identical inline payload builders in InvoiceEditor.tsx
(handleConfirm, saveDraftData, saveEdit) and the self-billed body mapper into
pure functions in lib/invoices/editor-payload.ts. Zero behavioral change: the
new lib module carries a 300-case parity suite asserting JSON byte equality
against verbatim copies of the legacy inline recipes across the full
mode x deduction x dimensions x ore-rounding matrix. This is the
byte-compatibility ratchet under the upcoming editor re-layout: the repo
renders no components in tests, so the wire bodies are what CI can pin.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(invoices): rebuild the invoice editor as the snabbflöde single column

Reshape InvoiceEditor to the approved prototype: one 640px column with
uppercase section labels and honest state marks (RequiredMark asterisks,
sage check on a picked customer, muted row counts), a dense in-table rows
surface with a unified last-row entry (autocomplete over the artikelregister,
italic ghost cells, Enter commits free text and lands in the price cell,
ArrowDown+Enter commits an article through the same applyArticle side
effects), hover-revealed 24px row controls with 40px coarse-pointer targets
and per-row aria-labels, a Förval chip line whose collapsed settings
re-surface as chips whenever a value deviates from its default (critical in
edit/copy so PATCH never round-trips invisible values), a single ochre
next-step line (aria-live polite) that doubles as the invalid-submit focus
router, and a sticky bottom action bar with the live total: position sticky
in both hosts, never fixed, since DialogContent's transform re-anchors fixed
children in bare mode.

Behavioral deltas, all pre-decided: the primary action is never disabled
pre-click for writable users (viewers keep the lock+tooltip treatment);
client-side validation failures route focus instead of toasting; genuine
field errors stay terracotta and field-adjacent while the two ochre
disclosures (taxed-where-performed, labor-only) demote to muted text;
committed free-text rows expose a quiet Spara-som-artikel link; the review
dialog lists the applied förval (currency, öre rounding, payment-link
state); a freshly committed row gets a brief background settle that
collapses under prefers-reduced-motion. ArticleCombobox gains the missing
combobox ARIA (listbox/option roles, aria-controls, aria-activedescendant
only after explicit arrowing). New pure module invoice-editor-flow.ts pins
the next-step priority order, the Förval chip derivation and the suggestion
filter with unit tests. All payload builders, submit targets and the VAT
baseline refs are untouched.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): editor review nits: orphaned keys, housing gate, listbox ARIA

Three review findings on the snabbflode editor:

- Delete 13 orphaned invoice_editor keys from both message files
  (subtitle_*, add_row, remove_row, remove_row_aria, details_card_title,
  save_as_draft_short, validation_toast_*, delivery_date_placeholder);
  each verified unused on the branch, sv/en parity kept.
- Gate the housing next-step on a claimed deduction amount so it matches
  the ROT/RUT claim card's mount condition: a ROT-flagged line with a
  zero amount mounts no card, and the ochre link would try to focus an
  unmounted field. Extracted as deriveRequiresHousing in the flow module
  with a test proven to fail on the old gate.
- Move the entry-row popover hint out of the role=listbox element
  (listbox children must be options) into a sibling inside the absolute
  wrapper, referenced via aria-describedby on the combobox input.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* feat(invoices): drop the in-editor faktura/sjalvfaktura tabs

The Ny faktura split button already chooses the mode (?self=1); a second
switcher inside the editor was double steering. The mode is now fixed for
the editor's lifetime and the heading (Registrera sjalvfaktura) carries
the distinction. Orphaned tab keys removed from both message files.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): wrap sticky-bar actions so they fit small viewports

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): stop dialog grid item overflowing small viewports

min-w-0 on the editor root: DialogContent is display:grid, so the row
grid's min-w otherwise forces the column past narrow screens.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(invoices): lift assistant FAB above the standalone editor's action bar

The rebuilt editor introduces the first page-level sticky bottom bar; the
assistant FAB (fixed, z-30) covered its Spara/Granska buttons on the
/invoices/[id]/edit page. The editor now sets body[data-page-bottom-bar]
in non-bare mode and AgentTrigger lifts to bottom-20 when it is present.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-18 09:56:35 +02:00

174 lines
6.0 KiB
TypeScript

/**
* Pure payload builders for the invoice editor (components/invoices/
* InvoiceEditor.tsx). Extracted so the exact request bodies the editor sends
* to POST /api/invoices, PATCH /api/invoices/[id] and POST
* /api/invoices/self-billed are pinned by unit tests: the repo renders no
* components in tests, so these builders are the byte-compatibility ratchet
* under any editor re-layout.
*
* Nothing in here may read component state: every input arrives as an
* argument, every function is a pure mapping from form data to wire body.
*/
/** True when a dimensions bag ({sie_dim_no: code}) carries at least one value. */
export function hasDimensionValues(
dims: Record<string, string> | null | undefined,
): boolean {
return !!dims && Object.keys(dims).length > 0
}
/** The self-billing carrier fields the form always holds (default ''). */
export interface SelfBillingCarrierFields {
external_invoice_number?: string
self_billing_agreement_ref?: string
received_date?: string
}
/** The per-item ROT/RUT fields that are privacy-stripped when unused. */
export interface DeductionItemFields {
deduction_type?: 'rot' | 'rut' | null
labor_hours?: number | null
work_type?: string | null
housing_designation?: string | null
apartment_number?: string | null
brf_org_number?: string | null
}
/**
* Per-item bags ride the payload only when they carry values: the server
* treats an absent bag as "inherit the invoice's default_dimensions".
*/
export function pruneItemDimensions<
T extends { dimensions?: Record<string, string> | null },
>(items: T[]): T[] {
return items.map((item) =>
hasDimensionValues(item.dimensions) ? item : { ...item, dimensions: undefined },
)
}
/**
* The form always carries the self-billing fields (they default to '' in both
* create and edit mode). The editor's normal create/draft/edit flows never
* use self-billing (that goes through /api/invoices/self-billed), so drop the
* empty carriers before spreading the form data into the /api/invoices (or
* PATCH) body: a bare external_invoice_number: '' otherwise trips the shared
* CreateInvoiceSchema's min(1). Belt-and-suspenders; the server schema also
* coerces '' to undefined for these fields.
*/
export function stripSelfBillingFields<T extends SelfBillingCarrierFields>(
data: T,
): Omit<T, keyof SelfBillingCarrierFields> {
const {
external_invoice_number: _ein,
self_billing_agreement_ref: _sbar,
received_date: _rd,
...rest
} = data
return rest
}
/**
* Privacy by default: ROT/RUT line fields are only sent to the API when the
* line actually claims a deduction. Defaults are pre-instantiated as null in
* the form state, but null personal-data fields shouldn't ride along on every
* regular invoice.
*/
export function sanitizeDeductionItems<T extends DeductionItemFields>(
items: T[],
): Array<T | Omit<T, keyof DeductionItemFields>> {
return items.map((item) => {
if (item.deduction_type) return item
const {
deduction_type: _dt,
labor_hours: _lh,
work_type: _wt,
housing_designation: _hd,
apartment_number: _an,
brf_org_number: _bn,
...rest
} = item
return rest
})
}
export interface InvoiceWritePayloadOptions {
/** POST with save_as_draft: true (unnumbered draft, no invoice.created). */
saveAsDraft?: boolean
/** Öresavrundning display flag (component state, not a form field). */
oreRounding: boolean
/** Invoice-level default dims: always sent so an edit can clear them ({} = none). */
defaultDims: Record<string, string>
}
/**
* The one body builder behind "Granska & skapa" (POST), "Spara som utkast"
* (POST + save_as_draft) and edit mode (PATCH). Unifies the three previously
* inline, near-identical builders in InvoiceEditor.tsx: same dimension
* pruning, same ROT/RUT privacy strip, same invoice-level personnummer /
* housing sanitization.
*/
export function buildInvoiceWritePayload<
TItem extends DeductionItemFields & { dimensions?: Record<string, string> | null },
TForm extends SelfBillingCarrierFields & { items: TItem[] },
>(data: TForm, options: InvoiceWritePayloadOptions) {
const anyDeduction = data.items.some((i) => i.deduction_type)
const sanitizedItems = sanitizeDeductionItems(pruneItemDimensions(data.items))
return {
...stripSelfBillingFields(data),
...(options.saveAsDraft ? { save_as_draft: true } : {}),
ore_rounding: options.oreRounding,
default_dimensions: options.defaultDims,
items: sanitizedItems,
// Invoice-level personnummer/housing only ride along when a deduction is
// actually claimed somewhere. undefined keys disappear in JSON.
...(anyDeduction
? {}
: { deduction_personnummer: undefined, deduction_housing_designation: undefined }),
}
}
/** The reduced field set POST /api/invoices/self-billed accepts. */
export interface SelfBilledFormShape {
customer_id: string
external_invoice_number?: string
self_billing_agreement_ref?: string
invoice_date: string
received_date?: string
due_date: string
currency: string
notes?: string
items: Array<{
description: string
quantity: number
unit: string
unit_price: number
vat_rate: number
}>
}
/**
* Body mapper for a mottagen självfaktura (POST /api/invoices/self-billed):
* a faithful revenue-only transcription, so items are reduced to the five
* wire fields and none of the invoice-doc extras (document_type, ROT/RUT,
* payment link, ore_rounding) are sent.
*/
export function buildSelfBilledPayload<T extends SelfBilledFormShape>(data: T) {
return {
customer_id: data.customer_id,
external_invoice_number: data.external_invoice_number,
self_billing_agreement_ref: data.self_billing_agreement_ref || undefined,
invoice_date: data.invoice_date,
received_date: data.received_date,
due_date: data.due_date,
currency: data.currency,
notes: data.notes,
items: data.items.map((i) => ({
description: i.description,
quantity: i.quantity,
unit: i.unit,
unit_price: i.unit_price,
vat_rate: i.vat_rate,
})),
}
}