Files
accounted/lib/hooks/use-detail-pager.ts
T
67febd5097 feat(ui): prev/next record navigation on detail pages (#1530)
* feat(ui): prev/next record navigation on detail pages

Customer feedback: stepping between invoices in a reskontra (56 -> 57 ->
58) required going back to the list for every record.

List pages now write their full ordered id array to sessionStorage when
a row is opened (Accounted:list-context:<scope>:<companyId>), and the
detail pages for kundfakturor, leverantorsfakturor, and verifikat show
a compact prev/next pager (chevrons + 'n av m') next to the back
control. ArrowLeft/ArrowRight step too, except while typing in a text
field or while a dialog is open. Navigation uses router.replace so
'tillbaka' returns to the list in one step. Deep links and new tabs
have no context: the pager hides and pages behave as before.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(pager): overlay-aware arrow guard, notes-draft safety, context on Visa detaljer

Review fixes on the detail-record pager:

- The keyboard guard matched any mounted [role=dialog], so the agent
  sheet (which stays mounted display:none once opened) killed arrow
  paging for the rest of the tab session, while open dropdown menus
  did not block at all. The guard now mirrors the AgentSheet Esc
  selector (data-state="open" variants incl. alertdialog and radix
  menu/select/listbox content) and also yields while focus sits inside
  a dialog/menu/listbox container. Extracted as pure functions in
  lib/hooks/detail-pager-guards.ts so the rules are testable in the
  node test environment.
- Arrow keys could unmount the verifikat page and destroy an unsaved
  notes draft once the textarea lost focus. useDetailPager and
  DetailPager now take a keyboard flag, and the verifikat page
  disables keyboard paging while editingNotes is active; the chevron
  buttons stay live.
- The expanded-row Visa detaljer link in JournalEntryList navigated
  without writing the list context, producing stale pager snapshots;
  it now calls rememberListContext like the voucher link.
- ListContext.listPath was written and strictly validated but never
  consumed: removed from the interface, all writers, and the read
  validation. Reads stay tolerant of extra properties so contexts
  stored by older builds still parse.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* refactor(pager): quiet wayfinding strip instead of buttons in the title cluster

The pager sat between the back arrow and the H1, which read as a toolbar
of three boxed buttons and made the title jump horizontally per record.
All three detail pages now share the verifikat page's pattern: a muted
back text-link on the left and the pager right-aligned on the same quiet
row. The pager itself drops to 16px glyphs, muted ink, and hides when the
list context holds a single record.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-12 21:07:57 +02:00

94 lines
3.0 KiB
TypeScript

'use client'
import { useCallback, useEffect, useMemo, useState } from 'react'
import { useRouter } from 'next/navigation'
import {
computeNeighbors,
readListContext,
type ListContext,
} from '@/lib/navigation/list-context'
import { resolveArrowKeyAction } from '@/lib/hooks/detail-pager-guards'
export interface DetailPager {
prevId: string | null
nextId: string | null
/** 1-based position, null when no list context exists (deep link/new tab). */
index: number | null
total: number | null
goPrev: () => void
goNext: () => void
}
export interface DetailPagerOptions {
/**
* Set false to suspend the ArrowLeft/ArrowRight bindings entirely, e.g.
* while an inline editor with unsaved state is open (paging unmounts the
* page and would destroy the draft). Buttons stay active.
*/
keyboard?: boolean
}
/**
* Prev/next record navigation for detail pages, backed by the list context
* the originating list page wrote to sessionStorage (lib/navigation/
* list-context.ts). Also binds ArrowLeft/ArrowRight while no text field or
* open overlay (dialog, menu, listbox) owns the keys; see
* lib/hooks/detail-pager-guards.ts for the exact rules. When no context
* exists everything is null and the pager UI hides; the detail page degrades
* gracefully.
*/
export function useDetailPager(
contextKey: string,
basePath: string,
currentId: string,
options?: DetailPagerOptions,
): DetailPager {
const keyboard = options?.keyboard ?? true
const router = useRouter()
const [context, setContext] = useState<ListContext | null>(null)
// Read in an effect, not during render: sessionStorage does not exist on
// the server and reading it pre-hydration would mismatch the SSR HTML.
useEffect(() => {
setContext(readListContext(contextKey))
}, [contextKey])
const neighbors = useMemo(
() => (context ? computeNeighbors(context.ids, currentId) : null),
[context, currentId],
)
const prevId = neighbors?.prevId ?? null
const nextId = neighbors?.nextId ?? null
// router.replace, deliberately not push: stepping through records is one
// browsing act, so "tillbaka" returns to the list in a single step instead
// of walking back through every viewed record.
const goPrev = useCallback(() => {
if (prevId) router.replace(`${basePath}/${prevId}`)
}, [basePath, prevId, router])
const goNext = useCallback(() => {
if (nextId) router.replace(`${basePath}/${nextId}`)
}, [basePath, nextId, router])
useEffect(() => {
if (!neighbors || !keyboard) return
const onKeyDown = (e: KeyboardEvent) => {
const action = resolveArrowKeyAction(e, document)
if (action === 'prev') goPrev()
else if (action === 'next') goNext()
}
window.addEventListener('keydown', onKeyDown)
return () => window.removeEventListener('keydown', onKeyDown)
}, [neighbors, keyboard, goPrev, goNext])
return {
prevId,
nextId,
index: neighbors?.index ?? null,
total: neighbors?.total ?? null,
goPrev,
goNext,
}
}