Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
112 lines
3.3 KiB
TypeScript
112 lines
3.3 KiB
TypeScript
import { describe, it, expect, beforeEach, vi } from 'vitest'
|
|
import { eventBus } from '../bus'
|
|
import type { JournalEntry } from '@/types'
|
|
|
|
const fakeEntry = { id: 'e1' } as JournalEntry
|
|
|
|
beforeEach(() => {
|
|
eventBus.clear()
|
|
})
|
|
|
|
describe('EventBus', () => {
|
|
it('on() subscribes a handler and returns an unsubscribe function', () => {
|
|
const handler = vi.fn()
|
|
const unsub = eventBus.on('journal_entry.drafted', handler)
|
|
|
|
expect(typeof unsub).toBe('function')
|
|
})
|
|
|
|
it('emit() calls all handlers for that event type', async () => {
|
|
const handler1 = vi.fn()
|
|
const handler2 = vi.fn()
|
|
|
|
eventBus.on('journal_entry.committed', handler1)
|
|
eventBus.on('journal_entry.committed', handler2)
|
|
|
|
await eventBus.emit({
|
|
type: 'journal_entry.committed',
|
|
payload: { entry: fakeEntry, userId: 'u1', companyId: 'company-1' },
|
|
})
|
|
|
|
expect(handler1).toHaveBeenCalledWith({ entry: fakeEntry, userId: 'u1', companyId: 'company-1' })
|
|
expect(handler2).toHaveBeenCalledWith({ entry: fakeEntry, userId: 'u1', companyId: 'company-1' })
|
|
})
|
|
|
|
it('emit() uses Promise.allSettled: a failing handler does not crash others', async () => {
|
|
const failingHandler = vi.fn().mockRejectedValue(new Error('boom'))
|
|
const goodHandler = vi.fn()
|
|
|
|
eventBus.on('journal_entry.committed', failingHandler)
|
|
eventBus.on('journal_entry.committed', goodHandler)
|
|
|
|
// Should not throw
|
|
await eventBus.emit({
|
|
type: 'journal_entry.committed',
|
|
payload: { entry: fakeEntry, userId: 'u1', companyId: 'company-1' },
|
|
})
|
|
|
|
expect(failingHandler).toHaveBeenCalled()
|
|
expect(goodHandler).toHaveBeenCalled()
|
|
})
|
|
|
|
it('emit() with no handlers is a no-op', async () => {
|
|
// Should not throw
|
|
await eventBus.emit({
|
|
type: 'journal_entry.drafted',
|
|
payload: { entry: fakeEntry, userId: 'u1', companyId: 'company-1' },
|
|
})
|
|
})
|
|
|
|
it('unsubscribe removes the handler, future emits do not call it', async () => {
|
|
const handler = vi.fn()
|
|
const unsub = eventBus.on('journal_entry.committed', handler)
|
|
|
|
unsub()
|
|
|
|
await eventBus.emit({
|
|
type: 'journal_entry.committed',
|
|
payload: { entry: fakeEntry, userId: 'u1', companyId: 'company-1' },
|
|
})
|
|
|
|
expect(handler).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('clear() removes all handlers', async () => {
|
|
const handler1 = vi.fn()
|
|
const handler2 = vi.fn()
|
|
|
|
eventBus.on('journal_entry.committed', handler1)
|
|
eventBus.on('journal_entry.drafted', handler2)
|
|
|
|
eventBus.clear()
|
|
|
|
await eventBus.emit({
|
|
type: 'journal_entry.committed',
|
|
payload: { entry: fakeEntry, userId: 'u1', companyId: 'company-1' },
|
|
})
|
|
await eventBus.emit({
|
|
type: 'journal_entry.drafted',
|
|
payload: { entry: fakeEntry, userId: 'u1', companyId: 'company-1' },
|
|
})
|
|
|
|
expect(handler1).not.toHaveBeenCalled()
|
|
expect(handler2).not.toHaveBeenCalled()
|
|
})
|
|
|
|
it('handlers for different event types do not interfere', async () => {
|
|
const committedHandler = vi.fn()
|
|
const draftedHandler = vi.fn()
|
|
|
|
eventBus.on('journal_entry.committed', committedHandler)
|
|
eventBus.on('journal_entry.drafted', draftedHandler)
|
|
|
|
await eventBus.emit({
|
|
type: 'journal_entry.committed',
|
|
payload: { entry: fakeEntry, userId: 'u1', companyId: 'company-1' },
|
|
})
|
|
|
|
expect(committedHandler).toHaveBeenCalledOnce()
|
|
expect(draftedHandler).not.toHaveBeenCalled()
|
|
})
|
|
})
|