69c537fd1f
A verifikat booked from a supplier invoice showed the invoice PDF when opened while the list kept warning "Underlag saknas" on the same row. Both surfaces behaved as written: every missing-underlag surface only accepts a referenced supplier-invoice document when it is ANCHORED to a journal entry (only anchored docs sit behind block_document_deletion), while the verifikat view's reference resolver displayed the document regardless. The document was floating because delete_last_voucher clears journal_entry_id on everything attached to the voucher it tears down (the FK is ON DELETE RESTRICT, so it must). Deleting a rättelse the invoice PDF had been relinked onto therefore orphaned it while the payment verifikat stayed posted, and nothing ever anchored it again: the warning was unresolvable by design. Same class one surface over: v1 mark-paid never linked the document at all, dashboard mark-paid only did so for the cash entry, and both match-supplier-invoice routes propagated the transaction's document but not the invoice's own. Four of the five affected prod rows come from those paths, not from a deleted voucher. - lib/core/documents/supplier-invoice-underlag.ts: anchor a floating document to the invoice's own posted verifikat (registration, then payment, then partial payments; open unlocked periods only). Never moves an anchored doc, never throws. - Called after delete_last_voucher and from all four payment paths. - getJournalEntryUnderlagReferences withholds an unanchored document so the verifikat view and the warning can no longer contradict each other. - Migration 20260727180000 backfills the rows already in this state. Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
198 lines
8.3 KiB
TypeScript
198 lines
8.3 KiB
TypeScript
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
import { fetchAllRows } from '@/lib/supabase/fetch-all'
|
|
|
|
/**
|
|
* A followable reference from a verifikation back to its underlag: the customer
|
|
* or supplier invoice that identifies what the affärshändelse avser and who the
|
|
* motpart is.
|
|
*
|
|
* Surfacing these makes the verifieringskedja traceable from the verifikat side,
|
|
* not only from the invoice side (BFL 5 kap 7§: hänvisning till underlag;
|
|
* BFNAR 2013:2: the verification chain must be followable in both directions).
|
|
*
|
|
* Bank transactions are deliberately excluded: a bank line is the trace of the
|
|
* affärshändelse, not its underlag. Counting it as underlag would wrongly silence
|
|
* the "saknar underlag" warning for expenses that still genuinely need a kvitto.
|
|
*/
|
|
export type UnderlagReferenceType = 'invoice' | 'supplier_invoice'
|
|
|
|
export interface UnderlagReference {
|
|
type: UnderlagReferenceType
|
|
id: string
|
|
/** invoice_number / supplier_invoice_number: the UI builds the label from this. */
|
|
number: string
|
|
/**
|
|
* Retained source document owned by a referenced supplier invoice, if any.
|
|
*
|
|
* Set ONLY when the document is anchored to a journal entry
|
|
* (document_attachments.journal_entry_id IS NOT NULL), because that is the
|
|
* exact condition every missing-underlag surface uses: the
|
|
* verifikat_without_documents / transactions_without_documents RPCs,
|
|
* /api/documents/counts and the transactions list all require an anchored
|
|
* doc, since only anchored docs sit behind the WORM deletion guards. Handing
|
|
* out a floating doc here made the verifikat view display an underlag while
|
|
* the list kept warning "Underlag saknas" on the same row (support case
|
|
* 2026-07-27). The reference itself is still returned either way, so the
|
|
* verifieringskedja stays followable; only the attachment claim is withheld.
|
|
*/
|
|
document_id?: string
|
|
}
|
|
|
|
interface InvoiceRow {
|
|
id: string
|
|
invoice_number: string
|
|
}
|
|
|
|
interface SupplierInvoiceRow {
|
|
id: string
|
|
supplier_invoice_number: string
|
|
document_id?: string | null
|
|
/** Embedded document row; see UnderlagReference.document_id for why. */
|
|
document?: { journal_entry_id: string | null } | { journal_entry_id: string | null }[] | null
|
|
}
|
|
|
|
/** Columns every supplier-invoice lookup below needs, incl. the anchor check. */
|
|
const SUPPLIER_INVOICE_COLUMNS =
|
|
'id, supplier_invoice_number, document_id, document:document_attachments(journal_entry_id)'
|
|
|
|
/**
|
|
* A supplier invoice's document only counts as this verifikation's underlag
|
|
* when it is anchored to a journal entry: an unanchored doc is outside the WORM
|
|
* deletion guards, so the missing-underlag surfaces refuse to accept it and
|
|
* this resolver must refuse too.
|
|
*/
|
|
function anchoredDocumentId(row: SupplierInvoiceRow): string | undefined {
|
|
if (!row.document_id) return undefined
|
|
const document = Array.isArray(row.document) ? row.document[0] : row.document
|
|
return document?.journal_entry_id ? row.document_id : undefined
|
|
}
|
|
|
|
/**
|
|
* Resolve every customer/supplier invoice linked to a verifikation, across all
|
|
* the deterministic FK paths the engine uses to book one:
|
|
* - invoices.journal_entry_id (faktureringsmetod registration / direct)
|
|
* - invoice_payments.journal_entry_id (kontantmetod inbetalning / delbetalning)
|
|
* - supplier_invoices.registration_journal_entry_id / payment_journal_entry_id
|
|
* - supplier_invoice_payments.journal_entry_id (delbetalning)
|
|
*
|
|
* Every query is company-scoped (defense in depth alongside RLS). Results are
|
|
* deduplicated by id, so an invoice reachable via several paths appears once.
|
|
*/
|
|
export async function getJournalEntryUnderlagReferences(
|
|
supabase: SupabaseClient,
|
|
companyId: string,
|
|
journalEntryId: string,
|
|
): Promise<UnderlagReference[]> {
|
|
// --- Customer invoices ---------------------------------------------------
|
|
const invoices = new Map<string, string>()
|
|
|
|
// Direct link (faktureringsmetod registration, or invoices.journal_entry_id).
|
|
const directInvoices = await fetchAllRows<InvoiceRow>(({ from, to }) =>
|
|
supabase.from('invoices').select('id, invoice_number')
|
|
.eq('company_id', companyId).eq('journal_entry_id', journalEntryId)
|
|
.order('id', { ascending: true }).range(from, to),
|
|
)
|
|
|
|
for (const inv of (directInvoices ?? []) as InvoiceRow[]) {
|
|
invoices.set(inv.id, inv.invoice_number)
|
|
}
|
|
|
|
// Payment rows (kontantmetod inbetalning, partial payments) → invoice_payments.
|
|
const paymentRows = await fetchAllRows<{ id: string; invoice_id: string | null }>(({ from, to }) =>
|
|
supabase.from('invoice_payments').select('id, invoice_id')
|
|
.eq('journal_entry_id', journalEntryId).order('id', { ascending: true }).range(from, to),
|
|
)
|
|
|
|
const paymentInvoiceIds = new Set<string>()
|
|
for (const row of (paymentRows ?? []) as { invoice_id: string | null }[]) {
|
|
if (row.invoice_id && !invoices.has(row.invoice_id)) paymentInvoiceIds.add(row.invoice_id)
|
|
}
|
|
|
|
if (paymentInvoiceIds.size > 0) {
|
|
const paidInvoices = await fetchAllRows<InvoiceRow>(({ from, to }) =>
|
|
supabase.from('invoices').select('id, invoice_number')
|
|
.eq('company_id', companyId).in('id', Array.from(paymentInvoiceIds))
|
|
.order('id', { ascending: true }).range(from, to),
|
|
)
|
|
|
|
for (const inv of (paidInvoices ?? []) as InvoiceRow[]) {
|
|
invoices.set(inv.id, inv.invoice_number)
|
|
}
|
|
}
|
|
|
|
// --- Supplier invoices ---------------------------------------------------
|
|
const supplierInvoices = new Map<string, { number: string; documentId?: string }>()
|
|
|
|
// Registration booking (accrual) on the invoice itself.
|
|
const registrationLinks = await fetchAllRows<SupplierInvoiceRow>(({ from, to }) =>
|
|
supabase.from('supplier_invoices').select(SUPPLIER_INVOICE_COLUMNS)
|
|
.eq('company_id', companyId).eq('registration_journal_entry_id', journalEntryId)
|
|
.order('id', { ascending: true }).range(from, to),
|
|
)
|
|
|
|
for (const si of (registrationLinks ?? []) as SupplierInvoiceRow[]) {
|
|
const documentId = anchoredDocumentId(si)
|
|
supplierInvoices.set(si.id, {
|
|
number: si.supplier_invoice_number,
|
|
...(documentId ? { documentId } : {}),
|
|
})
|
|
}
|
|
|
|
// Payment booking on the invoice itself.
|
|
const paymentLinks = await fetchAllRows<SupplierInvoiceRow>(({ from, to }) =>
|
|
supabase.from('supplier_invoices').select(SUPPLIER_INVOICE_COLUMNS)
|
|
.eq('company_id', companyId).eq('payment_journal_entry_id', journalEntryId)
|
|
.order('id', { ascending: true }).range(from, to),
|
|
)
|
|
|
|
for (const si of (paymentLinks ?? []) as SupplierInvoiceRow[]) {
|
|
const documentId = anchoredDocumentId(si)
|
|
supplierInvoices.set(si.id, {
|
|
number: si.supplier_invoice_number,
|
|
...(documentId ? { documentId } : {}),
|
|
})
|
|
}
|
|
|
|
// Partial-payment rows → supplier_invoice_payments.
|
|
const supplierPaymentRows = await fetchAllRows<{ id: string; supplier_invoice_id: string | null }>(
|
|
({ from, to }) => supabase.from('supplier_invoice_payments').select('id, supplier_invoice_id')
|
|
.eq('journal_entry_id', journalEntryId).order('id', { ascending: true }).range(from, to),
|
|
)
|
|
|
|
const supplierPaymentIds = new Set<string>()
|
|
for (const row of (supplierPaymentRows ?? []) as { supplier_invoice_id: string | null }[]) {
|
|
if (row.supplier_invoice_id && !supplierInvoices.has(row.supplier_invoice_id)) {
|
|
supplierPaymentIds.add(row.supplier_invoice_id)
|
|
}
|
|
}
|
|
|
|
if (supplierPaymentIds.size > 0) {
|
|
const paidSupplierInvoices = await fetchAllRows<SupplierInvoiceRow>(({ from, to }) =>
|
|
supabase.from('supplier_invoices').select(SUPPLIER_INVOICE_COLUMNS)
|
|
.eq('company_id', companyId).in('id', Array.from(supplierPaymentIds))
|
|
.order('id', { ascending: true }).range(from, to),
|
|
)
|
|
|
|
for (const si of (paidSupplierInvoices ?? []) as SupplierInvoiceRow[]) {
|
|
const documentId = anchoredDocumentId(si)
|
|
supplierInvoices.set(si.id, {
|
|
number: si.supplier_invoice_number,
|
|
...(documentId ? { documentId } : {}),
|
|
})
|
|
}
|
|
}
|
|
|
|
// --- Assemble ------------------------------------------------------------
|
|
const references: UnderlagReference[] = []
|
|
for (const [id, number] of invoices) references.push({ type: 'invoice', id, number })
|
|
for (const [id, supplierInvoice] of supplierInvoices) {
|
|
references.push({
|
|
type: 'supplier_invoice',
|
|
id,
|
|
number: supplierInvoice.number,
|
|
...(supplierInvoice.documentId ? { document_id: supplierInvoice.documentId } : {}),
|
|
})
|
|
}
|
|
return references
|
|
}
|