Files
accounted/lib/company/__tests__/first-year-defaults.test.ts
T
b436d47b64 feat(mcp): onboarding flow v2: migration-first SIE import in chat, one-confirm momentum, extended first-year heuristic (#1949)
Three changes from the first real E2E run (Arcim, 2026-08-26):

1. gnubok_sie_preflight: read-only scan of a SIE file shared in chat
   BEFORE anything is staged: parse, validate (per-verifikat balance, IB,
   closed-year P&L residual), CP1252-mojibake tripwire, duplicate
   file/period check, org-number match against the company (the
   wrong-company import is the worst silent failure this flow can have),
   and suggested account mappings shaped for direct passthrough to
   gnubok_import_sie. Both tools now also accept file_content_base64,
   decoded with the same encoding detection as the HTTP upload route so
   CP437 exports keep their åäö.

2. Onboarding skill v2: opens with TWO questions (orgnr + 'vilket system
   hade du innan?'), imports history before the bank (PSD2 rarely reaches
   far enough back), and a momentum rule: the create preview is the ONLY
   stop; connect tools are called without asking, and categorization
   starts as soon as the bank is active. connect_bank instructions now
   describe the account-selection dialog that actually gates the first
   sync, and the bank history cap.

3. deriveFirstYearDefaults: no closed fiscal period in the registry now
   extends the first-year window from 12 to 18 months (BFL 3 kap 3 §):
   a 13-month-old company with no annual report is still in its first,
   extended räkenskapsår (the Arcim case the 12-month rule missed).
   Applied in the web journey and the lookup tool.

tools/list ceiling 61.5K to 62K, documented in the bench.

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-26 14:16:40 +02:00

76 lines
2.9 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import { deriveFirstYearDefaults, parseStartMonthDay } from '../first-year-defaults'
const NOW = new Date('2026-07-24T12:00:00Z').getTime()
const MONTH_MS = 1000 * 60 * 60 * 24 * 30.44
describe('parseStartMonthDay', () => {
it('parses a TIC MM-DD into the start month', () => {
expect(parseStartMonthDay('07-01')).toBe(7)
expect(parseStartMonthDay('1-15')).toBe(1)
expect(parseStartMonthDay('12-31')).toBe(12)
})
it('returns null for missing input', () => {
expect(parseStartMonthDay(null)).toBeNull()
expect(parseStartMonthDay(undefined)).toBeNull()
expect(parseStartMonthDay('')).toBeNull()
})
it('returns null for malformed or out-of-range input', () => {
expect(parseStartMonthDay('July 1')).toBeNull()
expect(parseStartMonthDay('2026-07-01')).toBeNull()
expect(parseStartMonthDay('13-01')).toBeNull()
expect(parseStartMonthDay('0-15')).toBeNull()
})
})
describe('deriveFirstYearDefaults', () => {
it('pre-checks first year for a company registered 11 months ago', () => {
const registered = NOW - 11 * MONTH_MS
const result = deriveFirstYearDefaults(registered, NOW)
expect(result.isFirstFiscalYear).toBe(true)
expect(result.firstYearStart).toBeDefined()
})
it('does not pre-check for a company registered 13 months ago', () => {
const registered = NOW - 13 * MONTH_MS
expect(deriveFirstYearDefaults(registered, NOW)).toEqual({
isFirstFiscalYear: false,
firstYearStart: undefined,
})
})
it('does not pre-check at exactly 12 months', () => {
const registered = NOW - 12 * MONTH_MS
expect(deriveFirstYearDefaults(registered, NOW).isFirstFiscalYear).toBe(false)
})
it('extends the window to 18 months when the registry shows no closed period', () => {
// Extended first räkenskapsår (BFL 3 kap 3 §): registered 13 months ago
// with no annual report filed is still the first year.
const registered = NOW - 13 * MONTH_MS
expect(
deriveFirstYearDefaults(registered, NOW, { noClosedPeriod: true }).isFirstFiscalYear
).toBe(true)
expect(
deriveFirstYearDefaults(NOW - 19 * MONTH_MS, NOW, { noClosedPeriod: true }).isFirstFiscalYear
).toBe(false)
})
it('seeds first_year_start as the 1st of the UTC registration month', () => {
const registered = new Date('2026-03-14T10:00:00Z').getTime()
const result = deriveFirstYearDefaults(registered, NOW)
expect(result.isFirstFiscalYear).toBe(true)
expect(result.firstYearStart).toBe('2026-03-01')
})
it('returns falsy defaults for missing or invalid registration dates', () => {
const empty = { isFirstFiscalYear: false, firstYearStart: undefined }
expect(deriveFirstYearDefaults(null, NOW)).toEqual(empty)
expect(deriveFirstYearDefaults(undefined, NOW)).toEqual(empty)
expect(deriveFirstYearDefaults(0, NOW)).toEqual(empty)
expect(deriveFirstYearDefaults(Number.NaN, NOW)).toEqual(empty)
})
})