Files
accounted/lib/calendar/__tests__/utils.test.ts
T
Jakob Wennberg aead2bc1d1 fix(ui): stop mislabeling unconverted FX amounts as kr in aggregates and toasts (#1182)
Fixes #1173. invoices.total_sek stays NULL when the Riksbanken rate
fetch fails at creation, and every `total_sek || total` fallback then
treated a raw foreign amount as kronor:

- lib/calendar/utils: new invoiceSekAmount() returns null for
  unconverted non-SEK invoices; period summaries and day totals skip
  them and PeriodSummary exposes unconvertedCount. PaymentSummaryCard
  shows a one-line note when invoices were excluded; CalendarDayView
  renders each invoice in its own currency instead.
- Deadlines page: the overdue attn sum now skips unconverted FX
  invoices and appends "(+N i utlandsk valuta)" instead of adding EUR
  into a kr total.
- Supplier-invoice payment toast formats the amount with the invoice's
  currency (key drops its hardcoded " kr" in both locales).
- AR aging drill-down row labels Betalt with the invoice currency,
  mirroring the outstanding cell.
- BankFileColumnMappingStep: comment pinning why SEK is safe there
  (generic-csv hardcodes it).

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-07-25 12:59:14 +02:00

58 lines
2.2 KiB
TypeScript

import { describe, it, expect } from 'vitest'
import { invoiceSekAmount, calculatePeriodSummary, createPaymentCalendarDay } from '../utils'
import { makeInvoice } from '@/tests/helpers'
describe('invoiceSekAmount', () => {
it('prefers the stored SEK conversion', () => {
const inv = makeInvoice({ total: 100, total_sek: 1150, currency: 'EUR' })
expect(invoiceSekAmount(inv)).toBe(1150)
})
it('uses total directly for SEK invoices without a conversion', () => {
const inv = makeInvoice({ total: 100, total_sek: null, currency: 'SEK' })
expect(invoiceSekAmount(inv)).toBe(100)
})
it('returns null for a non-SEK invoice without a stored conversion', () => {
// total_sek stays NULL when the rate fetch failed at creation: the raw
// EUR total must never be treated as kronor.
const inv = makeInvoice({ total: 100, total_sek: null, currency: 'EUR' })
expect(invoiceSekAmount(inv)).toBeNull()
})
})
describe('calculatePeriodSummary', () => {
it('excludes unconverted foreign invoices from totals and counts them', () => {
const past = '2000-01-01'
const invoices = [
makeInvoice({ status: 'sent', due_date: past, total: 1000, total_sek: null, currency: 'SEK' }),
// Unconverted EUR invoice: counted, never summed as kr.
makeInvoice({ status: 'sent', due_date: past, total: 500, total_sek: null, currency: 'EUR' }),
makeInvoice({ status: 'paid', total: 200, total_sek: 2300, currency: 'EUR' }),
]
const summary = calculatePeriodSummary(invoices)
expect(summary.totalExpected).toBe(1000)
expect(summary.totalOverdue).toBe(1000)
expect(summary.totalPaid).toBe(2300)
expect(summary.pendingCount).toBe(2)
expect(summary.unconvertedCount).toBe(1)
})
})
describe('createPaymentCalendarDay', () => {
it('skips unconverted foreign invoices in the day total', () => {
const date = '2026-07-25'
const invoices = [
makeInvoice({ status: 'sent', due_date: date, total: 1000, total_sek: null, currency: 'SEK' }),
makeInvoice({ status: 'sent', due_date: date, total: 500, total_sek: null, currency: 'EUR' }),
]
const day = createPaymentCalendarDay(date, invoices)
expect(day.totalExpected).toBe(1000)
expect(day.invoices).toHaveLength(2)
})
})