Files
accounted/lib/bookkeeping/bas-lazy.ts
T
Jakob Wennberg 1a41119682 perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline (#1942)
* perf(bundle): drop the BAS chart and the Node crypto polyfill from the shared client baseline

Two chunks rode along in the first-load JS of almost every dashboard route:
the full BAS 2026 chart (315 KB uncompressed, in 81 route manifests) and
the browser polyfill for Node's crypto/vm/Buffer (327 KB, in 26 routes
incl. login and register). Neither was needed on first paint; both got
there through static imports of helpers that happen to live next to code
that needs the data or the builtin.

Node polyfill (4 pure splits, behaviour unchanged, re-exported from the
original modules for server callers):
- lib/auth/bankid-flags.ts: isBankIdEnabled (login, register, security
  settings imported it from bankid.ts, which imports crypto).
- lib/import/bank-file/formats.ts: the format registry + detection (the
  import history imported getFormat from parser.ts, which hashes).
- lib/salary/personnummer-format.ts: parsing/validation/formatting (the
  employee forms reached the encrypting personnummer.ts via tax-column).
- lib/auth/api-key-scopes.ts: scope catalogue, groups, tool map, helpers
  (the API key panel imported STAGING_SCOPES from the key generator).

BAS chart:
- lib/bookkeeping/bas-lazy.ts + use-bas-reference.ts: the chart becomes a
  dynamic import, fetched once per session after first paint; components
  that show BAS names/descriptions call useBasReference() and re-render
  when it lands. Until then (and on the server) only the hardcoded
  account-descriptions answer, so SSR and hydration agree.
- lib/bookkeeping/bas-labels.ts: class/group labels out of bas-reference.ts
  (account-descriptions needed a label and paid for the whole chart).
- lib/bookkeeping/bas-account-numbers.ts (generated, ~11 KB) +
  scripts/generate-bas-account-numbers.ts (--check) + parity test:
  isStandardBASAccountNumber for AddAccountDialog/ChartOfAccountsManager.
- lib/bookkeeping/account-classifier-{heuristic,client}.ts: the BAS-aligned
  heuristic shared by the server classifier and a client variant that uses
  the lazy chart.
- lib/bookkeeping/invoice-accounts.ts: INVOICE_FX_RATE_MISSING,
  InvoiceFxRateMissingError, getRevenueAccount, getOutputVatAccount out of
  invoice-entries.ts, whose engine import pulled account-backfill and the
  chart into SendInvoiceDialog/PaymentBookingDialog.
- CorrectOpeningBalanceDialog re-seeds names when the chart lands;
  OpeningBalanceRowEditor builds its Fuse indexes lazily; the
  ChartOfAccountsManager BAS-katalog tab awaits the chunk.

Tooling:
- scripts/perf/client-import-closure.mjs: static import closure of every
  'use client' module with the shortest chain to a target (file or bare
  specifier); found every path above without a build.
- scripts/checks/client-node-builtin.mjs wired into check:guards: a client
  module reaching a Node builtin is a hard failure (0 today).

Left as is: invoices/[id], its credit page and SendInvoiceDialog still
reach the chart through lib/invoices/issue-credit-note -> invoice-entries
-> engine -> account-backfill; splitting the engine is out of scope here.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* fix(perf): unambiguous import-edge regex in the closure walker (CodeQL js/redos)

One quantifier per span: a greedy [^'"]* up to the specifier quote, which it
cannot cross, so a run of whitespace has a single parse. Same edges as
before (multi-line named imports, re-exports, side-effect imports; type-only
imports still skipped).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

---------

Co-authored-by: Jakob Wennberg <311770904+jakobwennberg-oss@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-26 15:07:49 +02:00

60 lines
1.9 KiB
TypeScript

/**
* Lazily loaded BAS chart for client code.
*
* The full chart (lib/bookkeeping/bas-data, ~1,276 accounts, 315 KB
* uncompressed) used to be statically imported by lib/bookkeeping/
* account-descriptions.ts and, through AccountCombobox and ui/account-number,
* ended up in the shared client bundle of 81 dashboard routes. Here it is a
* dynamic import: one code-split chunk, fetched once per session after first
* paint, and only by surfaces that actually show BAS names or descriptions.
*
* Server code keeps importing bas-reference / bas-data statically.
*/
import type { BASReferenceAccount } from './bas-reference'
let loaded: BASReferenceAccount[] | null = null
let byNumber: Map<string, BASReferenceAccount> | null = null
let loading: Promise<BASReferenceAccount[]> | null = null
const listeners = new Set<() => void>()
/** Start (or join) the chunk load. Resolves with the full chart. */
export function ensureBasLoaded(): Promise<BASReferenceAccount[]> {
if (loaded) return Promise.resolve(loaded)
if (!loading) {
loading = import('./bas-data')
.then(({ BAS_REFERENCE }) => {
loaded = BAS_REFERENCE
byNumber = new Map(BAS_REFERENCE.map((a) => [a.account_number, a]))
for (const listener of listeners) listener()
return BAS_REFERENCE
})
.catch((err) => {
loading = null
throw err
})
}
return loading
}
/** The chart if the chunk has arrived, else null (never blocks). */
export function getBasLoaded(): BASReferenceAccount[] | null {
return loaded
}
export function getBasLoadedByNumber(accountNumber: string): BASReferenceAccount | undefined {
return byNumber?.get(accountNumber)
}
export function isBasLoaded(): boolean {
return loaded !== null
}
/** Subscribe to "the chunk arrived" (useSyncExternalStore contract). */
export function subscribeBasLoaded(listener: () => void): () => void {
listeners.add(listener)
return () => {
listeners.delete(listener)
}
}