Files
accounted/lib/auth/brand-signup-gate.ts
T
MattssonandClaude Fable 5 4f6ecad549 feat(white-label): invite-only signup for brand domains (#1995)
* feat(white-label): invite-only signup for brand domains

A brand domain belongs to the partner's people (founder decision
2026-08-27): only allowlisted or invited users may create an account on
an invite-only brand domain; everyone else is shown an interstitial that
sends them to the canonical Accounted signup.

- brands.signup_mode ('open' default / 'invite_only') +
  brand_signup_allowlist (lowercase emails, team-scoped RLS, owner/admin
  writes) + create_company_for_brand_signup RPC, with pg-real coverage
- server-side gate (lib/auth/brand-signup-gate.ts) enforced on every
  signup path: email signup moved to POST /api/auth/signup (the browser
  used to call GoTrue directly, so a client-side check would be
  bypassable), BankID gated in /bankid/complete, Google covered by the
  dashboard layout's brand-domain bounce
- company invites bypass the allowlist: the invite is the authorization
- register page interstitial on gated brands (no email in the outbound
  URL), sv+en strings
- dashboard layout bounces non-belonging sessions off gated brand hosts
  to the canonical domain (navigation rule like WL-01, not a security
  boundary)
- allowlisted signups' onboarding-created companies attach to the
  brand's byra team via the new RPC, so WL-01 homes them on the brand
  domain; the allowlist entry recorded by an owner/admin stands in for
  the WL-15 admin gate
- byra cockpit page /clients/access + /api/clients/signup-access to
  manage the mode and the allowlist

All existing brands default to 'open': behavior is byte-identical until
a brand is flipped to invite_only.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ByL5dQXG8gGLtNBPj8g2C4

* fix(white-label): rollback brand-signup company with the service client

Skeptic (correctness) found that a brand-signup company created under the
service role rolled back with the cookie-session client: `companies` has
RLS and no FOR DELETE policy, so the delete was a silent 0-row no-op,
stranding a member-less ghost company on the partner's byra team. Pass an
optional rollbackClient to createCompanyCore and hand it the service
client on that path; user_preferences.active_company_id then clears itself
via its ON DELETE SET NULL FK once the company row is actually deleted.

Also map a validateBody 400 (flat envelope, no code) on the register page
to the specific email-invalid field message instead of the generic one,
since the client already pre-gates password strength.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ByL5dQXG8gGLtNBPj8g2C4

* fix(white-label): fail-safe brand lookup, pg-test seed, anonymize fixtures

Second resolve-pr cycle: skeptic + CodeRabbit findings and a green-up.

- Fail safe on a brands-table error (CodeRabbit CWE-285): the gate treated a
  failed resolveBrandByHost as an unbranded host, opening invite-only signup
  during a transient DB blip. resolveBrandResultByHost now distinguishes
  "no brand" from "lookup failed"; the gate returns lookupFailed and the
  email + BankID routes answer 503 (retry), never creating an account.
- pg-real: the RLS delete test seeded its row inside withUserContext, which
  always rolls back, so the owner DELETE saw zero rows. Seed on the superuser
  pool instead.
- Anonymize every test/fixture brand to the repo's existing synthetic
  placeholder (Siffra / app.siffra.se): no real partner names in code.
- SignupAccessManager: functional setData updates so a concurrent mode
  toggle and an add/remove do not clobber each other's snapshot (CodeRabbit).
- Route a transient-error message through i18n instead of the raw envelope
  (raw-user-error guard); new register.error_temporary sv+en.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ByL5dQXG8gGLtNBPj8g2C4

* test(white-label): anonymize new signup-gate fixtures; log oracle residual

Rename the placeholder brand in the four new brand-signup test files to a
clearly-fake, partner-unrelated name (Testbrand / app.testbrand.example);
the previous placeholder echoed a real partner. Scoped to files this PR
creates; the repo-wide legacy placeholder is left for a separate cleanup.

Also record in DECISIONS.md that the feature ships accepting the
low-severity allowlist-enumeration residual (captcha-free 403 vs 200 on
the signup endpoint), with rate-limiting as the follow-up option.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ByL5dQXG8gGLtNBPj8g2C4

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-27 18:32:52 +02:00

225 lines
8.2 KiB
TypeScript

import 'server-only'
/**
* Invite-only signup gate for white-label brand domains (founder decision
* 2026-08-27): a brand domain belongs to the partner's people, so when a
* brand has signup_mode = 'invite_only', creating an account on that domain
* requires either a brand_signup_allowlist entry for the email or a valid
* pending company invite for it. Everyone else is sent to the canonical
* signup by the register page's interstitial.
*
* Enforced SERVER-SIDE at the moment an account would be created, on every
* signup path:
* - email+password: POST /api/auth/signup (the register page no longer
* calls supabase.auth.signUp from the browser on any host, because a
* client-side check would be bypassable)
* - BankID: extensions/general/tic /bankid/complete (signup mode)
* - Google OAuth: the account exists after the OAuth round-trip, so the
* dashboard layout's domain gate bounces non-belonging sessions to the
* canonical domain instead
*
* Uses the cookieless service client: the visitor is anonymous at signup
* time, so RLS cannot scope these reads. Fail-CLOSED on the allowlist and
* invite lookups: on a transient query error a gated brand refuses the
* signup rather than silently opening the door.
*/
import { createServiceClientNoCookies } from '@/lib/auth/api-keys'
import { INVITE_COOKIE_NAME } from '@/lib/auth/consume-invite-cookie'
import { hashInviteToken } from '@/lib/auth/invite-tokens'
import {
normalizeHost,
resolveBrandByHost,
resolveBrandResultByHost,
type Brand,
} from '@/lib/branding/resolve'
import { createLogger } from '@/lib/logger'
const log = createLogger('brand-signup-gate')
export type BrandSignupGateResult =
| {
allowed: true
brand: Brand | null
/** What let the signup through, for logging and tests. */
via: 'no_brand' | 'open' | 'allowlist' | 'invite'
}
| { allowed: false; brand: Brand }
// The brands lookup itself failed (transient DB error). The caller must
// fail SAFE (retry / 503), never treat this as an unbranded host, or a
// blip would open invite-only signup.
| { allowed: false; brand: null; lookupFailed: true }
/**
* Whether `email` is on the brand's signup allowlist. Case-insensitive: the
* table stores lowercase (CHECK-enforced) and the lookup lowercases too.
* Fail-closed: a query error reads as "not allowlisted".
*/
export async function isEmailOnBrandAllowlist(
brandId: string,
email: string,
): Promise<boolean> {
const normalized = email.trim().toLowerCase()
if (!normalized) return false
const supabase = createServiceClientNoCookies()
const { data, error } = await supabase
.from('brand_signup_allowlist')
.select('id')
.eq('brand_id', brandId)
.eq('email', normalized)
.limit(1)
.maybeSingle()
if (error) {
log.error('allowlist lookup failed; treating as not allowlisted', {
brandId,
message: error.message,
})
return false
}
return data !== null
}
/**
* Whether `inviteToken` is a live company invite for `email`: pending,
* unexpired, and addressed to the same email (case-insensitive). The invite
* itself is the authorization, so it bypasses the allowlist. Mirrors the
* acceptance checks in /api/team/accept and /auth/callback; acceptance
* re-validates everything, so this gate can stay a read.
*/
async function isValidInviteForEmail(
inviteToken: string,
email: string,
): Promise<boolean> {
const supabase = createServiceClientNoCookies()
const { data, error } = await supabase
.from('company_invitations')
.select('email, status, expires_at')
.eq('token_hash', hashInviteToken(inviteToken))
.maybeSingle()
if (error) {
log.error('invite lookup failed; treating as invalid', { message: error.message })
return false
}
if (!data) return false
return (
data.status === 'pending' &&
new Date(data.expires_at) > new Date() &&
data.email.toLowerCase() === email.trim().toLowerCase()
)
}
/**
* Decide whether a signup with `email` may proceed on `host`.
*
* Allowed when the host has no brand (canonical and unknown hosts, the
* additive guarantee), the brand is open, the email is allowlisted, or a
* valid invite token rides along (the gnubok-invite-token cookie set by
* /invite/[token]).
*/
export async function evaluateBrandSignupGate(opts: {
host: string | null | undefined
email: string
inviteToken?: string | null
}): Promise<BrandSignupGateResult> {
const { brand, lookupFailed } = opts.host
? await resolveBrandResultByHost(opts.host)
: { brand: null, lookupFailed: false }
if (lookupFailed) {
// Do not fall through to no_brand: a transient brands-table error must
// not open an invite-only domain. The caller turns this into a 503.
log.error('brand lookup failed; refusing to decide signup gate')
return { allowed: false, brand: null, lookupFailed: true }
}
if (!brand) return { allowed: true, brand: null, via: 'no_brand' }
if (brand.signupMode !== 'invite_only') return { allowed: true, brand, via: 'open' }
if (await isEmailOnBrandAllowlist(brand.id, opts.email)) {
return { allowed: true, brand, via: 'allowlist' }
}
if (opts.inviteToken && (await isValidInviteForEmail(opts.inviteToken, opts.email))) {
return { allowed: true, brand, via: 'invite' }
}
// Observability, not enumeration: log the brand and outcome, never the
// attempted address.
log.info('signup blocked on invite-only brand domain', { brandId: brand.id, domain: brand.domain })
return { allowed: false, brand }
}
/**
* Logged-in counterpart of the signup gate, for the dashboard layout: on an
* invite-only brand host, a session that does not belong to the brand (no
* team membership on the brand's team, no company on it, not allowlisted,
* no pending invite) is bounced to the canonical domain instead of getting
* a branded shell. Returns the absolute URL to redirect to, or null to stay.
*
* A NAVIGATION rule like the home-domain rule (WL-01), not a security
* boundary: data access is governed by membership and RLS regardless of
* host. That is why the pending-invite check is presence-only here; the
* actual invite acceptance re-validates the token server-side.
*/
export async function resolveBrandDomainBounce(opts: {
host: string
userEmail: string | null | undefined
/** teams.id of every team the user belongs to (any role). */
teamIds: string[]
/** companies.team_id of every company the user belongs to. */
companyTeamIds: Array<string | null | undefined>
hasPendingInviteCookie: boolean
/** getBranding().appUrl: where non-belonging sessions are sent. */
canonicalAppUrl: string
}): Promise<string | null> {
const brand = opts.host ? await resolveBrandByHost(opts.host) : null
if (!brand || brand.signupMode !== 'invite_only') return null
if (opts.teamIds.includes(brand.teamId)) return null
if (opts.companyTeamIds.some((teamId) => teamId === brand.teamId)) return null
if (opts.hasPendingInviteCookie) return null
if (opts.userEmail && (await isEmailOnBrandAllowlist(brand.id, opts.userEmail))) {
return null
}
// Never bounce onto the same host (misconfigured canonical URL would
// otherwise loop), and never bounce when no canonical URL is known.
let canonicalHost: string
try {
canonicalHost = new URL(opts.canonicalAppUrl).hostname
} catch {
return null
}
if (!canonicalHost || canonicalHost === normalizeHost(opts.host)) return null
log.info('bouncing non-member session off invite-only brand domain', {
brandId: brand.id,
domain: brand.domain,
})
return opts.canonicalAppUrl
}
/**
* The pending-invite token from a raw Cookie header, for server routes that
* hold a Request rather than a Next.js cookie store. The cookie is set by
* /invite/[token] (not httpOnly, so the client auth surfaces read it too).
*/
export function readInviteTokenFromCookieHeader(header: string | null): string | null {
if (!header) return null
for (const part of header.split(';')) {
const eq = part.indexOf('=')
if (eq === -1) continue
if (part.slice(0, eq).trim() !== INVITE_COOKIE_NAME) continue
const value = part.slice(eq + 1).trim()
if (!value) return null
try {
return decodeURIComponent(value)
} catch {
return value
}
}
return null
}