Jakob Wennberg
ec27228a8e
Em dashes (—) and en dashes (–) had spread across comments, docs, tests, and a few UI strings, reading as AI-generated boilerplate rather than house style. Replaced each with punctuation matching its context: colon for explanatory clauses, comma for asides, plain hyphen for numeric/legal ranges (e.g. "21-23§"), "to"/"till" for date ranges, parentheses for paired-dash asides. messages/en.json and messages/sv.json were fixed by hand together to keep sv/en in sync. Left untouched where the dash is the functional subject rather than decorative punctuation: date-range-parser.ts's separator regex, charset-repair.ts's CP1252 byte-mapping table (and its test), the SIE encoding mojibake docs, generic-csv.ts's minus-sign normalizer, the agent system-prompt files that already instruct against em dashes, and a golden iXBRL test fixture compared byte-for-byte. Also fixes two bugs surfaced along the way: an off-by-one in ApiKeysPanel's scope-label split (a leftover from an earlier partial pass), and a charset-repair test that had lost the literal en-dash it exists to verify. Regenerated the agent atom seed migration (skills:generate) since 27 SKILL.md files changed. Added a CLAUDE.md rule against em/en dashes, with an explicit carve-out for the functional-dash cases above. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
31 lines
1.1 KiB
TypeScript
31 lines
1.1 KiB
TypeScript
import type { SupabaseClient } from '@supabase/supabase-js'
|
|
|
|
/**
|
|
* Assign an article number to an article row via the generate_article_number
|
|
* RPC. Idempotent: if the row already has a number, the RPC returns it unchanged
|
|
* without consuming a sequence number. Concurrency is handled inside the RPC via
|
|
* a row lock on the article plus an atomic counter on company_settings: two
|
|
* callers racing on the same article both return the same number and the counter
|
|
* advances by exactly one.
|
|
*
|
|
* Mirrors lib/invoices/ensure-invoice-number.ts. Unlike invoice numbers, article
|
|
* numbers are master data and carry no BFL sequence/immutability obligation, so
|
|
* a gap is harmless.
|
|
*/
|
|
export async function ensureArticleNumber(
|
|
supabase: SupabaseClient,
|
|
companyId: string,
|
|
articleId: string,
|
|
): Promise<string> {
|
|
const { data, error } = await supabase.rpc('generate_article_number', {
|
|
p_company_id: companyId,
|
|
p_article_id: articleId,
|
|
})
|
|
|
|
if (error || !data) {
|
|
throw new Error(`Failed to assign article number: ${error?.message ?? 'no value returned'}`)
|
|
}
|
|
|
|
return data as string
|
|
}
|