Files
accounted/extensions/general/enable-banking/lib/__tests__/trigger-sync.test.ts
T
Mattsson b68c082ef5 feat(bank-sync): close the F2 report: gap backfill, consent and paused chip states, agent-triggered sync (#2165)
* fix(bank-sync): cron backfills the gap since the last successful sync

The daily incremental sync always asked the bank for the last 7 days. Any
pause longer than that (a lapsed subscription paid again, a consent renewed
after expiry, an outage) silently lost the days in between: the connection
came back, looked healthy, and the missing transactions never arrived.

The lookback now widens to cover the gap since last_synced_at plus one day
of overlap, capped at the 90-day PSD2 limit, and a gap of a month or more
asks for strategy=longest like the manual sync route does. Dedup via
external_id makes the overlap harmless. First syncs keep their 90-day path.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS

* feat(bank-sync): chip warns seven days before a bank consent expires

The transactions-page chip only reacted once a connection was already dead
(expired/error) or had gone stale. A consent that is about to end looked
healthy until the morning it stopped syncing. New "expiring" state when a
live connection's consent_expires is within seven days, the same threshold
as the consent-expiry email in the sync cron. Precedence: attention,
expiring, stale, healthy.

getChipState moves to lib/transactions/bank-sync-chip-state.ts so the
precedence is unit-tested; the component keeps the rendering only.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS

* feat(bank-sync): chip says paused when the subscription lapsed

The daily cron filters connections by the bank_sync capability, so a
company whose trial or subscription ended keeps status=active rows with a
frozen last_synced_at. The chip read that as "stale, check the connection",
which sends the user to re-authorise a connection that is perfectly alive.
56 of 191 active connections on prod were in this state on 2026-09-01.

New "paused" state, ranked above everything else, when the company lacks
bank_sync: hosted points at billing, self-host at the connector key, the
same split BankSyncNowButton already makes. getChipState takes an options
object so the clock stays out of render (react-hooks/purity).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS

* feat(api): agent-triggerable bank sync in v1 and MCP

Closes the first wish in the F2 report: an integration could read bank
data but never refresh it. New POST /api/v1/companies/{id}/bank-connections/
{connectionId}/sync and MCP gnubok_sync_bank, both on a shared runner
(extensions/general/enable-banking/lib/trigger-sync.ts).

Cost is bounded structurally, not by policy: the window is never
caller-controlled (the cron's gap-aware 7 to 90 day lookback), a connection
synced within 15 minutes answers BANK_SYNC_COOLDOWN with next_allowed_at
(429 + Retry-After on v1; synced=false in-band on MCP so the agent reads on
instead of retrying), and a failing connection is throttled per process by
attempt time. A dead session is flipped to expired with a remediation that
hands the user the connect link: no API call revives a consent.

Gated on bank_sync like gnubok_connect_bank; scope transactions:write.
Registry, scope map, load-routes, spec snapshot and the generated
accounted-api skill updated; five BANK_SYNC_* / BANK_SESSION_EXPIRED codes
added to the structured-error registry. The web Synka-nu route is left as
is (see DECISIONS.md).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS

* test(bank-sync): use the options object in the remaining chip-state calls

Four multi-line calls still passed the clock positionally after
getChipState moved to an options object; tsc flagged them (vitest did not,
the extra argument was ignored at runtime).

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS

* fix(api): address skeptic findings on the agent-triggered bank sync

Three refutations from the pre-publish skeptic pass:

1. Core imported the extension. The v1 sync route pulled the runner
   straight from @/extensions, which the core-build gate rejects and which
   left a live bank endpoint on zero-extension builds. The route now
   resolves it through the registry's services channel against a contract
   in lib/bank-sync/trigger-sync-contract.ts (same pattern as the
   Skatteverket read service) and answers EXTENSION_DISABLED when the
   extension is absent.

2. The idempotency cache stored the handler-level 429. A same-key retry
   after Retry-After, which is the documented retry, replayed the stale
   cooldown as a 400 for the cache's 24-hour TTL. withApiV1 no longer
   caches 429 responses; regression test added. The endpoint's pitfall no
   longer claims Idempotency-Key is mandatory (it was never enforced).

3. Two cron tests read the clock twice and failed whenever a millisecond
   passed between the reads. They now pin the clock with fake timers.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QdcDV7CngLkWUvfKSsxFhS

* fix(bank-sync): durable cooldown lease and review wording

Resolves the PR #2165 review findings in one pass.

Superagent P1: the attempt throttle was a process-local Map, so two agent
calls on different serverless instances (or a retry after a cold start on
a failing connection) could each bill an Enable Banking call, contradicting
the one-sync-per-15-minutes promise. New bank_connections.sync_lease_until
(migration 20260902150000), claimed with one conditional UPDATE before the
bank is called; Postgres row locking makes exactly one claimer win, the
rest answer BANK_SYNC_COOLDOWN. The lease stays for the full window on
success and failure. Tests cover the claim order, a failed attempt seen
from a second instance, a lost race, and an expired lease.

CodeRabbit: the =1 plural branch now reads "in 1 day" / "om 1 dag"
(daysUntilConsentExpiry rounds a partial day up, so "tomorrow" could be
today); the cooldown pitfall on the v1 endpoint, the MCP description and
the in-band cooldown instruction now say a cooldown can follow a failed
attempt and tell the agent to compare last_synced_at before deciding.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub

* fix(bank-sync): lease claim as a literal filter for the schema guard

CI's no-phantom-columns guard counts runtime-built query expressions and
its ceiling is exact; the templated `.or('sync_lease_until.is.null,...')`
claim added one. The column now defaults to epoch (NOT NULL), so "never
claimed" is just "expired long ago" and the atomic claim is a single
literal `.lte('sync_lease_until', now)` the guard can check. Migration is
unshipped (same PR), so it is edited in place.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub

* fix(bank-sync): runner verifies company membership before the lease

Superagent (round 3): the MCP path reached the shared runner without a
membership check of its own. Both callers do enforce it upstream
(withApiV1's company resolution and resolveMcpCompanyContext in the MCP
dispatcher), but the runner writes transactions and bills a bank call, so
it now checks company_members itself, before the cooldown and the lease
claim, and answers NOT_FOUND for a non-member. The viewer check that was
buried inside the sync block moves up with it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0125TMQQBjBBZG9YxP7wQWub

---------

Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
2026-09-02 17:17:41 +02:00

270 lines
11 KiB
TypeScript

import { beforeEach, describe, expect, it, vi } from 'vitest'
const mocks = vi.hoisted(() => ({
syncAccountTransactions: vi.fn(),
updateBalancesFromSync: vi.fn(),
emit: vi.fn(),
}))
vi.mock('../sync', () => ({
syncAccountTransactions: (...args: unknown[]) => mocks.syncAccountTransactions(...args),
}))
vi.mock('@/lib/cash-accounts/service', () => ({
updateBalancesFromSync: (...args: unknown[]) => mocks.updateBalancesFromSync(...args),
}))
vi.mock('@/lib/events/bus', () => ({
eventBus: { emit: (...args: unknown[]) => mocks.emit(...args) },
}))
import { SessionExpiredError, REAUTH_REQUIRED_MESSAGE } from '../api-client'
import { SYNC_COOLDOWN_MS, triggerConnectionSync } from '../trigger-sync'
const COMPANY_ID = 'aaaaaaaa-aaaa-4aaa-8aaa-aaaaaaaaaaaa'
const CONNECTION_ID = '11111111-1111-4111-8111-111111111111'
const NOW = Date.parse('2026-09-02T09:00:00Z')
const DAY_MS = 24 * 60 * 60 * 1000
interface State {
connection: Record<string, unknown> | null
membershipRole: string | null
sieOverlap: boolean
updates: Record<string, unknown>[]
/**
* The durable lease as the database holds it (epoch when never claimed).
* The conditional UPDATE the runner issues (`sync_lease_until <= now`) is
* reproduced here: a held lease makes the claim return no row.
*/
leaseUntil: string
}
const EPOCH = '1970-01-01T00:00:00.000Z'
function makeClient(state: State) {
return {
from: (table: string) => {
let updatePayload: Record<string, unknown> | null = null
let lteFilter: { column: string; value: string } | null = null
const chain: Record<string, unknown> = {}
const passthrough = ['select', 'eq', 'gte', 'order', 'limit', 'in']
for (const m of passthrough) chain[m] = vi.fn(() => chain)
chain.lte = vi.fn((column: string, value: string) => {
lteFilter = { column, value }
return chain
})
chain.update = vi.fn((payload: Record<string, unknown>) => {
updatePayload = payload
return chain
})
const resolve = () => {
if (updatePayload && 'sync_lease_until' in updatePayload) {
// Atomic claim: `.lte('sync_lease_until', <now>)`.
if (lteFilter?.column !== 'sync_lease_until') {
throw new Error('lease claim must carry the conditional filter')
}
if (state.leaseUntil > lteFilter.value) return { data: [], error: null }
state.leaseUntil = updatePayload.sync_lease_until as string
state.updates.push(updatePayload)
return { data: [{ id: CONNECTION_ID }], error: null }
}
if (updatePayload) {
state.updates.push(updatePayload)
return { data: null, error: null }
}
if (table === 'bank_connections') return { data: state.connection, error: null }
if (table === 'company_members')
return { data: state.membershipRole ? { role: state.membershipRole } : null, error: null }
if (table === 'sie_imports') return { data: state.sieOverlap ? { id: 'sie-1' } : null, error: null }
if (table === 'transactions') return { data: [{ id: 'tx-1' }], error: null }
return { data: null, error: null }
}
chain.maybeSingle = vi.fn(() => Promise.resolve(resolve()))
chain.then = (onFulfilled: (v: unknown) => unknown) => Promise.resolve(resolve()).then(onFulfilled)
return chain
},
}
}
function connection(overrides: Record<string, unknown> = {}) {
return {
id: CONNECTION_ID,
company_id: COMPANY_ID,
bank_name: 'Swedbank',
status: 'active',
accounts_data: [
{ uid: 'acc-1', currency: 'SEK', enabled: true, balance: 100 },
{ uid: 'acc-2', currency: 'SEK', enabled: false, balance: 5 },
],
last_synced_at: new Date(NOW - 2 * DAY_MS).toISOString(),
error_message: null,
sync_lease_until: EPOCH,
...overrides,
}
}
const log = { info: vi.fn(), warn: vi.fn(), error: vi.fn() }
let state: State
function run(now = NOW) {
return triggerConnectionSync(makeClient(state) as never, {
companyId: COMPANY_ID,
userId: 'user-1',
connectionId: CONNECTION_ID,
log,
now,
})
}
describe('triggerConnectionSync', () => {
beforeEach(() => {
vi.clearAllMocks()
state = {
connection: connection(),
membershipRole: 'owner',
sieOverlap: false,
updates: [],
leaseUntil: EPOCH,
}
mocks.syncAccountTransactions.mockResolvedValue({ imported: 2, duplicates: 5, errors: 0 })
mocks.updateBalancesFromSync.mockResolvedValue(undefined)
mocks.emit.mockResolvedValue(undefined)
})
it('syncs only the enabled accounts over the gap-aware window and stamps last_synced_at', async () => {
const result = await run()
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result).toMatchObject({ connection_id: CONNECTION_ID, bank: 'Swedbank', imported: 2, duplicates: 5 })
// Synced 2 days ago: the 7-day floor applies.
expect(result.from_date).toBe(new Date(NOW - 7 * DAY_MS).toISOString().split('T')[0])
expect(result.to_date).toBe('2026-09-02')
expect(mocks.syncAccountTransactions).toHaveBeenCalledTimes(1)
expect(mocks.syncAccountTransactions.mock.calls[0][4]).toMatchObject({ uid: 'acc-1' })
expect(state.updates.at(-1)).toMatchObject({ last_synced_at: result.last_synced_at })
// Write-back keeps the disabled account so the user's selection survives.
expect((state.updates.at(-1)!.accounts_data as unknown[]).length).toBe(2)
expect(mocks.updateBalancesFromSync).toHaveBeenCalledTimes(1)
expect(mocks.emit).toHaveBeenCalledWith(expect.objectContaining({ type: 'transaction.synced' }))
})
it('widens the window to cover a longer gap and asks for the deepest history past a month', async () => {
state.connection = connection({ last_synced_at: new Date(NOW - 40 * DAY_MS).toISOString() })
const result = await run()
expect(result.ok).toBe(true)
if (!result.ok) return
expect(result.from_date).toBe(new Date(NOW - 41 * DAY_MS).toISOString().split('T')[0])
expect(mocks.syncAccountTransactions.mock.calls[0][8]).toMatchObject({ strategy: 'longest' })
})
it('refuses with a cooldown when the connection synced within 15 minutes', async () => {
const syncedAt = NOW - 5 * 60 * 1000
state.connection = connection({ last_synced_at: new Date(syncedAt).toISOString() })
const result = await run()
expect(result).toMatchObject({
ok: false,
code: 'BANK_SYNC_COOLDOWN',
next_allowed_at: new Date(syncedAt + SYNC_COOLDOWN_MS).toISOString(),
retry_after_seconds: 600,
})
expect(mocks.syncAccountTransactions).not.toHaveBeenCalled()
})
it('claims the durable lease before calling the bank', async () => {
await run()
expect(state.leaseUntil).toBe(new Date(NOW + SYNC_COOLDOWN_MS).toISOString())
// The claim is issued before syncAccountTransactions: the lease row
// update is the first write recorded.
expect(state.updates[0]).toEqual({ sync_lease_until: state.leaseUntil })
})
it('throttles a failing connection by the lease, not only by last_synced_at', async () => {
mocks.syncAccountTransactions.mockRejectedValue(new Error('ASPSP 500'))
const first = await run()
expect(first).toMatchObject({ ok: false, code: 'BANK_SYNC_FAILED' })
// A second instance re-reads the row: the lease is now held.
state.connection = connection({ sync_lease_until: state.leaseUntil })
const second = await run(NOW + 60 * 1000)
expect(second).toMatchObject({
ok: false,
code: 'BANK_SYNC_COOLDOWN',
next_allowed_at: state.leaseUntil,
retry_after_seconds: 14 * 60,
})
expect(mocks.syncAccountTransactions).toHaveBeenCalledTimes(1)
})
it('loses the race to a concurrent claimer and never calls the bank', async () => {
// Our read saw no lease; between the read and the claim another
// serverless instance took it. The conditional UPDATE returns no row.
state.leaseUntil = new Date(NOW + SYNC_COOLDOWN_MS - 1000).toISOString()
const result = await run()
expect(result).toMatchObject({ ok: false, code: 'BANK_SYNC_COOLDOWN' })
expect(mocks.syncAccountTransactions).not.toHaveBeenCalled()
expect(mocks.updateBalancesFromSync).not.toHaveBeenCalled()
})
it('accepts a sync once a previous lease has expired', async () => {
state.leaseUntil = new Date(NOW - 1000).toISOString()
state.connection = connection({ sync_lease_until: state.leaseUntil })
const result = await run()
expect(result.ok).toBe(true)
expect(state.leaseUntil).toBe(new Date(NOW + SYNC_COOLDOWN_MS).toISOString())
})
it('answers NOT_FOUND for a connection outside the company or a non-uuid id', async () => {
state.connection = null
expect(await run()).toMatchObject({ ok: false, code: 'NOT_FOUND' })
const bogus = await triggerConnectionSync(makeClient(state) as never, {
companyId: COMPANY_ID,
userId: 'user-1',
connectionId: 'not-a-uuid',
log,
now: NOW,
})
expect(bogus).toMatchObject({ ok: false, code: 'NOT_FOUND' })
})
it('answers NOT_FOUND when the caller is not a member of the company, before any lease or bank call', async () => {
state.membershipRole = null
expect(await run()).toMatchObject({ ok: false, code: 'NOT_FOUND' })
expect(state.leaseUntil).toBe(EPOCH)
expect(mocks.syncAccountTransactions).not.toHaveBeenCalled()
})
it('refuses an expired or pending connection: only BankID can fix those', async () => {
state.connection = connection({ status: 'expired' })
expect(await run()).toMatchObject({ ok: false, code: 'BANK_SYNC_NOT_ACTIVE', status: 'expired' })
state.connection = connection({ status: 'pending_selection' })
expect(await run()).toMatchObject({ ok: false, code: 'BANK_SYNC_NOT_ACTIVE' })
expect(mocks.syncAccountTransactions).not.toHaveBeenCalled()
})
it('retries an errored connection and recovers it to active on success', async () => {
state.connection = connection({ status: 'error', error_message: 'Banksynkningen misslyckades.' })
const result = await run()
expect(result.ok).toBe(true)
expect(state.updates.at(-1)).toMatchObject({ status: 'active', error_message: null })
})
it('refuses when every account is deselected', async () => {
state.connection = connection({ accounts_data: [{ uid: 'acc-1', enabled: false }] })
expect(await run()).toMatchObject({ ok: false, code: 'BANK_SYNC_NO_ACCOUNTS' })
})
it('flips the connection to expired when the bank reports the session dead', async () => {
mocks.syncAccountTransactions.mockRejectedValue(new SessionExpiredError(401, 'consent closed'))
const result = await run()
expect(result).toMatchObject({ ok: false, code: 'BANK_SESSION_EXPIRED', status: 'expired' })
expect(state.updates.at(-1)).toMatchObject({ status: 'expired', error_message: REAUTH_REQUIRED_MESSAGE })
})
it('suppresses auto-categorisation over a completed SIE import and for viewers', async () => {
state.sieOverlap = true
state.membershipRole = 'viewer'
await run()
expect(mocks.syncAccountTransactions.mock.calls[0][8]).toMatchObject({
skipAutoCategorization: true,
rawInsertOnly: true,
})
})
})