Files
accounted/components/settings/__tests__/members-payload.test.ts
T
Mattsson aabddb592f feat(billing): multi-user paywall: multi_user capability, 20-day grace, owner-only dormancy (#2099)
* feat(billing): multi-user seat gate: multi_user capability, 20-day grace, owner-only dormancy

Multiple people in one company becomes a paid capability (multi_user, the
eighth PAID key). Derived at access time from capability_grants, no status
column, no enforcement cron:

- entitled: active grant (trial/stripe/team/manual/comp), everyone works
- grace: newest grant expired < 20 days ago; countdown banner for everyone
  in companies with > 1 user; invites still allowed
- frozen: only role=owner resolves; other memberships go dormant (rows
  untouched, paying reactivates instantly); invites 403 with paid-plan upsell

Enforcement: new resolve_active_company_gated RPC (zero-arg RPC and RLS twin
untouched: they also run on self-hosts, where the gate never bites), gated
query fallback for service-role/API-key paths, setActiveCompany guard, MCP
company-access check, invite route. Middleware routes all-frozen users to a
new /paused page; the switcher greys locked companies.

Migration 20260901081417 (applied to staging): trial trigger seeds
multi_user, backfills for mid-trial companies, active Stripe subs, team
agreements, and a grandfather grant (expires now, i.e. grace = deploy + 20
days) for existing unpaid multi-member companies. Daily cron mails owners at
grace start and last day. Strings in sv+en; pg-real + unit tests included.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L4tNt8wRG3a5iuU1JE2pnP

* fix(billing): multi-user seat gate hardening from skeptic review

- Stripe cancel now EXPIRES the multi_user stripe grant instead of deleting
  it: the 20-day grace window hangs on an expired row, so a deleted one
  froze churned payers' staff instantly with no banner and no mail. Other
  stripe grants keep the freeze-and-retain delete.
- New SECURITY DEFINER company_multi_user_state() RPC (migration
  20260901083726, applied to staging) and RPC-first getMultiUserState:
  capability_grants RLS hides team-scoped rows from non-team users, so
  user-client reads misread byra-covered companies as frozen (switch
  refusal, wrong switcher locks).
- Byra-kind teams get a standing team-scoped multi_user grant (backfill +
  teams trigger): byra client companies have no company-scoped trial by
  design, so a grantless byra team would freeze every consultant and
  client user.
- Comped/manual companies with active PAID-key grants extend to multi_user
  (a comped company must not read as paying while locking out user two).
- /api/v1 gets the same dormancy gate as MCP (frozen non-owner -> 403).
- PGRST202 on resolution fails OPEN (pre-migration DB has zero multi_user
  rows; the gated fallback would have frozen every non-owner mid-deploy).
- Grace cron: covers team-scoped lapses (byra agreement ending) and skips
  the start mail for the hand-mailed grandfather cohort.
- Tests updated/added across all touched surfaces; pg tests for the new
  RPC and byra trigger; trial-suppression pg test extended to 8 keys.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L4tNt8wRG3a5iuU1JE2pnP

* fix(billing): decouple seat-gate env check and fail open on gate read throws

CI round 1 on #2099:
- isMultiUserEnforced no longer imports has-capability: several route test
  suites partially mock that module and the vitest mock guard threw from
  inside the v1 seat gate, turning expected 4xx responses into 500s.
  multi_user is never a connector capability, so the bypass reduces to the
  same env reads, now inlined.
- getMultiUserState wraps its resolution in a fail-open try/catch: a client
  without .rpc or a thrown network error must never lock users out.
- no-phantom-columns ceiling 391 -> 393 with reasons: the seat gate's .or()
  scope filter (server-resolved UUIDs) and the Stripe cancel expiry update's
  timestamp .or(); all columns in both strings are literals.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L4tNt8wRG3a5iuU1JE2pnP

* fix(billing): membership-guard the multi-user entitlement RPCs (Superagent P3)

company_multi_user_ok and company_multi_user_state are SECURITY DEFINER and
were granted to authenticated with a caller-supplied company UUID: any
logged-in user could probe an arbitrary company's billing state and grace
deadline across tenants. Migration 20260901091752 (applied to staging)
requires an auth.uid() membership in the target company when a JWT is
present, keeps service-role/definer contexts unrestricted, and clamps the
grace window to [0, 20] days. pg tests: stranger gets false/NULL, member
reads normally, oversized p_grace_days cannot widen the probe.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01L4tNt8wRG3a5iuU1JE2pnP

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-09-01 11:29:12 +02:00

131 lines
4.6 KiB
TypeScript

import { describe, expect, it } from 'vitest'
import {
parseCompanyMembersPayload,
parseTeamMembersPayload,
} from '@/components/settings/members-payload'
// Read-side guards for the member rosters. A 200 whose body does not carry
// the expected lists is a failed read, not an empty roster: the original bug
// was `setMembers(data.data.members)` straight off `res.json()`, so a
// wrong-shape 200 rendered an apparently member-less company, and a
// consultant looking at that list re-invites people who are already members.
describe('parseCompanyMembersPayload', () => {
const valid = {
data: {
members: [{ id: 'm1', email: 'anna@example.se' }],
invitations: [{ id: 'i1', email: 'bo@example.se' }],
canInvite: true,
},
}
it('passes a well-formed payload through', () => {
expect(parseCompanyMembersPayload(valid)).toEqual({
members: [{ id: 'm1', email: 'anna@example.se' }],
invitations: [{ id: 'i1', email: 'bo@example.se' }],
canInvite: true,
inviteRequiresUpgrade: false,
})
})
it('accepts a confirmed-empty roster (that is data, not a failure)', () => {
expect(
parseCompanyMembersPayload({ data: { members: [], invitations: [], canInvite: false } }),
).toEqual({ members: [], invitations: [], canInvite: false, inviteRequiresUpgrade: false })
})
it('rejects a 200 with no data envelope instead of fabricating an empty roster', () => {
expect(parseCompanyMembersPayload({})).toBeNull()
expect(parseCompanyMembersPayload(null)).toBeNull()
expect(parseCompanyMembersPayload('ok')).toBeNull()
})
it('rejects a 200 whose data lacks the lists', () => {
expect(parseCompanyMembersPayload({ data: {} })).toBeNull()
expect(parseCompanyMembersPayload({ data: { members: [] } })).toBeNull()
expect(
parseCompanyMembersPayload({ data: { members: 'oops', invitations: [] } }),
).toBeNull()
})
it('only grants canInvite on an explicit boolean true', () => {
// A truthy non-boolean must not unlock the invite form.
expect(
parseCompanyMembersPayload({ data: { members: [], invitations: [], canInvite: 'yes' } }),
).toEqual({ members: [], invitations: [], canInvite: false, inviteRequiresUpgrade: false })
})
it('only swaps the invite form for the upsell on an explicit boolean true', () => {
// Multi-user seat gate: an older server without the field (or junk) keeps
// the form; the invite POST's own 403 is the real enforcement.
expect(
parseCompanyMembersPayload({
data: { members: [], invitations: [], canInvite: true, inviteRequiresUpgrade: 'yes' },
}),
).toEqual({ members: [], invitations: [], canInvite: true, inviteRequiresUpgrade: false })
expect(
parseCompanyMembersPayload({
data: { members: [], invitations: [], canInvite: true, inviteRequiresUpgrade: true },
}),
).toEqual({ members: [], invitations: [], canInvite: true, inviteRequiresUpgrade: true })
})
})
describe('parseTeamMembersPayload', () => {
it('passes a well-formed payload through', () => {
expect(
parseTeamMembersPayload({
data: {
members: [{ id: 'm1' }],
invitations: [{ id: 'i1' }],
teamName: 'Byrån AB',
teamId: 'team-1',
teamKind: 'byra',
isOwner: true,
canInvite: true,
},
}),
).toEqual({
members: [{ id: 'm1' }],
invitations: [{ id: 'i1' }],
teamName: 'Byrån AB',
teamId: 'team-1',
teamKind: 'byra',
isOwner: true,
canInvite: true,
})
})
it('accepts a confirmed-empty roster and missing management fields', () => {
expect(parseTeamMembersPayload({ data: { members: [] } })).toEqual({
members: [],
invitations: [],
teamName: null,
teamId: null,
teamKind: null,
isOwner: false,
canInvite: false,
})
})
it('rejects wrong-shape 200s instead of fabricating an empty roster', () => {
expect(parseTeamMembersPayload({})).toBeNull()
expect(parseTeamMembersPayload(null)).toBeNull()
expect(parseTeamMembersPayload({ data: {} })).toBeNull()
expect(parseTeamMembersPayload({ data: { members: 'oops' } })).toBeNull()
})
it('drops a non-string team name instead of rendering it', () => {
expect(
parseTeamMembersPayload({ data: { members: [], teamName: 42 } }),
).toMatchObject({ members: [], teamName: null })
})
it('only grants management affordances on explicit boolean true', () => {
expect(
parseTeamMembersPayload({
data: { members: [], invitations: 'oops', isOwner: 'yes', canInvite: 1 },
}),
).toMatchObject({ invitations: [], isOwner: false, canInvite: false })
})
})