Files
accounted/components/settings/InvoiceSettingsForm.tsx
T
Mattsson e92b5a59b2 fix(reminders): settings UI discloses that automatic sending is disabled (#2033)
* fix(reminders): settings UI discloses that automatic sending is disabled

The invoice reminder cron has answered 503 since May 2026 (PR #583), so
no automatic reminders are sent, but the settings UI still let users
configure reminder day levels as if sending worked.

Introduce REMINDERS_SENDING_ENABLED (lib/invoices/reminders-enabled.ts)
as the single shared flag read by both sides: the cron route uses it as
its 503 gate (with the original sending pipeline restored behind it, so
re-enabling later is one flag flip), and the invoice settings form shows
an attn notice while the flag is off. Schedule settings stay editable;
notice strings added to both sv and en locales.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NtvffGr6uVk2J2Skuz6L98

* docs(reminders): correct the re-enable contract after skeptic review

The flag docblock, route docblock, and test header claimed flipping
REMINDERS_SENDING_ENABLED alone resumes sending. False on hosted: the
route has had no vercel.json cron entry since PR #559 and the crontab
ratchet pins it in INTENTIONALLY_UNSCHEDULED, and POST requires the cron
secret so no dashboard can trigger it. Rewrite the claims into the real
re-enable checklist and record the pre-flip prerequisites surfaced by
review: invoice_reminders lacks a unique (invoice_id, reminder_level)
constraint and the fee entry is booked before the reminder row, so a run
dying mid-batch double-books the fee; the backlog would get highest-level
reminders first. Comments and a test name only; no runtime change.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NtvffGr6uVk2J2Skuz6L98

---------

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
2026-08-30 21:43:19 +02:00

176 lines
5.7 KiB
TypeScript

'use client'
import { useState } from 'react'
import { useTranslations } from 'next-intl'
import { Switch } from '@/components/ui/switch'
import { AttnLine } from '@/components/ui/attn-line'
import {
SettingsGroup,
SettingsInput,
SettingsReveal,
SettingsRow,
SettingsTextarea,
} from '@/components/settings/SettingsRows'
import { REMINDERS_SENDING_ENABLED } from '@/lib/invoices/reminders-enabled'
import type { CompanySettings } from '@/types'
interface InvoiceSettingsFormProps {
settings: CompanySettings
}
export function InvoiceSettingsForm({ settings }: InvoiceSettingsFormProps) {
const t = useTranslations('settings_invoice_form')
const [sendReminders, setSendReminders] = useState(settings.send_invoice_reminders ?? true)
return (
<>
<SettingsGroup label={t('heading')}>
<SettingsRow label={t('prefix_label')} htmlFor="invoice_prefix" align="baseline">
<SettingsInput
id="invoice_prefix"
name="invoice_prefix"
placeholder={t('prefix_placeholder')}
defaultValue={settings.invoice_prefix || ''}
className="max-w-32 flex-none"
/>
</SettingsRow>
<SettingsRow
label={t('next_number_label')}
htmlFor="next_invoice_number"
align="baseline"
>
<SettingsInput
id="next_invoice_number"
name="next_invoice_number"
type="number"
min="1"
defaultValue={settings.next_invoice_number || 1}
className="max-w-32 flex-none tabular-nums"
/>
</SettingsRow>
<SettingsRow
label={t('default_days_label')}
htmlFor="invoice_default_days"
align="baseline"
>
<SettingsInput
id="invoice_default_days"
name="invoice_default_days"
type="number"
min="0"
defaultValue={settings.invoice_default_days || 30}
className="max-w-24 flex-none tabular-nums"
/>
</SettingsRow>
<SettingsRow
label={t('arrival_start_label')}
htmlFor="next_arrival_number"
help={t('arrival_start_help')}
align="baseline"
>
<SettingsInput
id="next_arrival_number"
name="next_arrival_number"
type="number"
min="1"
defaultValue={settings.next_arrival_number || 1}
className="max-w-32 flex-none tabular-nums"
/>
</SettingsRow>
<SettingsRow
label={t('default_notes_label')}
htmlFor="invoice_default_notes"
help={t('default_notes_help')}
align="baseline"
>
<SettingsTextarea
id="invoice_default_notes"
name="invoice_default_notes"
rows={3}
placeholder={t('default_notes_placeholder')}
defaultValue={settings.invoice_default_notes || ''}
/>
</SettingsRow>
<SettingsRow
label={t('default_our_reference_label')}
htmlFor="default_our_reference"
help={t('default_our_reference_help')}
align="baseline"
>
<SettingsInput
id="default_our_reference"
name="default_our_reference"
placeholder={t('default_our_reference_placeholder')}
defaultValue={settings.default_our_reference || ''}
/>
</SettingsRow>
</SettingsGroup>
<SettingsGroup label={t('reminder_days_heading')} help={t('reminder_days_help')}>
{!REMINDERS_SENDING_ENABLED && (
<AttnLine className="px-1 pt-2">{t('sending_disabled_notice')}</AttnLine>
)}
<SettingsRow
label={t('send_reminders_label')}
htmlFor="send_invoice_reminders"
help={t('send_reminders_help')}
borderless={sendReminders}
>
<Switch
id="send_invoice_reminders"
checked={sendReminders}
onCheckedChange={(v) => setSendReminders(v === true)}
/>
<input type="hidden" name="send_invoice_reminders" value={sendReminders ? 'true' : 'false'} />
</SettingsRow>
<SettingsReveal open={sendReminders}>
<SettingsRow
label={t('reminder_days_level_1')}
htmlFor="reminder_days_level_1"
align="baseline"
>
<SettingsInput
id="reminder_days_level_1"
name="reminder_days_level_1"
type="number"
min="1"
max="365"
defaultValue={settings.reminder_days_level_1 ?? 15}
className="max-w-24 flex-none tabular-nums"
/>
</SettingsRow>
<SettingsRow
label={t('reminder_days_level_2')}
htmlFor="reminder_days_level_2"
align="baseline"
>
<SettingsInput
id="reminder_days_level_2"
name="reminder_days_level_2"
type="number"
min="1"
max="365"
defaultValue={settings.reminder_days_level_2 ?? 30}
className="max-w-24 flex-none tabular-nums"
/>
</SettingsRow>
<SettingsRow
label={t('reminder_days_level_3')}
htmlFor="reminder_days_level_3"
align="baseline"
>
<SettingsInput
id="reminder_days_level_3"
name="reminder_days_level_3"
type="number"
min="1"
max="365"
defaultValue={settings.reminder_days_level_3 ?? 45}
className="max-w-24 flex-none tabular-nums"
/>
</SettingsRow>
</SettingsReveal>
</SettingsGroup>
</>
)
}